From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 2727B2BCAB for ; Wed, 3 Oct 2018 16:04:16 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K98b9p55nBFp for ; Wed, 3 Oct 2018 16:04:16 -0400 (EDT) Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id DAB3E2BC96 for ; Wed, 3 Oct 2018 16:04:15 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 0/2] First part of SQLite error codes refactoring References: From: Vladislav Shpilevoy Message-ID: Date: Wed, 3 Oct 2018 23:04:12 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, AlexeyIvushkin Hi! Thanks for the patchset! Unfortunately, SQLITE_IOERR and CONSTRAINT are not the only error codes. Please, look at enum sql_ret_code in sqliteInt.h All of these codes are errors too and should be refactored alongside with this patch - I mean SQLITE_OK, SQLITE_ERROR, SQLITE_PERM etc. Strictly speaking, I think SQLITE_OK should be removed and be replaced with inlined 0 as it is done in other parts of Tarantool. On 02/10/2018 23:50, AlexeyIvushkin wrote: > From: Morgan-iv > > These 2 patches are the beginning of SQLite error codes refactoring. > Both of them change implementation of affected error codes from > define macro to enum statement, and remove codes that aren't returned > anywhere, but first also remove related function that aren't called > anywhere too. First patch affects SQLITE_IOERR_ codes, second - > SQLITE_CONSTRAINT_ codes. > Final rename of all error codes affected in these 2 patches and > the next several patches in this branch will be applied after removing > all unused error codes and removing all found unused functions related > to affected SQLite error codes > > Issue: https://github.com/tarantool/tarantool/issues/3315 > Branch: https://github.com/tarantool/tarantool/tree/Morgan-iv/gh-3315 > > Morgan-iv (2): > sql: refactor SQLITE_IOERR_ error codes > sql: remove unused SQLITE_CONSTRAINT_ error codes > > src/box/sql/main.c | 51 ---------------------------- > src/box/sql/os_unix.c | 88 ------------------------------------------------- > src/box/sql/sqliteInt.h | 56 ++++++++++++------------------- > 3 files changed, 21 insertions(+), 174 deletions(-) >