From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 8553C2A8C5
	for <tarantool-patches@freelists.org>; Thu, 21 Mar 2019 05:03:36 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id SMIjwGBjwEsW for <tarantool-patches@freelists.org>;
	Thu, 21 Mar 2019 05:03:36 -0400 (EDT)
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id ED5282A8C6
	for <tarantool-patches@freelists.org>; Thu, 21 Mar 2019 05:03:35 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH 2/2] sql: don't change type of
 function's retval after codegen
References: <cover.1552327461.git.korablev@tarantool.org>
 <9a7a2794d68a949b801a3210231a35562fcf8847.1552327461.git.korablev@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <b53195b6-149b-ab82-4ca3-2cae5c634368@tarantool.org>
Date: Thu, 21 Mar 2019 12:03:33 +0300
MIME-Version: 1.0
In-Reply-To: <9a7a2794d68a949b801a3210231a35562fcf8847.1552327461.git.korablev@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, Nikita Pettik <korablev@tarantool.org>

Thanks for the patch!

On 11/03/2019 21:10, Nikita Pettik wrote:
> Proper type of function's returning value is set during names resolution
> (i.e. promotion from struct FuncDef to struct Expr, see
> resolveExprStep()). Accidentally, it was set again during byte-code
> generation for VDBE. What is more, in some cases it was set to a wrong
> type. For instance, built-in function randomblob() returns value to be
> encoded as MP_BIN, so its returning type is SCALAR. However, it was
> reset to INTEGER (as its first argument). This patch simply removes this
> second type promotion.
> ---
>   src/box/sql/expr.c       | 11 -----------
>   test/sql/iproto.result   | 41 +++++++++++++++++++++++++++++++++++++++++
>   test/sql/iproto.test.lua | 15 +++++++++++++++
>   3 files changed, 56 insertions(+), 11 deletions(-)
> 
> diff --git a/test/sql/iproto.result b/test/sql/iproto.result
> index 3a77c8e93..26d55b60c 100644
> --- a/test/sql/iproto.result
> +++ b/test/sql/iproto.result
> +-- Type set during compilation stage, and since min/max are accept
> +-- arguments of all scalar type, we can't say nothing more than
> +-- SCALAR.
> +--
> +cn:execute("SELECT min(1, 2, 3);")
> +---
> +- metadata:
> +  - name: min(1, 2, 3)
> +    type: scalar

This is the case, when a first argument type would be ok. As I
understand, it is illegal to calculate min of multiple different
types, so its rettype should be equal to its first argument. It
is not?

> +  rows:
> +  - [1]
> +...