From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 99ED07030F; Fri, 15 Jan 2021 15:39:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 99ED07030F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1610714388; bh=rAJ6uZsw7WpMOubzhMxMrbHeiMbPSLUjSdLcyLWC5zA=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=LWuFiO51l+JFoUG6qqDokn8hN2ztt9OHB4f/9uNvgCZFR8icDnj73io/Kv8jU2Bo/ HweB5tnFY74ryKk8MxDQZ8EcbYgAZJW3nbNJVaqF16IGfRZMRorDrZGZGLNNgLTKw4 W+LP2aKJ5TgLxPmwFAcAqEOtl6qWj6UgqaOrWYd4= Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 173517030F for ; Fri, 15 Jan 2021 15:39:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 173517030F Received: by smtp57.i.mail.ru with esmtpa (envelope-from ) id 1l0OOI-00028A-1B; Fri, 15 Jan 2021 15:39:46 +0300 To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org Cc: v.shpilevoy@tarantool.org References: <82365527bf3aefe026e0c0e4d93f3acbb882391c.1610709207.git.sergeyb@tarantool.org> Message-ID: Date: Fri, 15 Jan 2021 15:39:45 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <82365527bf3aefe026e0c0e4d93f3acbb882391c.1610709207.git.sergeyb@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D0E79FBC973162CDAC53986DC5FB1AB1465E8C05863AF8B800894C459B0CD1B94C5CC701A178122882485E70D105F1DF6CD06EBA1D6A54F859F445DFCDA6A35E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE751DD1FEBB966604DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063721BEEAF38C6AE0B78638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC6FD3D10E84685BD877730B51A463D3F1A4708834648A2B62389733CBF5DBD5E913377AFFFEAFD269A417C69337E82CC2CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD2691661749BA6B97735C2A068104F3A7B7D7B076A6E789B0E97A8DF7F3B2552694A1E7802607F20496D49FD398EE364050FC65AC60A1F0286FEC8623B8F170C382FB3661434B16C20AC78D18283394535A975ECD9A6C639B01BC09775C1D3CA48CF38259EF895CFD72D35872C767BF85DA22EF20D2F80756B5F40A5AABA2AD3711975ECD9A6C639B01B78DA827A17800CE7993FBFBBCDBC6BC6731C566533BA786A40A5AABA2AD371193C9F3DD0FB1AF5EB82E77451A5C57BD33C9F3DD0FB1AF5EB4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A54FAA45BE9A3333EEB4321E0A5060486D0297D9F7C17A081DD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA758F9E841AEAEC4F2C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AB80C45F81B80D63903A9AFD74E40CDEFF29DEAC300859425214A07FAA440328A645A6548FB6FB381D7E09C32AA3244CC45ADD82385F757097F92B851FF727B8795D98D676DD64D0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojT/h6YDL0UQ7T8hizIkp3ww== X-Mailru-Sender: 583F1D7ACE8F49BDF28A51E06CB90EC1CB28DB18F2C7403D5C42A56D753BC36CC6BEBB53EDAAD30E823C4E0A9438D55D74690CA6451351EDEC462FDC9CAD1E11B969B486931C0B990F27244EEAA5B9A5AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/2] luacheck: fix warnings in test/box X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 15.01.2021 14:22, sergeyb@tarantool.org пишет: > From: Sergey Bronnikov > > Follows up #5455 > --- Thanks for the  patch! LGTM. One question below. > test/box/gh-5304-insert_during_recovery.lua | 10 +++++----- > test/box/gh-5304-replace_during_recovery.lua | 1 + > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/test/box/gh-5304-insert_during_recovery.lua b/test/box/gh-5304-insert_during_recovery.lua > index ac6eef342..c8b6c5cfb 100644 > --- a/test/box/gh-5304-insert_during_recovery.lua > +++ b/test/box/gh-5304-insert_during_recovery.lua > @@ -1,24 +1,24 @@ > #!/usr/bin/env tarantool > > -function none(old_space, new_space) > +local function none(old_space, new_space) -- luacheck: ignore What's "luacheck: ignore" comment for? Haven't you fixed the warning already by introducing `local` ? > end > > -function trigger_replace(old_space, new_space) > +local function trigger_replace(old_space, new_space) -- luacheck: ignore > box.space.temp:replace({1}) > box.space.loc:replace({1}) > end > > -function trigger_insert(old_space, new_space) > +local function trigger_insert(old_space, new_space) -- luacheck: ignore > box.space.temp:insert({1}) > box.space.loc:insert({1}) > end > > -function trigger_upsert(old_space, new_space) > +local function trigger_upsert(old_space, new_space) -- luacheck: ignore > box.space.temp:upsert({1}, {{'=', 1, 4}}) > box.space.loc:upsert({1}, {{'=', 1, 4}}) > end > > -trigger = nil > +local trigger = nil > > if arg[1] == 'none' then > trigger = none > diff --git a/test/box/gh-5304-replace_during_recovery.lua b/test/box/gh-5304-replace_during_recovery.lua > index d6a7099ac..8b9a657af 100644 > --- a/test/box/gh-5304-replace_during_recovery.lua > +++ b/test/box/gh-5304-replace_during_recovery.lua > @@ -2,6 +2,7 @@ > > if arg[1] == 'replace' then > box.ctl.on_schema_init(function() > + -- luacheck: ignore > box.space._index:on_replace(function(old_space, new_space) > if new_space[1] == 512 then > box.space.test:on_replace(function(old_tup, new_tup) -- Serge Petrenko