From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DB72616D2265; Fri, 2 Jan 2026 13:10:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DB72616D2265 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1767348627; bh=HG6eFs+BAvDvi9i1bpKklRPl+pPMrRpluePkzt4aJ0k=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=GouIQBg5s+u7LIQU4AWN/un6oDDWGErOAjvE2+VMEpRoYaMt8IMxlLEtgFyrmL4N9 oq+Jc+9vS6w/U1rg2khKlBjYA9XhqmxFkV1kV6t9lOqvaSuYcIUx3PQICWq/E+3PiU 7VBDlMnTDoasNEOiFgNGkC4/Ao440o21rqSQF8TY= Received: from send219.i.mail.ru (send219.i.mail.ru [95.163.59.58]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3261E16D2265 for ; Fri, 2 Jan 2026 13:10:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3261E16D2265 Received: by exim-smtp-7b4fb89df9-pbtpt with esmtpa (envelope-from ) id 1vbc6y-000000007Om-0cfL; Fri, 02 Jan 2026 13:10:24 +0300 Content-Type: multipart/alternative; boundary="------------v7IIyFT8ZSnax30hoglWX0Ws" Message-ID: Date: Fri, 2 Jan 2026 13:10:23 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <23d14fcc8fd6ba47ea75bd636993d9093fc41a7b.1766738771.git.skaplun@tarantool.org> In-Reply-To: <23d14fcc8fd6ba47ea75bd636993d9093fc41a7b.1766738771.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD979975AF0D777FEBD9A7AA89612843F49E05A58644225EC05182A05F53808504060895572A58D4AD83DE06ABAFEAF6705BA881AE44429F3EB7C6D7116AD8094424044E5D25B716509 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77806F8AEFB2C8BE8EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566D1B0EEF93386A5FD4DBE837EE992D6B9F96A20EAC9126C37DFF4632812EF6411389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B652D31B9D28593E51CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22496040CC107394EA4476E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8B485CA73C03513DAC3AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E7352629B07FD02F83A6C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A519FE7028A774BDA65002B1117B3ED69661D5DF752AFE66F6A9DAB4B68AE4D22F823CB91A9FED034534781492E4B8EEAD47A3109F1ACFD409BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE191716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6598A2DB0B485C49FF5430F7F8026206BD9CBA927F8671F461A0DE9AB9FCDEEA321A0478B5B4AAEBC5BB8341EE9D5BE9A0A3B4E0630FF0F2168D1FF011F897E806444206D734D65D0A48CD93680B12512CF4C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVTZJppT4ZVHR0JbOOl1qCA4= X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F258845895ABFDD49F6E39180B9BF4F79351F757F3B47F32FC5FAA1668C1EB72B7892B76645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 13/41] perf: adjust mandelbrot-bit in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------v7IIyFT8ZSnax30hoglWX0Ws Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey! thanks for the patch! LGTM Sergey On 12/26/25 12:17, Sergey Kaplun wrote: > This patch adjusts the aforementioned test to use the benchmark > framework introduced before. The default arguments are adjusted > according to the file. The arguments to the script still > can be provided in the command line run. > > The output is redirected to /dev/null. The check is skipped since it is > very inconvenient to check the binary output, especially since it may be > configured by the parameter. > --- > perf/LuaJIT-benches/mandelbrot-bit.lua | 91 ++++++++++++++++++-------- > 1 file changed, 63 insertions(+), 28 deletions(-) > > diff --git a/perf/LuaJIT-benches/mandelbrot-bit.lua b/perf/LuaJIT-benches/mandelbrot-bit.lua > index 91d96975..53c3ad4e 100644 > --- a/perf/LuaJIT-benches/mandelbrot-bit.lua > +++ b/perf/LuaJIT-benches/mandelbrot-bit.lua > @@ -1,33 +1,68 @@ > +-- The benchmark to check the performance of multiple inner loops > +-- with arithmetic operations. Bit variation. Calculates the > +-- Mandelbrot Set on a bitmap and dumps output in the portable > +-- bitmap format. > +-- For the details see: > +--https://benchmarksgame-team.pages.debian.net/benchmarksgame/description/mandelbrot.html > > local bit = require("bit") > -local bor, band = bit.bor, bit.band > -local shl, shr, rol = bit.lshift, bit.rshift, bit.rol > -local write, char, unpack = io.write, string.char, unpack > -local N = tonumber(arg and arg[1]) or 100 > -local M, buf = 2/N, {} > -write("P4\n", N, " ", N, "\n") > -for y=0,N-1 do > - local Ci, b, p = y*M-1, -16777216, 0 > - local Ciq = Ci*Ci > - for x=0,N-1,2 do > - local Cr, Cr2 = x*M-1.5, (x+1)*M-1.5 > - local Zr, Zi, Zrq, Ziq = Cr, Ci, Cr*Cr, Ciq > - local Zr2, Zi2, Zrq2, Ziq2 = Cr2, Ci, Cr2*Cr2, Ciq > - b = rol(b, 2) > - for i=1,49 do > - Zi = Zr*Zi*2 + Ci; Zi2 = Zr2*Zi2*2 + Ci > - Zr = Zrq-Ziq + Cr; Zr2 = Zrq2-Ziq2 + Cr2 > - Ziq = Zi*Zi; Ziq2 = Zi2*Zi2 > - Zrq = Zr*Zr; Zrq2 = Zr2*Zr2 > - if band(b, 2) ~= 0 and Zrq+Ziq > 4.0 then b = band(b, -3) end > - if band(b, 1) ~= 0 and Zrq2+Ziq2 > 4.0 then b = band(b, -2) end > - if band(b, 3) == 0 then break end > + > +local bench = require("bench").new(arg) > + > +local N = tonumber(arg and arg[1]) or 5000 > + > +local function payload() > + -- These functions must not be an upvalue but the stack slot. > + local N = N > + local bor, band = bit.bor, bit.band > + local shl, shr, rol = bit.lshift, bit.rshift, bit.rol > + local write, char, unpack = io.write, string.char, unpack > + > + local M, buf = 2 / N, {} > + write("P4\n", N, " ", N, "\n") > + for y = 0, N - 1 do > + local Ci, b, p = y * M - 1, -16777216, 0 > + local Ciq = Ci * Ci > + for x = 0, N - 1, 2 do > + local Cr, Cr2 = x * M - 1.5, (x + 1) * M - 1.5 > + local Zr, Zi, Zrq, Ziq = Cr, Ci, Cr * Cr, Ciq > + local Zr2, Zi2, Zrq2, Ziq2 = Cr2, Ci, Cr2 * Cr2, Ciq > + b = rol(b, 2) > + for i = 1, 49 do > + Zi = Zr * Zi * 2 + Ci; Zi2 = Zr2 * Zi2 * 2 + Ci > + Zr = Zrq - Ziq + Cr; Zr2 = Zrq2 - Ziq2 + Cr2 > + Ziq = Zi * Zi; Ziq2 = Zi2 * Zi2 > + Zrq = Zr * Zr; Zrq2 = Zr2 * Zr2 > + if band(b, 2) ~= 0 and Zrq + Ziq > 4.0 then b = band(b, -3) end > + if band(b, 1) ~= 0 and Zrq2 + Ziq2 > 4.0 then b = band(b, -2) end > + if band(b, 3) == 0 then break end > + end > + if b >= 0 then p = p + 1; buf[p] = b; b = -16777216; end > end > - if b >= 0 then p = p + 1; buf[p] = b; b = -16777216; end > - end > - if b ~= -16777216 then > - if band(N, 1) ~= 0 then b = shr(b, 1) end > - p = p + 1; buf[p] = shl(b, 8-band(N, 7)) > + if b ~= -16777216 then > + if band(N, 1) ~= 0 then b = shr(b, 1) end > + p = p + 1; buf[p] = shl(b, 8 - band(N, 7)) > + end > + write(char(unpack(buf, 1, p))) > end > - write(char(unpack(buf, 1, p))) > end > + > +local stdout = io.output() > + > +bench:add({ > + name = "mandelbrot_bit", > + items = N, > + -- XXX: This is inconvenient to have the binary file in the > + -- repository for the comparison. If the check is needed, run > + -- the payload manually. > + skip_check = true, > + setup = function() > + io.output("/dev/null") > + end, > + teardown = function() > + io.output(stdout) > + end, > + payload = payload, > +}) > + > +bench:run_and_report() --------------v7IIyFT8ZSnax30hoglWX0Ws Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey!

thanks for the patch! LGTM

Sergey

On 12/26/25 12:17, Sergey Kaplun wrote:
This patch adjusts the aforementioned test to use the benchmark
framework introduced before. The default arguments are adjusted
according to the <PARAM_x86.txt> file. The arguments to the script still
can be provided in the command line run.

The output is redirected to /dev/null. The check is skipped since it is
very inconvenient to check the binary output, especially since it may be
configured by the parameter.
---
 perf/LuaJIT-benches/mandelbrot-bit.lua | 91 ++++++++++++++++++--------
 1 file changed, 63 insertions(+), 28 deletions(-)

diff --git a/perf/LuaJIT-benches/mandelbrot-bit.lua b/perf/LuaJIT-benches/mandelbrot-bit.lua
index 91d96975..53c3ad4e 100644
--- a/perf/LuaJIT-benches/mandelbrot-bit.lua
+++ b/perf/LuaJIT-benches/mandelbrot-bit.lua
@@ -1,33 +1,68 @@
+-- The benchmark to check the performance of multiple inner loops
+-- with arithmetic operations. Bit variation. Calculates the
+-- Mandelbrot Set on a bitmap and dumps output in the portable
+-- bitmap format.
+-- For the details see:
+-- https://benchmarksgame-team.pages.debian.net/benchmarksgame/description/mandelbrot.html
 
 local bit = require("bit")
-local bor, band = bit.bor, bit.band
-local shl, shr, rol = bit.lshift, bit.rshift, bit.rol
-local write, char, unpack = io.write, string.char, unpack
-local N = tonumber(arg and arg[1]) or 100
-local M, buf = 2/N, {}
-write("P4\n", N, " ", N, "\n")
-for y=0,N-1 do
-  local Ci, b, p = y*M-1, -16777216, 0
-  local Ciq = Ci*Ci
-  for x=0,N-1,2 do
-    local Cr, Cr2 = x*M-1.5, (x+1)*M-1.5
-    local Zr, Zi, Zrq, Ziq = Cr, Ci, Cr*Cr, Ciq
-    local Zr2, Zi2, Zrq2, Ziq2 = Cr2, Ci, Cr2*Cr2, Ciq
-    b = rol(b, 2)
-    for i=1,49 do
-      Zi = Zr*Zi*2 + Ci; Zi2 = Zr2*Zi2*2 + Ci
-      Zr = Zrq-Ziq + Cr; Zr2 = Zrq2-Ziq2 + Cr2
-      Ziq = Zi*Zi; Ziq2 = Zi2*Zi2
-      Zrq = Zr*Zr; Zrq2 = Zr2*Zr2
-      if band(b, 2) ~= 0 and Zrq+Ziq > 4.0 then b = band(b, -3) end
-      if band(b, 1) ~= 0 and Zrq2+Ziq2 > 4.0 then b = band(b, -2) end
-      if band(b, 3) == 0 then break end
+
+local bench = require("bench").new(arg)
+
+local N = tonumber(arg and arg[1]) or 5000
+
+local function payload()
+  -- These functions must not be an upvalue but the stack slot.
+  local N = N
+  local bor, band = bit.bor, bit.band
+  local shl, shr, rol = bit.lshift, bit.rshift, bit.rol
+  local write, char, unpack = io.write, string.char, unpack
+
+  local M, buf = 2 / N, {}
+  write("P4\n", N, " ", N, "\n")
+  for y = 0, N - 1 do
+    local Ci, b, p = y * M - 1, -16777216, 0
+    local Ciq = Ci * Ci
+    for x = 0, N - 1, 2 do
+      local Cr, Cr2 = x * M - 1.5, (x + 1) * M - 1.5
+      local Zr, Zi, Zrq, Ziq = Cr, Ci, Cr * Cr, Ciq
+      local Zr2, Zi2, Zrq2, Ziq2 = Cr2, Ci, Cr2 * Cr2, Ciq
+      b = rol(b, 2)
+      for i = 1, 49 do
+        Zi = Zr * Zi * 2 + Ci; Zi2 = Zr2 * Zi2 * 2 + Ci
+        Zr = Zrq - Ziq + Cr; Zr2 = Zrq2 - Ziq2 + Cr2
+        Ziq = Zi * Zi; Ziq2 = Zi2 * Zi2
+        Zrq = Zr * Zr; Zrq2 = Zr2 * Zr2
+        if band(b, 2) ~= 0 and Zrq + Ziq > 4.0 then b = band(b, -3) end
+        if band(b, 1) ~= 0 and Zrq2 + Ziq2 > 4.0 then b = band(b, -2) end
+        if band(b, 3) == 0 then break end
+      end
+      if b >= 0 then p = p + 1; buf[p] = b; b = -16777216; end
     end
-    if b >= 0 then p = p + 1; buf[p] = b; b = -16777216; end
-  end
-  if b ~= -16777216 then
-    if band(N, 1) ~= 0 then b = shr(b, 1) end
-    p = p + 1; buf[p] = shl(b, 8-band(N, 7))
+    if b ~= -16777216 then
+      if band(N, 1) ~= 0 then b = shr(b, 1) end
+      p = p + 1; buf[p] = shl(b, 8 - band(N, 7))
+    end
+    write(char(unpack(buf, 1, p)))
   end
-  write(char(unpack(buf, 1, p)))
 end
+
+local stdout = io.output()
+
+bench:add({
+  name = "mandelbrot_bit",
+  items = N,
+  -- XXX: This is inconvenient to have the binary file in the
+  -- repository for the comparison. If the check is needed, run
+  -- the payload manually.
+  skip_check = true,
+  setup = function()
+    io.output("/dev/null")
+  end,
+  teardown = function()
+    io.output(stdout)
+  end,
+  payload = payload,
+})
+
+bench:run_and_report()
--------------v7IIyFT8ZSnax30hoglWX0Ws--