From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id F09DA158B383; Mon, 17 Nov 2025 16:29:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F09DA158B383 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1763386183; bh=Sw2dB9Y5YWWlrwXb0TYJbj9q6VRMgWwnt+h1ES1ujvQ=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=CMv6tJ+5SjvKEKKD7VbOtBc5HJAhBbvcO/L9qfQ28VHyTssAk+KeU5jg4xIoRrvPz ipFzAiUp9ebGxhhfSHJHt0w7BKUmr0T/1b4MC1Mv2v243VOdy65AdD4I9iFba6seFM lwJ8j+K/z1ErOXLbQt6S7Xj40WNU7ynihQepsFOI= Received: from send264.i.mail.ru (send264.i.mail.ru [95.163.59.103]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 03DEE15DEA83 for ; Mon, 17 Nov 2025 16:26:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 03DEE15DEA83 Received: by exim-smtp-77df68b9cf-k4thg with esmtpa (envelope-from ) id 1vKzFM-00000000Aek-0Ln9; Mon, 17 Nov 2025 16:26:20 +0300 Content-Type: multipart/alternative; boundary="------------v8FNuE5g2MIu0g4J60zXeeXS" Message-ID: Date: Mon, 17 Nov 2025 16:26:19 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <124c286f2d9d6d9b9ce227e6f2b8f25258208987.1761301736.git.skaplun@tarantool.org> In-Reply-To: <124c286f2d9d6d9b9ce227e6f2b8f25258208987.1761301736.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9110BAFCBE6BD1D1603B6524534BC12556475AD05CF589285182A05F53808504012EF19DE7EB7D8F83DE06ABAFEAF67051862B7B3A190461B3C1CBB97E487F8EE18AC86DD68069C2D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7011EB7026DD4A9BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566D0BE23D09F2BEA508B070FB8EA66B39D408A415DC94CB97D84359993BE9C6569389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C224958C1606C78F2434E76E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8B6A4E49BB0F3BA1413AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E7358CCB3ED2A1DE2304C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A538BDFFF1AAE579FA5002B1117B3ED6963CC378F7BC0FD7D2559C6C5561145D6F823CB91A9FED034534781492E4B8EEAD220496FFA5CD4785BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFCB46E8B4A23814C3CB77EA15A727710595CA16BC5207A7DBA8051A6B353689E8C6BFA615E6C3782ADD12B02666E4935699100910B7385844E17169D636A225691BB8A8A756D50014111DC66A97D0BFE2913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVfFX+FmbwDW1TrK63LlOOGA= X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B590C0D586020A467523DE06ABAFEAF67051862B7B3A190461BB7CBEF92542CD7C8795FA72BAB74744FC77752E0C033A69EA16A481184E8BB1C9B38E6EA4F046BE03A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 15/41] perf: adjust md5 in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------v8FNuE5g2MIu0g4J60zXeeXS Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, Sergey, thanks for the patch! See  my comments. Sergey On 10/24/25 13:50, Sergey Kaplun wrote: > This patch adjusts the aforementioned test to use the benchmark > framework introduced before. The default arguments are adjusted > according to the file. The arguments to the script still > can be provided in the command line run. > --- > perf/LuaJIT-benches/md5.lua | 27 ++++++++++++++++++++------- > 1 file changed, 20 insertions(+), 7 deletions(-) > > diff --git a/perf/LuaJIT-benches/md5.lua b/perf/LuaJIT-benches/md5.lua > index fdf6b4a7..5ec67527 100644 > --- a/perf/LuaJIT-benches/md5.lua > +++ b/perf/LuaJIT-benches/md5.lua > @@ -1,5 +1,6 @@ > - > local bit = require("bit") > +local bench = require("bench").new(arg) > + > local tobit, tohex, bnot = bit.tobit or bit.cast, bit.tohex, bit.bnot > local bor, band, bxor = bit.bor, bit.band, bit.bxor > local lshift, rshift, rol, bswap = bit.lshift, bit.rshift, bit.rol, bit.bswap > @@ -147,7 +148,7 @@ assert(md5('ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789') == > assert(md5('12345678901234567890123456789012345678901234567890123456789012345678901234567890') == > '57edf4a22be3c955ac49da2e2107b67a') > > -local N = tonumber(arg and arg[1]) or 10000 > +local N = tonumber(arg and arg[1]) or 20000 this deserves a comment, why 20000 instead 10000? > > -- Credits: William Shakespeare, Romeo and Juliet > local txt = [[Rebellious subjects, enemies to peace, > @@ -176,8 +177,20 @@ Once more, on pain of death, all men depart.]] > txt = txt..txt..txt..txt > txt = txt..txt..txt..txt > > -for i=1,N do > - res = md5(txt) > -end > -assert(res == 'a831e91e0f70eddcb70dc61c6f82f6cd') > - > +bench:add({ > + name = 'md5', > + payload = function() > + local res > + for i=1,N do s/1,/1, / > + res = md5(txt) > + end > + return res > + end, > + checker = function(res) > + assert(res == 'a831e91e0f70eddcb70dc61c6f82f6cd') > + return true > + end, > + items = N, > +}) > + > +bench:run_and_report() --------------v8FNuE5g2MIu0g4J60zXeeXS Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi, Sergey,

thanks for the patch! See  my comments.

Sergey

On 10/24/25 13:50, Sergey Kaplun wrote:
This patch adjusts the aforementioned test to use the benchmark
framework introduced before. The default arguments are adjusted
according to the <PARAM_x86.txt> file. The arguments to the script still
can be provided in the command line run.
---
 perf/LuaJIT-benches/md5.lua | 27 ++++++++++++++++++++-------
 1 file changed, 20 insertions(+), 7 deletions(-)

diff --git a/perf/LuaJIT-benches/md5.lua b/perf/LuaJIT-benches/md5.lua
index fdf6b4a7..5ec67527 100644
--- a/perf/LuaJIT-benches/md5.lua
+++ b/perf/LuaJIT-benches/md5.lua
@@ -1,5 +1,6 @@
-
 local bit = require("bit")
+local bench = require("bench").new(arg)
+
 local tobit, tohex, bnot = bit.tobit or bit.cast, bit.tohex, bit.bnot
 local bor, band, bxor = bit.bor, bit.band, bit.bxor
 local lshift, rshift, rol, bswap = bit.lshift, bit.rshift, bit.rol, bit.bswap
@@ -147,7 +148,7 @@ assert(md5('ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789') ==
 assert(md5('12345678901234567890123456789012345678901234567890123456789012345678901234567890') ==
        '57edf4a22be3c955ac49da2e2107b67a')
 
-local N = tonumber(arg and arg[1]) or 10000
+local N = tonumber(arg and arg[1]) or 20000
this deserves a comment, why 20000 instead 10000? 
 
   -- Credits: William Shakespeare, Romeo and Juliet
 local txt = [[Rebellious subjects, enemies to peace,
@@ -176,8 +177,20 @@ Once more, on pain of death, all men depart.]]
   txt = txt..txt..txt..txt
   txt = txt..txt..txt..txt
 
-for i=1,N do
-  res = md5(txt)
-end
-assert(res == 'a831e91e0f70eddcb70dc61c6f82f6cd')
-
+bench:add({
+  name = 'md5',
+  payload = function()
+    local res
+    for i=1,N do
s/1,/1, / 
+      res = md5(txt)
+    end
+    return res
+  end,
+  checker = function(res)
+    assert(res == 'a831e91e0f70eddcb70dc61c6f82f6cd')
+    return true
+  end,
+  items = N,
+})
+
+bench:run_and_report()
--------------v8FNuE5g2MIu0g4J60zXeeXS--