From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [tarantool-patches] Re: [PATCH 1/4] iproto: rename disconnect cmsg to destroy References: <2168d008e70590a87851bbf602a811d22441b586.1544197465.git.v.shpilevoy@tarantool.org> <20181207173601.GC840@chai> From: Vladislav Shpilevoy Message-ID: Date: Tue, 11 Dec 2018 15:54:57 +0300 MIME-Version: 1.0 In-Reply-To: <20181207173601.GC840@chai> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit To: tarantool-patches@freelists.org, Konstantin Osipov Cc: vdavydov.dev@gmail.com List-ID: On 07/12/2018 20:36, Konstantin Osipov wrote: > * Vladislav Shpilevoy [18/12/07 18:48]: >> Disconnect cmsg is a message that is used by iproto >> thread to notify tx thread that a connection is dead >> and has no outstanding requests. That is its >> tx-related resourses are freed and the connection is >> deleted. >> >> But the text above is clear definition of destroy. The >> patch harmonizes cmsg name and its puprose. >> >> Secondly, the patch is motivated by #3859 which >> requires separate disconnect and destroy phases. >> > > OK to push. > >> Needed for #3859 > Pushed to 2.1 and 1.10.