From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B0A064696C3
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 25 Apr 2020 01:06:27 +0300 (MSK)
References: <cover.1587600640.git.v.shpilevoy@tarantool.org>
 <4a8497baa0ec66ab6c54207121cd62c3f6071fb0.1587600640.git.v.shpilevoy@tarantool.org>
 <20200424122235.GH11314@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <b414acb7-7d30-dc23-b8ea-fe55ec673596@tarantool.org>
Date: Sat, 25 Apr 2020 00:06:25 +0200
MIME-Version: 1.0
In-Reply-To: <20200424122235.GH11314@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v2 1/3] box: introduce port_c
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the review!

>> diff --git a/src/box/port.c b/src/box/port.c
>> index 6e2fe3a6e..2c1fadb5c 100644
>> --- a/src/box/port.c
>> +++ b/src/box/port.c
>> @@ -37,7 +37,18 @@
>>  #include <fiber.h>
>>  #include "errinj.h"
>>  
>> -static struct mempool port_tuple_entry_pool;
>> +/**
>> + * The pools is used both by port_c and port_tuple, since their
> 
> Typo: s/is/are/.

Fixed:

====================
diff --git a/src/box/port.c b/src/box/port.c
index 2c1fadb5c..eabc19ded 100644
--- a/src/box/port.c
+++ b/src/box/port.c
@@ -38,7 +38,7 @@
 #include "errinj.h"
 
 /**
- * The pools is used both by port_c and port_tuple, since their
+ * The pool is used both by port_c and port_tuple, since their
  * entires are almost of the same size. Also port_c can use
  * objects from the pool to store result data in their memory,
  * when it fits.