From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id F3F94440F3F
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  6 Nov 2019 18:08:09 +0300 (MSK)
References: <cover.1572565151.git.v.shpilevoy@tarantool.org>
 <2634a4d09a1fa18147e8837e2738870faa8fd247.1572565151.git.v.shpilevoy@tarantool.org>
 <20191104172614.GE29784@atlas>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <b3c7bebb-951f-6e1a-a76b-98852927097d@tarantool.org>
Date: Wed, 6 Nov 2019 18:14:02 +0300
MIME-Version: 1.0
In-Reply-To: <20191104172614.GE29784@atlas>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 1/3] tuple: move tuple_update into
	xrow_update/ folder
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>, tarantool-patches@dev.tarantool.org

Thanks for the review!

On 04/11/2019 20:26, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/11/01 09:55]:
>> Tuple_update.c already uses xrow_update_ namespace. Soon it will
>> have more files extending this namespace. In order to keep them
>> isolated they are moved to a new subfolder box/xrow_update/.
>>
>> Part of #1261
> 
> I wonder if we still need this patch. Now that everything is prefixed, why not
> keep it in box?
> 
> This is not a standalone library anyway, so I would not create a
> sub-folder for it.
> 
> 

Ok, I kept xrow_update.c and other new files in box folder. See v2 thread.