From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 428D36B962; Wed, 14 Apr 2021 02:22:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 428D36B962 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618356157; bh=ttR+EwKF/8XMx55rhTF/qO/mHoymMI5KvdnHwT/Bntk=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=jsyEWi+UvJvFR9U0iu1GxC/AXOYly+j4ibpHRiCZcFG87bhZibd97yFtnyRFgWgXO HgvkdOnHLgQj/CdaqlA/sSt0QZqlgu9vlEF0aDngkKE/szeumeqdbTcVHHsFf9VRRc S7x4dHt0getJUogZrGnURv+AADLH3pMUhumct3vc= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 777DA6EC5B for ; Wed, 14 Apr 2021 02:22:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 777DA6EC5B Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lWSMd-0003U3-Kb; Wed, 14 Apr 2021 02:22:36 +0300 To: Mergen Imeev References: <3fda2029b186d0cea67ba01269dc3d6e209b3c89.1617984948.git.imeevma@gmail.com> <57dd6994-64f3-7645-f0ec-376751bd0b3e@tarantool.org> <20210413120116.GA95443@tarantool.org> Message-ID: Date: Wed, 14 Apr 2021 01:22:34 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210413120116.GA95443@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480D608FE24BC85426BB1B55F651FED8C70182A05F5380850403C30195F1FD3A4406660EAEDED1E282262E77F1DC3F252B3683056875026D852 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78E8764B5BC580342EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637174E2957C4CE0F938638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B26D5162CDC58A13CF385A3C5CAB6A6B0FA2BB4B7391E66DBBD2E47CDBA5A96583C09775C1D3CA48CFCA5A41EBD8A3A0199FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3ED8438A78DFE0A9E117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BAEB924C2B054B06E75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A524FE6FFEFB13651F9A4C4116852BD895E59A9430154F7395D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C786159FDC4342B043D7AF4FC6ED1BBF6457CF3F5D8A45A934CF4C75320D9D0281D524C643671A381D7E09C32AA3244CAAB42A31EA6FFCD8B9CB433CFBF101885A1673A01BA68E40FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojnA7/qPBUIXFgwJ8/Sheebw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822A8337A9C066D1EA567B191093AFE09613841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v5 01/52] sql: enhance vdbe_decode_msgpack_into_mem() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Good job on the patch! On 13.04.2021 14:01, Mergen Imeev wrote: > Thank you for the review! I'a sorry to ask you so late, but could you look at > new version of the patch? It was decided that this patch should be pushed to > 2.6 and 2.7 along with master. Only this patch of the patch-set. I think the entire patchset must be pushed to all versions. Otherwise you are going to have hard time to cherry-pick anything from the master branch. Additionally, what about sql: rework vdbe_decode_msgpack_into_mem() ? It also fixes a bug. On the branch I see the entire patchset, not just this commit. Is it intended? This commit LGTM.