From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org>, Alexander Turenko <alexander.turenko@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH] test: enable JIT for Lua Fun chain iterator back Date: Sat, 24 Jul 2021 20:24:54 +0300 [thread overview] Message-ID: <b35e2ee11acad491e748e82be20d3eaa02c6d7de.1627145475.git.imun@tarantool.org> (raw) This patch reverts the temporary fix introduced in commit 5fa7ded22c1f6b5ab2ed78563538d234776bac76 ("test: disable JIT for Lua Fun chain iterator") since the issues with invalid traces generation for <fun.chain> iterator are resolved and JIT can be enabled back then. Follows up #4252 Follows up #5118 Signed-off-by: Igor Munkin <imun@tarantool.org> --- Related issues: * https://github.com/tarantool/tarantool/issues/5118 * https://github.com/tarantool/tarantool/issues/4252 * https://github.com/LuaJIT/LuaJIT/issues/584 Branch: https://github.com/tarantool/tarantool/tree/imun/lj-584-bad-renames-for-sunk-values CI: https://github.com/tarantool/tarantool/commit/b35e2ee test/box-tap/key_def.test.lua | 7 ------- 1 file changed, 7 deletions(-) diff --git a/test/box-tap/key_def.test.lua b/test/box-tap/key_def.test.lua index 41eed2191..2ade668a5 100755 --- a/test/box-tap/key_def.test.lua +++ b/test/box-tap/key_def.test.lua @@ -5,13 +5,6 @@ local ffi = require('ffi') local json = require('json') local fun = require('fun') --- XXX fix for gh-4252: to prevent invalid trace assembling (see --- https://github.com/LuaJIT/LuaJIT/issues/584) disable JIT for --- <fun.chain> iterator (i.e. <chain_gen_r1>). Since the function --- is local, the dummy chain generator is created to obtain the --- function GC object. -jit.off(fun.chain({}).gen) - local key_def_lib = require('key_def') local usage_error = 'Bad params, use: key_def.new({' .. -- 2.25.0
next reply other threads:[~2021-07-24 17:48 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-24 17:24 Igor Munkin via Tarantool-patches [this message] 2021-07-26 16:25 ` Alexander Turenko via Tarantool-patches 2021-07-26 17:20 ` Igor Munkin via Tarantool-patches 2021-08-03 18:14 ` Sergey Kaplun via Tarantool-patches 2021-08-03 20:33 ` Igor Munkin via Tarantool-patches 2021-08-04 12:50 ` Vitaliia Ioffe via Tarantool-patches 2021-08-04 15:07 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b35e2ee11acad491e748e82be20d3eaa02c6d7de.1627145475.git.imun@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=imun@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] test: enable JIT for Lua Fun chain iterator back' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox