From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 334A89B0078; Tue, 19 Mar 2024 19:15:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 334A89B0078 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1710864945; bh=Vnqw3dzNTfuvWi5JtDgebGu7M+uBr9NUqfBQ63A9sr8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ncuNmKraCSrcVlNsOX8uUH/J4AMLS4B0Lfy6RXk2xPGyDMJnBFMOc/RlkMeToIFzW KrB1MNiebdyp9l8RM0M3vwUeYRgiDVFcjhFn1HAR0mhcgdOLelLkQxGMhWm/G37rO9 5dsDxsbQ7Zfq1LX0ZdNNbgI5Rq5XkWwbgE34SCe8= Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [95.163.41.100]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A3F319B0078 for ; Tue, 19 Mar 2024 19:15:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A3F319B0078 Received: by smtp63.i.mail.ru with esmtpa (envelope-from ) id 1rmc7q-0000000DEtu-0Lzq; Tue, 19 Mar 2024 19:15:42 +0300 Date: Tue, 19 Mar 2024 19:15:41 +0300 To: Sergey Bronnikov Message-ID: References: <1fe5f0ebbd285bd58849be28548bcc8c8c68c2a1.1710416150.git.sergeyb@tarantool.org> <5fprjxcjy4f4ugliudwqmc5pu4xbv53vdir34hl6gu2vtgjtfe@fqtnkjrf4z4l> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD93B4404EFBC5FECACE5C610B1725ED3C661FD8B55A48E2EE5182A05F5380850404C228DA9ACA6FE272D29D43C361F493CAC8EDD30083ED68EB000DFEE930D974CE03079E786E717A9A1875F26E213F90A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F2393C4755A27B53EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063767500BC4578134A08638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8BCA5837A2D5BF5D5462056D961E90FB2E3196697F2609498CC7F00164DA146DAFE8445B8C89999728AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC81D471462564A2E19F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C67F1C1C3ABB44F3A6E0066C2D8992A164AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3302A61B22DEE7324BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF4964A708C60C975A1DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3BE90F13D913F449135872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5E85732309CB34E5C5002B1117B3ED6969A375C05F68F90A247A99E6294EE8661823CB91A9FED034534781492E4B8EEAD2B25D9E4C92BC8ACBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFF41DFE356CF6CCA194D8BF6C65E118ABBA424FA0F0C7795FA46E06BA16D8316D45CF0F9AF1251E13E1E51F4E63A658348434485DB5A464D0A1A465C85E2546A1A0747DAD774E832DC226CC413062362A913E6812662D5F2A54F6898A6FDCBDC72A617DFBE5FEC2C6383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojipsw8XZ5OuiXRG0vOvksYg== X-Mailru-Sender: 7940E2A4EB16C9976F80DCDCD59EC2278849E61C493161DBAC8EDD30083ED68EB000DFEE930D974CE2527C969975515CFF9FCECFB8D89CB6C77752E0C033A69E235A20A81F3B0E39AB3C5F247CB2F7F93A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] OSX/iOS/ARM64: Fix bytecode embedding in Mach-O object file. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: Sergey Bronnikov , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the fixes! See my answer for the last unresolved comment below. On Tue, Mar 19, 2024 at 11:22:20AM +0300, Sergey Bronnikov wrote: > Max, > > thanks for review. See my comments below. > > Changes force-pushed. > > On 3/18/24 16:44, Maxim Kokryashkin wrote: > > > diff --git a/test/tarantool-tests/lj-865-fix_generation_of_mach-o_object_files.test.lua b/test/tarantool-tests/lj-865-fix_generation_of_mach-o_object_files.test.lua > > > index 0519e134..0a11f163 100644 > > > --- a/test/tarantool-tests/lj-865-fix_generation_of_mach-o_object_files.test.lua > > > +++ b/test/tarantool-tests/lj-865-fix_generation_of_mach-o_object_files.test.lua > > > @@ -7,7 +7,7 @@ local test = tap.test('lj-865-fix_generation_of_mach-o_object_files'):skipcond({ > > > ['Test uses exotic type of loaders (see #9671)'] = _TARANTOOL, > > > }) > > > > > > -test:plan(4) > > > +test:plan(8) > > > > > > -- Test creates an object file in Mach-O format with LuaJIT bytecode > > > -- and checks validness of the object file fields. Typo: s/validness/the validity/ > > > @@ -267,5 +267,7 @@ end > > > > > > -- ARM > > > build_and_check_mach_o(false) > > > +-- ARM64 > > > +build_and_check_mach_o(true) > > These `true/false` should be explained as platform toggle. > > An even better solution would be to pass the platform name > > explicitly. > Why comment above is not sufficient? Comment is sufficient, sure, but why should you opt for a comment, when you can write self-explanatory code instead? > > > test:done(true) > > > -- > > > 2.34.1 > > >