From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E7F79C5B3C2; Thu, 22 Aug 2024 18:07:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E7F79C5B3C2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724339253; bh=q+NEtsR6j/NYefCm13l+2S9PbhK74tdwYKtfV8BZ+Hc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=aX18eGysJzfFufM8Vo0e+UM1qaG/hP18efuv+Hd/QDHeM8hh0s5s/Ba7aNSDA7vkl lsZhAoTntO8ZJtCaG7vL8MtB3/NDOSpY3LPHssIJxbTbjBpFMWThfwYCVTgFrxsF2l e80XVgB/GlobxmIsTARfDzoqRl2l1zCy/yqOL7y8= Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [95.163.41.92]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 66E0AC5B3C2 for ; Thu, 22 Aug 2024 18:07:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 66E0AC5B3C2 Received: by smtp50.i.mail.ru with esmtpa (envelope-from ) id 1sh9PO-00000006toy-1kqK; Thu, 22 Aug 2024 18:07:30 +0300 Content-Type: multipart/alternative; boundary="------------3mORDMZuCX162OK0ENNlIm6u" Message-ID: Date: Thu, 22 Aug 2024 18:07:30 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: <364dac6837a1a1a7247c9cb375a6da8771d3c050.1724228998.git.skaplun@tarantool.org> <7796fd5b-31a0-4d23-979d-a2feeb508478@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9A67092BE052B1D9E8EC46B20539565FBAAD54790EDBD605A182A05F538085040582B8CAB82FE39422EB5D77EF37489D1EA209313F9F2C329EDDFFFF196D306A5C72A02DE8EF075F6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE743AE26858062A689EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063767500BC4578134A08638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D86E2D69F31287082EBFEBE3813967FA29C5E14056039756DBCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F7900637B2737265289038E2D32BA5DBAC0009BE395957E7521B51C2330BD67F2E7D9AF1090A508E0FED6299176DF2183F8FC7C0500AC0B2F9B62304B3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B654CE8ED7C2D004275ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A546A9EEE15C0E4B955002B1117B3ED696D4A6D83945F76A6EAD0703CEB2EF9A27823CB91A9FED034534781492E4B8EEADCAFEFF123806BC82BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34060C3C6DE316ECE41F42B84C7647143C5B4406F5A707033F5B36D8FCC974607B37C039AF6D8979911D7E09C32AA3244CDD370C4A7DCE76FDA0CBE312C330D7D57C3926003B7C9728EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbUwDRTee1Xpi7dmWIh7EXA== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D6140828BA4B0A902BCF7FFBEA10CC7E15C3C60E952EDAEAE1B290152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 15/45] test: enable LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------3mORDMZuCX162OK0ENNlIm6u Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22.08.2024 15:57, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > See my answers below. > > On 22.08.24, Sergey Bronnikov wrote: >> Sergey, >> >> On 21.08.2024 11:58, Sergey Kaplun wrote: >>> This patch moves the aforementioned test from the to the >>> directory (with slightly renaming to be consistent with other names), >>> includes it in , and names the subtests. >>> >>> Part of tarantool/tarantool#9398 >>> --- >> thanks for the patch! Please adjust a width of lines in commit message. > The commit message is already adjusted correct: the maximum width is 72 > symbols (see [1]). Or what do you mean? Seems I forgot a number for max line length in a commit message body :-/ LGTM > >> LGTM >> > > > [1]:https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message > --------------3mORDMZuCX162OK0ENNlIm6u Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit


On 22.08.2024 15:57, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!
See my answers below.

On 22.08.24, Sergey Bronnikov wrote:

Sergey,

On 21.08.2024 11:58, Sergey Kaplun wrote:

This patch moves the aforementioned test from the <misc> to the <lang/>
directory (with slightly renaming to be consistent with other names),
includes it in <index>, and names the subtests.

Part of tarantool/tarantool#9398
---

thanks for the patch! Please adjust a width of lines in commit message.

The commit message is already adjusted correct: the maximum width is 72
symbols (see [1]). Or what do you mean?

Seems I forgot a number for max line length in a commit message body :-/

LGTM



LGTM


<snipped>

[1]: https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message
--------------3mORDMZuCX162OK0ENNlIm6u--