From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9017ED43772; Fri, 1 Nov 2024 15:15:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9017ED43772 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1730463333; bh=BK1zhHfeSsiXhHLZnSteeLW52pjSt9mwE0S/pTA14tc=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=hChEAlgMczZLITA0a93hfspVXOwdcLk97zu7u3hqINnia3HGUXaCJgFDNCjqU+EeM JX/Fdlo3y4NDTzdmUEdyubXNt+EZ8R6rdQbbZ89Hc4kUGZVj+QxnD14U9h2Ix/Dqim lzTHWaLQqZB5MUOXa1TXi87dJdfGp7vxKByU/o8w= Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [95.163.41.89]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D4167425498 for ; Fri, 1 Nov 2024 15:15:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D4167425498 Received: by exim-smtp-6c5957b6dd-jmldq with esmtpa (envelope-from ) id 1t6qYs-0000000053S-3tdD; Fri, 01 Nov 2024 15:15:31 +0300 Content-Type: multipart/alternative; boundary="------------pTgp7JcktAxb8rJuPKTKJVoT" Message-ID: Date: Fri, 1 Nov 2024 15:15:30 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <20241029084258.6881-1-skaplun@tarantool.org> In-Reply-To: <20241029084258.6881-1-skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD92733C19FC6DB0C8B8ECE430B46C9A1DB711ADC2187611A40182A05F538085040360385B2077CD6E83DE06ABAFEAF6705EF67832F5940332E62EBCA49310EAFAF14E64ECD1FAFC5AC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70A10A23A3B64B805EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F91103FA893F53AB8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B2C49EF0B548B04ACEF23E280D582F0A1B74C3590DE35966CC7F00164DA146DAFE8445B8C89999728AA50765F7900637028599BB38096F4F389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8ED96AA85C75E140D117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF4CF1817FC635140EBA3038C0950A5D36C8A9BA7A39EFB766D91E3A1F190DE8FDBA3038C0950A5D36D5E8D9A59859A8B63770467DA350783E76E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7CE435BCE63FB9538743847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5A531E449FF3787605002B1117B3ED6964518A92325599D803E67C18142C611B7823CB91A9FED034534781492E4B8EEAD21D4E6D365FE45D1BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF0704291DE31A57B55B7DACC17EA1B5D9999D305E661FEEBCBC612DFD1C57736FA54F2CFF063EE8C002643FFCD63D2E1868A820A4E342B55BCAD5D0EC963DB33D4347ACE55A0099DC5F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfMbdV4AJnq7u2DBRJhbGug== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D6140F33453033A25A11DD27678DDAA8063145213CE7D50DB10160152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: fix build for macOS Sequoia 15.0 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------pTgp7JcktAxb8rJuPKTKJVoT Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey thanks for the fix, LGTM Sergey On 29.10.2024 11:42, Sergey Kaplun wrote: > When building on > macOS Sequoia 15.0, I've got the following error from including > : > > | error: unknown type name 'caddr_t' > | int ptrace(int _request, pid_t _pid, caddr_t _addr, int _data); > > It can be fixed by including , but since this test is > skipped for macOS anyway, I prefer just to move all necessary includes > under the corresponding define. > --- > > Branch:https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-macos-c-tests > > .../gh-8594-sysprof-ffunc-crash.test.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c b/test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c > index cf1d815a..4067ba1d 100644 > --- a/test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c > +++ b/test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c > @@ -5,12 +5,6 @@ > #include "test.h" > #include "utils.h" > > -#include > -#include > -#include > -#include > -#include > - > /* XXX: Still need normal assert inside and helpers. */ > #undef NDEBUG > #include > @@ -24,6 +18,12 @@ > > #if LUAJIT_OS == LUAJIT_OS_LINUX && LUAJIT_TARGET == LUAJIT_ARCH_X64 > > +#include > +#include > +#include > +#include > +#include > + > /* > * XXX: The test makes sysprof collect the particular event > * (FFUNC) at the particular instruction () to --------------pTgp7JcktAxb8rJuPKTKJVoT Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey

thanks for the fix, LGTM

Sergey

On 29.10.2024 11:42, Sergey Kaplun wrote:
When building <tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c> on
macOS Sequoia 15.0, I've got the following error from including
<sys/ptrace.h>:

| error: unknown type name 'caddr_t'
| int     ptrace(int _request, pid_t _pid, caddr_t _addr, int _data);

It can be fixed by including <sys/types.h>, but since this test is
skipped for macOS anyway, I prefer just to move all necessary includes
under the corresponding define.
---

Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-macos-c-tests

 .../gh-8594-sysprof-ffunc-crash.test.c               | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c b/test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c
index cf1d815a..4067ba1d 100644
--- a/test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c
+++ b/test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c
@@ -5,12 +5,6 @@
 #include "test.h"
 #include "utils.h"
 
-#include <signal.h>
-#include <sys/ptrace.h>
-#include <sys/user.h>
-#include <sys/wait.h>
-#include <unistd.h>
-
 /* XXX: Still need normal assert inside <tracee> and helpers. */
 #undef NDEBUG
 #include <assert.h>
@@ -24,6 +18,12 @@
 
 #if LUAJIT_OS == LUAJIT_OS_LINUX && LUAJIT_TARGET == LUAJIT_ARCH_X64
 
+#include <signal.h>
+#include <sys/ptrace.h>
+#include <sys/user.h>
+#include <sys/wait.h>
+#include <unistd.h>
+
 /*
  * XXX: The test makes sysprof collect the particular event
  * (FFUNC) at the particular instruction (<lj_fff_res1>) to
--------------pTgp7JcktAxb8rJuPKTKJVoT--