From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 48D0C6EC58; Thu, 5 Aug 2021 02:58:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 48D0C6EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628121483; bh=4KZALw49YW4bzNA9H0Xu0FJH1RnFDbn1oeVw+1kihWM=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=PYS8jOV6RIizMFlWW0uTzNoKTizZv0zacqF7easXy6kuZQ0GXZEB+7+G3dka1RZ2A JdLZwlxc5vBGRRw3dMNSn+/VWf76ZoGlCJRmeDMgi3CqVHDRdlRYvQfJBXNZ0ZMxLs 7MFlgpN55Hss5weIPN3R+ZB/WeRoDUo5Mrxai8jI= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6F2596EC58 for ; Thu, 5 Aug 2021 02:58:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6F2596EC58 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1mBQlr-0001WD-Pm; Thu, 05 Aug 2021 02:58:00 +0300 To: Timur Safin References: <50175cbd00c57e3bc8eed222951a551f4bb7effb.1627468002.git.tsafin@tarantool.org> <75730675-e162-887c-3ab3-1c8a8600b27e@tarantool.org> <031c01d78559$13ae90f0$3b0bb2d0$@tarantool.org> <50ff0c18-b5b8-bbff-4cce-53660c39a6ce@tarantool.org> <05c601d78713$199013c0$4cb03b40$@tarantool.org> Message-ID: Date: Thu, 5 Aug 2021 01:57:58 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <05c601d78713$199013c0$4cb03b40$@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C36A98DBA789EBB6AE26DB9A6C1D9BF7E0182A05F538085040630B057770EC27C51C7DA062EB1505FA93C4231A021B7AE076203E2237BCE045 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7EED5D2FAB4CEB1EDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063790C8302959DAAF098638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D88E876ED632B8D56656ECC0F823353434117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B2EE5AD8F952D28FBA471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C468D16C903838CAB43847C11F186F3C59DAA53EE0834AAEE X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B5053B71511467F721745F10A20A90D0CCAE X-C1DE0DAB: 0D63561A33F958A5A766A9A71B547EFA2B253605EFEF0A799138D9E6B2F57A22D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D346C409ABC5F9C579B9E6F0AD791A3C1477B19B9202EADDCF6F5E6CDDAA58AA95141B1617ABDD0EF3E1D7E09C32AA3244C2971C0E0F8AD32CB78C24585047319213E8609A02908F271927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh4v93/7HD3XZ1jNGZQ/tkA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DF862110F84B2CBF5236E5E8CA4A488FB3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH resend v2 02/11] lua: built-in module datetime X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" >>> : > +local datetime_mt = { >>> : > + -- __tostring = datetime_tostring, >>> : >>> : 16. Why is it commented out? Is it even tested then? >>> >>> It's implemented in the later patch in patchset series. >> >> Well, then it should not be here in this commit. >> >>> : > + microseconds = function(self) >>> : > + return tonumber(self.secs*1e6 + self.nsec*1e3) >>> : >>> : 18. Please, add whitespaces around binary operators. >>> >>> Done! It was already such in the later commits which were part >>> of in patchset. [Yes, apparently I need to squash few more commits, >>> as Oleg Babin has asked elsewhere] >> >> It is not just about squashes. It is only about atomicity (and >> as a consequence - review simplicity). You can't just squash all >> the commits into one. You will need to change the older commits >> to make them right, then rebase the newer commits. > > I see. > > BTW, what is the simplest approach here you could recommend? > I mean what tools do you use for shuffling code between version layers? > How to make it simple enough and painless? (I'd love to see training > Here - I know how to do it the harder way in interactive rebase, but > I suspect there are some helpers, which I missed, which allow to > Make it easy way. If any?) My main tools for doing review fixes per-commit are: 'git rebase -i', 'git commit --amend', 'git add -u'. I couldn't find anything easier. These commands take a couple of seconds to print and I doubt there is any tool doing it faster.