From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0E5436EC55; Thu, 26 Aug 2021 23:15:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0E5436EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1630008913; bh=h1VZ2ds4ghYQIj6Dl15CJdAdCamZNMkJOLzUOSWXo1Q=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=b/JPi1LGLhtGkQdakC2NQ4OxpqW2LUP8ooXZHg253Ta2Iqj/3Yi4abaGNkyKqIOtv 67mt/2enwSJPOSOsUyyK20fsbECML4rKGleC/qdUWvQ5V+GuT1qKol3UAdiNN7kRUD hG7fHL2t3cdYtGMAscDwWK1JN9APKS2L3ZsfVoTM= Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 78D5A6EC55 for ; Thu, 26 Aug 2021 23:15:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 78D5A6EC55 Received: by smtp29.i.mail.ru with esmtpa (envelope-from ) id 1mJLmH-0004Yx-NW; Thu, 26 Aug 2021 23:15:10 +0300 To: Vladislav Shpilevoy , imun@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <32b7ac476fec0b675b34d032a61326970491c7cf.1628713520.git.babinoleg@mail.ru> <9bcfb440-ae54-717c-e377-b49f134028f7@tarantool.org> <817688b9-5419-0dea-d92d-74a82a9b8da6@tarantool.org> <52b6cba2-45d4-68ec-d4e1-b9dc2390091b@tarantool.org> Message-ID: Date: Thu, 26 Aug 2021 23:15:09 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <52b6cba2-45d4-68ec-d4e1-b9dc2390091b@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD9BCE6B93DE0C6C3914462CDB1732D383C182A05F53808504006EABD9D0737A42C1E9B42F5BF4268A3E96766274E197B33B50DD0E8E98DD070 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FEAC828D2BF6EC3CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379B0255B5E5688AF88638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D856D648A261B76533E01DCB88AFE310D4117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18F04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEC65AC60A1F0286FE9F804269016115C9D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE39E541A154B51D14B040F9FF01DFDA4A8C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006373BA04B6A498D0BA4731C566533BA786AA5CC5B56E945C8DA X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458F0AFF96BAACF4158235E5A14AD4A4A4625E192CAD1D9E79DB8BF922E402C092C9112520A961668E4 X-C1DE0DAB: 0D63561A33F958A5000567DE7A0B99EDAEAD183293E4FDC9CC7D0D511768AB76D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA756665624D6DDF07B5410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D346EDE9E12965E8CD52B7544FBCB65A158469F5537EC5E38FDE09E5ECF078B72AA2CEB8FFBAE64A68A1D7E09C32AA3244C98194503D5D8CE7CFB1D5B97E8AB7CDFE646F07CC2D4F3D8FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj+bzRAXO2P1Rf7CIXpZVJ+A== X-Mailru-Sender: 583F1D7ACE8F49BD1042885CEC987B6B465D2FF1160ADBC21E9B42F5BF4268A3EFC4EB6826DC22487019711D9D5B048E1458020726E2BC9FD5ECBA0B92C0A936CDC7563AA7CEBD287402F9BA4338D657ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 4/4] fiber: allocate on_stop triggers using mempool X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Oleg Babin via Tarantool-patches Reply-To: Oleg Babin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 26.08.2021 23:01, Vladislav Shpilevoy wrote: > On 26.08.2021 08:14, Oleg Babin via Tarantool-patches wrote: >> Thanks for your review. See my answers below. >> >> On 25.08.2021 23:34, Vladislav Shpilevoy wrote: >>> Thanks for the patch! >>> >>> See 4 comments below. >>> >>> On 11.08.2021 22:33, Oleg Babin via Tarantool-patches wrote: >>>> From: Oleg Babin >>>> >>>> Previously we use malloc for such purpose however we created >>>> on_stop triggers only if fiber storage was touched. Currently we >>>> create on_stop trigger for each lua fiber. So it seems reasonable >>>> to use mempool for such frequent allocations/deallocations. >>> 1. Does it give any perf win? This commit specifically. Seems like an >>> overkill. A trigger allocation might happen only once per fiber's >>> lifetime, and the fiber's creation is supposed to be much longer than >>> the trigger's malloc. The commit probably gives a tiny fraction of >>> percent improvement or does not change anything. Do you have results? >> It's a good question. I thought thank mempool should be faster than malloc. >> >> We can easily drop this commit. I had some doubts about it. > According to the benchmarks it seems the mempool here is slower. > I suggest to drop this commit. No problem. I removed commit from the branch (https://github.com/tarantool/tarantool/commits/olegrok/fiber-ref)