From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B2F607030F; Thu, 25 Feb 2021 01:40:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B2F607030F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1614206455; bh=Ay12aQZEt/ehnMWyqqu+3zpD+JhZWr2NgDgp4zvuQYM=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=SLFzXFqTuimafrEfu2fPxtWQwP7uSLrbu9neRA9FJ2+n1hW8SXkSHXhXF/a+HUtr8 Sc14T1SUC98+kaky68Gnv+JCsAIg5OVXClx2v476kUib48LmztVwhiz6zI7rZBLMRB wfP8m9D5aY7eFK8djyPuSkQAIXxvQthq5zIt1/IQ= Received: from smtp17.mail.ru (smtp17.mail.ru [94.100.176.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AFC177030F for ; Thu, 25 Feb 2021 01:40:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AFC177030F Received: by smtp17.mail.ru with esmtpa (envelope-from ) id 1lF2p8-000572-8v; Thu, 25 Feb 2021 01:40:02 +0300 To: Cyrill Gorcunov , tml References: <20210222182030.76232-1-gorcunov@gmail.com> <20210224153626.121506-1-gorcunov@gmail.com> <20210224153626.121506-6-gorcunov@gmail.com> Message-ID: Date: Wed, 24 Feb 2021 23:40:01 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210224153626.121506-6-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD975C3EC174F5669221340953D8FEAAFCA26BB79E5C093AA91182A05F538085040F5763100AB4CDCD55AD82B5DCDBB4D103C9CBC760C736199879ECB7D3D9EB1E0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE721D130CF676D2164EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375D54B99ECAFA2F678638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CDDE882590F889B1C6DBDA98AD74243975DC8D420AB9922E7A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE77FFCE1C639F4728C9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3FF021744A2531FDDCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C224930841AB6300E6CAB76E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8B6FB967E05F0325173AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE7B2B7C64F398C741067F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C3E2C51E5CF308F7B035872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C9AE7E30DF62CE24E4E5BFE6E7EFDEDCD789D4C264860C145E X-B7AD71C0: 14C14B24D00AF5AC321EF223B8115265C69B993890792DF82CDD5689AFBDA7A24A6D60772A99906F8E1CD14B953EB46D3EB394F1DA8E953A355D89D7DBCDD132 X-C1DE0DAB: 0D63561A33F958A53300E5EB59935CCF9664C36846DE5FA70A4600AA9809E95DD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75968C9853642EB7C3410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F6CC1FD336696336FDBA374197CE89A5285E184064B0BD31B2EEDF5A8E6D1DF41CF25FD4D846F1461D7E09C32AA3244CB9B2F07B9EAC9664A64AD11D40FAD83660759606DA2E136A729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojvz1c9SWJtj9HUl9YL2MPKQ== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA3110D24A992EB6CAD891C66E32A9A9B512E51FDFEC3A616DF3F407784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 05/10] xlog: fix say_x format X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! On 24.02.2021 16:36, Cyrill Gorcunov wrote: > The string length specificator expects length as > integer value. > > Part-of #5846 > > Signed-off-by: Cyrill Gorcunov > --- > src/box/xlog.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/box/xlog.c b/src/box/xlog.c > index 974f460be..40c07abf0 100644 > --- a/src/box/xlog.c > +++ b/src/box/xlog.c > @@ -314,8 +314,8 @@ xlog_meta_parse(struct xlog_meta *meta, const char **data, > /* > * Unknown key > */ > - say_warn("Unknown meta item: `%.*s'", key_end - key, > - key); > + say_warn("Unknown meta item: `%.*s'", The quotes around %s are inconsistent: `' instead of '' or ``. Lets use ''. I know it was there before your patch, but lets fix it anyway, considering it a part of the format. > + (int)(key_end - key), key); > } > } > *data = end + 1; /* skip the last trailing \n of \n\n sequence */ >