From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DB59327570 for ; Wed, 6 Mar 2019 03:23:54 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZAsG1OcwveyU for ; Wed, 6 Mar 2019 03:23:54 -0500 (EST) Received: from smtp5.mail.ru (smtp5.mail.ru [94.100.179.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 975EF27523 for ; Wed, 6 Mar 2019 03:23:54 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH v4] Feature request for a new collation References: <20190305114431.31311-1-szudin@tarantool.org> <20190305154146.GA6860@chai> <35d9a188-03ec-b177-a039-650f15da1fa0@tarantool.org> <20190306081152.GF17432@chai> From: Stanislav Zudin Message-ID: Date: Wed, 6 Mar 2019 11:23:51 +0300 MIME-Version: 1.0 In-Reply-To: <20190306081152.GF17432@chai> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Konstantin Osipov On 06.03.2019 11:11, Konstantin Osipov wrote: > * Stanislav Zudin [19/03/06 10:24]: >> >> >> On 05.03.2019 18:41, Konstantin Osipov wrote: >>> * Stanislav Zudin [19/03/05 14:45]: >>>> /** Maximal length of locale name. */ >>>> enum { >>>> - COLL_LOCALE_LEN_MAX = 16, >>>> + COLL_LOCALE_LEN_MAX = 1024, >>>> }; >>> >>> Why? >>> >> >> Because locale may include numerous options such as collation, numbers, >> calendar etc. e.g.: "fr@collation=phonebook;calendar=islamic-civil". >> The max length is not specified. > > *Nobody* except us can add a new collation. The names of the > collations you added don't exceed 16 bytes. Please keep the old > value. > strlen("de_DE_u_co_phonebk") == 18.