Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
Cc: Sergey Bronnikov <estetus@gmail.com>,
	tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] Prevent sanitizer warning in os.time().
Date: Mon, 9 Nov 2026 13:16:48 +0300	[thread overview]
Message-ID: <avGdkBEz14H6QhPw@root> (raw)
In-Reply-To: <8bba8044-56b4-49a3-94cd-fe427fd34ac1@tarantool.org>

Evgeniy,

On 09.11.26, Evgeniy Temirgaleev via Tarantool-patches wrote:
> Hi, Sergey!
> 
> The patch is LGTM with the report to upstream. You made a great 
> discovery for the problem.
> 
> As the Mike doesn't want to add new runtime exceptions for os.time() in 
> the upstream, we may consider to add the check to our port as they are 
> added in a Lua of higher versions.
> 
> I think, Make may worry about consoles, but this is not our case. But on 
> the other hand, we have a datetime module and may not worry about this 
> error prone os.date() implementation.

I would rather be consistent with the upstream here (just in case).
Moreover, as you said -- for such bogus cases users may choose our
datetime module if they want it.

<snipped>

> --
> Best regards,
> Evgeniy Temirgaleev
> 

-- 
Best regards,
Sergey Kaplun

  reply	other threads:[~2026-11-09 10:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-05 15:18 Sergey Bronnikov via Tarantool-patches
2026-06-06  7:14 ` Sergey Kaplun via Tarantool-patches
2026-06-08 10:59   ` Sergey Bronnikov via Tarantool-patches
2026-06-08 11:03     ` Sergey Kaplun via Tarantool-patches
2026-06-11 11:44 ` Evgeniy Temirgaleev via Tarantool-patches
2026-11-06 10:51   ` Sergey Bronnikov via Tarantool-patches
2026-11-09  2:51     ` Evgeniy Temirgaleev via Tarantool-patches
2026-11-09 10:16       ` Sergey Kaplun via Tarantool-patches [this message]
2026-06-11 11:55 ` Evgeniy Temirgaleev via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avGdkBEz14H6QhPw@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=e.temirgaleev@tarantool.org \
    --cc=estetus@gmail.com \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] Prevent sanitizer warning in os.time().' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox