From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E10F16EC44; Wed, 18 Nov 2026 14:39:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E10F16EC44 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1795001971; bh=YJHeJVw6V9zcAyDOSlLPXrmE+MS4WdZTRNBOfsd8+lU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=E5aZEjGrzLDCavzXAr2eW4Sgkd+DJQ/fyMsg3Y1ensXfXCvpE8nbKJPEdVWe2tDP+ xacD2doE0gyC4m73tNQpOgvQEOHE+JOZzOKCoZ7WwF7+S/avWRoMqTolBEh421413J rpFZlT10+VXb0Hqkxn37BSzGujOgk7Mb4XfxTClM= Received: from send241.i.mail.ru (send241.i.mail.ru [95.163.59.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3C2966EC44 for ; Wed, 18 Nov 2026 14:39:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3C2966EC44 Received: by exim-smtp-5fd8d99545-p2hrf with esmtpa (envelope-from ) id 1xTe0e-00000000G1w-3bEt; Wed, 18 Nov 2026 14:39:29 +0300 Date: Wed, 18 Nov 2026 14:39:05 +0300 To: Evgeniy Temirgaleev Message-ID: References: <20261116120533.2886125-1-skaplun@tarantool.org> <4b6aa5c0-f807-48bd-9c03-5686b7a196c2@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4b6aa5c0-f807-48bd-9c03-5686b7a196c2@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9749DDC91F62168F9B1E3C7B0A01779FCD312991035709691182A05F538085040CF983FDEF96E678E3DE06ABAFEAF6705BEAF220F5C04B758712E0D042D0BBB6B808768E5B14F6D12 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DB6A86BDF2D5A895EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FE9EFE935CD7C6AE8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2C8E7ACB11B0DB4B72E070BE324C7D3C46FE3AE786D2BC8A4F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C05A64D9A1E9CA65708941B15DA834481F9449624AB7ADAF37BA3038C0950A5D36D5E8D9A59859A8B66E72AA9E7D514E7076E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7CC1948A84299AD5C643847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A501092491A6B6745F5002B1117B3ED696B3733409B86189A619AC5B239BAD4335823CB91A9FED034534781492E4B8EEADF5E532225D4D775BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D65976BF66FA4045640DEA171C94CF6E31113F9EA7764F8A397FA61DF5F9B9B9EB1857EF99C4C9695A1DB8341EE9D5BE9A0AC521DF14A49D8BF39799F97CBDFB44D0555B8C29004C66536536EB022892E5344C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXOcIETfglQORZ0zpDET4Zrk3igikrdHlWIJhIMfd+wpIOphDQ8QPJMA= X-Mailru-Sender: 520A125C2F17F0B17094CDC02B85F11B8BAB8B638968B1783DE06ABAFEAF6705BEAF220F5C04B758B7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] ARM64: Don't fuse sign extensions into logical operands. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Evgeniy, On 18.11.26, Evgeniy Temirgaleev wrote: > Hi, Sergey! > > >>> [1]: https://cybersandeep.gitbook.io/arm64basicguide/chapter-3-basic-arm64-instructions#id-3.2.2-logical-instructions > >> The article contains only basic form of arithmetic and logical (and > >> other) instructions. It omits their complex forms with optional second > >> operand shift and/or extension and is not illustrative for this patch. > > > > Yes, I've failed to find the definition of the logical instructions at > > the non-blocked resources :(. At least it has the definition of logical > > instruction... > > Do you think it is better to remove the link to avoid the confusion? > > > I found a working link [1]. You can use it with the document reference > data: "ArmŽ Instruction Set. Version 1.0. Reference Guide" (version 25 > October 2018), "Chapter D2. A64 General Instructions". > > [1] > https://www.heenes.de/ro/material/arm/arm_instruction_set_reference_guide.pdf Thanks! Added to the commit message: | ARM64: Don't fuse sign extensions into logical operands. | | Thanks to Peter Cawley. | | (cherry picked from commit 90742d91c27d185b70d1b4a6343fb6b7c26002db) | | Logical instructions (`orr`, etc.) have no sign extension form (unlike | `ADD Xd, Xn, Wm, SXTW #k`), see Arm Instruction Set [1], Chapter D2: A64 | General Instructions. This makes the fusing sign extension into them | meaningless and leads to the incorrect result in the JIT-compiled code. | | This patch prevents the fusing of sign extension (`sxtw`) into logical | instructions. | | [1]: https://www.heenes.de/ro/material/arm/arm_instruction_set_reference_guide.pdf | | Sergey Kaplun: | * added the description and the test for the problem | | Part of tarantool/tarantool#13442 Branch is force-pushed. > > >> > >>> > >>> Sergey Kaplun: > >>> * added the description and the test for the problem > >>> > >>> Part of tarantool/tarantool#13442 > >>> --- > > > > > > > >> -- > >> Best regards, > >> Evgeniy Temirgaleev > >> > > > > -- > -- > Best regards, > Evgeniy Temirgaleev > -- Best regards, Sergey Kaplun