From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C0C186F817; Wed, 18 Nov 2026 11:31:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C0C186F817 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1794990707; bh=olq25eGpC2LVsUl3dK2Egfnmp/hTIy4wf7fv3RCYXzI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=i6rU1M86ZR4PFOFvMJliDTqOaip5DpMBhaa96bNL3ioBWdivMpk5AewaM3RBhJe7Y +/0z56FqFegzCaRFKvIO0upnYrqKBjk0yNiodkpkzpo9zIhTNMDeIvTkz5llSmaTRK GQWSefyAWXqf3W224xmqxIc6y6a+bUvdXXIvlenM= Received: from send196.i.mail.ru (send196.i.mail.ru [95.163.59.35]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 989226F817 for ; Wed, 18 Nov 2026 11:31:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 989226F817 Received: by exim-smtp-canary-10-775d6dcd67-tngh8 with esmtpa (envelope-from ) id 1xTb4z-0000000080k-0rkT; Wed, 18 Nov 2026 11:31:45 +0300 Date: Wed, 18 Nov 2026 11:31:21 +0300 To: Evgeniy Temirgaleev Message-ID: References: <20261116120533.2886125-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9749DDC91F62168F93153D52FBA18BB599117403A6E84CCF3182A05F53808504000FD63081A29472A3DE06ABAFEAF67055BB17F56C0B842518858F14E89DA70D647030CE06FC90E99 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70CB15FA6C489297DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FE9EFE935CD7C6AE8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2645C17CE749735B22E070BE324C7D3C451B8BAD63EC9818AF6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C05A64D9A1E9CA65708941B15DA834481F9449624AB7ADAF37BA3038C0950A5D36D5E8D9A59859A8B66E72AA9E7D514E7076E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C789C969B8F27C422C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5616BC91724D9331A5002B1117B3ED696A1D9A20F380BE57C484B8D70797403F6823CB91A9FED034534781492E4B8EEADA3FB0D9844EF8EC5BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659FBCA8BB2E3C26983F0F5764931A164105C0F26E8720682E96AFBEC11BFD94D2FB1A702B62DB945B3B8341EE9D5BE9A0A4049FEAD84E22A08AEC556CA64981ABE957495F910C61C0A6536EB022892E5344C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXOcIETfglQORZ0zpDET4Zrk3igikrdHlWLPkns9OOv6Pm5/lFOSIJYM= X-Mailru-Sender: 520A125C2F17F0B17094CDC02B85F11B2B02EB539065184D3DE06ABAFEAF67055BB17F56C0B84251B7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] ARM64: Don't fuse sign extensions into logical operands. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Evgeniy! Thanks for the review! On 17.11.26, Evgeniy Temirgaleev wrote: > Hi, Sergey! Thanks for the patch! LGTM with a note. > > On 11/16/26 3:05 PM, Sergey Kaplun wrote: > > From: Mike Pall > > > > Thanks to Peter Cawley. > > > > (cherry picked from commit 90742d91c27d185b70d1b4a6343fb6b7c26002db) > > > > Logical instructions [1] (`orr`, etc.) have no sign extension form > > (unlike `ADD Xd, Xn, Wm, SXTW #k`). This makes the fusing sign extension > > into them meaningless and leads to the incorrect result in the > > JIT-compiled code. > > > > This patch prevents the fusing of sign extension (`sxtw`) into logical > > instructions. > > > > [1]: https://cybersandeep.gitbook.io/arm64basicguide/chapter-3-basic-arm64-instructions#id-3.2.2-logical-instructions > The article contains only basic form of arithmetic and logical (and > other) instructions. It omits their complex forms with optional second > operand shift and/or extension and is not illustrative for this patch. Yes, I've failed to find the definition of the logical instructions at the non-blocked resources :(. At least it has the definition of logical instruction... Do you think it is better to remove the link to avoid the confusion? > > > > > Sergey Kaplun: > > * added the description and the test for the problem > > > > Part of tarantool/tarantool#13442 > > --- > -- > Best regards, > Evgeniy Temirgaleev > -- Best regards, Sergey Kaplun