From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 24A7C6EC63; Mon, 21 Sep 2026 14:23:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 24A7C6EC63 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1789989810; bh=NbkQmD5yd5QTbwEVnP5UyMpssCLdRwLo0v4SBNxQ9lk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=n7sK5Z7fZZW7qbs4f0iNlzS21vda2HoMWo1Jy9dtwsbcc1ekjmgqiY4V8pisg+JjK 1ym6b3i3U3k+NrniyxPTGuMyKDHglBVuYL7sm6AIs0+N6MQfF8ArSCH24elSWZVfrg LEmcksANO1nwp35UMw8T8+quQe81TADWszRykT2E= Received: from send128.i.mail.ru (send128.i.mail.ru [89.221.237.223]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BC3936EC63 for ; Mon, 21 Sep 2026 14:23:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BC3936EC63 Received: by exim-smtp-686bf5c8c8-9jqk6 with esmtpa (envelope-from ) id 1x8c7L-00000000DGy-259q; Mon, 21 Sep 2026 14:23:27 +0300 Date: Mon, 21 Sep 2026 14:23:07 +0300 To: Mikhail Elhimov Message-ID: References: <630dfb25c6ab76b2d926e53367449404991a6a44.1789476952.git.m.elhimov@vk.team> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <630dfb25c6ab76b2d926e53367449404991a6a44.1789476952.git.m.elhimov@vk.team> X-Mailru-Src: smtp X-4EC0790: 10 X-618D5548: EA0D439AB509F3C0AC8EDD30083ED68E4B6676C2CC21F64B967775957BEE496096EBB56B893B2760 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD964331FA9A592EAE9ADE28128E55DA8ABCF3C5EEDBE88A4E8182A05F5380850406AD4CE8954A7CC5E3DE06ABAFEAF670588AC616ED4E4DE6CA9CB8C9D91E73BC328006A18B89A7667 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE792C68BF9CD4C0E9EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566DEE3629C0BA38EC5D60D6A213B0A6FECE8E8BDA49CF25C51C8AE84B5D8651A46389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C04CF195F1528592878941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6AEEA5BB16A939343CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF17B107DEF921CE791DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C31C94431981024FA535872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A503326A4F60D47FDC5002B1117B3ED696CBC5FB2EEA8230F247A99E6294EE8661823CB91A9FED034534781492E4B8EEADA79578C5CF9A9009BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADB58128AB1E6D661A716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D65978244CE96331DB1A49CD08178C382A4565ABBB55D09DCBAADC61E8AC313874023F8269AF71CA18DEB8341EE9D5BE9A0A62DE1507573C7389D9D1B8B9A1ED52DBE14F58BFE7562C47C7CEAA0681F5848F4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXOcIETfglQORZ0zpDET4Zrk3igikrdHlWJphnJh+MKT9nNR0l9D9uPM= X-Mailru-Sender: 689FA8AB762F73937C9FA53A4753B313D898C0DFE8F589F9D00EA3FA819DB58305149D87D779E7AFE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2 1/2] dbg: fix mapping of FPMATHOP to string X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Mikhail! Thanks for the patch! Please consider my comments below. On 15.09.26, Mikhail Elhimov wrote: > Prior to this patch IRFPMS contained incorrect entry 'exp2'. Typo: s/patch/patch,/ Typo: s/incorrect/the incorrect/ > IRFPMS is a human-readable form of enum IRFPMathOp, but there is no > 'exp2' enum member (see IRFPMDEF(_)). It looks like it was added by > mistake initially. > > Closes tarantool/tarantool#13159 Nit: s/Closes/Resolves/ (since it will be closed after bumping LuaJIT in Tarantool). > --- > src/luajit_dbg.py | 1 - > .../debug-extension-tests.py | 45 ++++++++++++++++++- > 2 files changed, 44 insertions(+), 2 deletions(-) > > diff --git a/src/luajit_dbg.py b/src/luajit_dbg.py > index 80057a4e..76001b7d 100644 > --- a/src/luajit_dbg.py > +++ b/src/luajit_dbg.py > @@ -1722,7 +1722,6 @@ IRFPMS = [ > 'ceil', > 'trunc', > 'sqrt', > - 'exp2', > 'log', > 'log2', > 'other' I suppose it should be fixed via the patch [1]. Avoiding hardcoded enums should fix the issue for enum IRFPMathOp as well. So, I suggest fixing this issue alongside with enum patchset, so we may join all tests to the corresponding patch. > diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py > index 895171a4..32701fd5 100644 > --- a/test/tarantool-debugger-tests/debug-extension-tests.py > +++ b/test/tarantool-debugger-tests/debug-extension-tests.py > @@ -688,6 +688,39 @@ class TestLJIRFloadAbs(TestCaseBase): > ) > > > +class TestLJIRFPMathOpBase(TestCaseBase): > + location = 'lj_cf_print' > + extension_cmds = ( > + 'n\n' # Load L. > + 'lj-trace ' + '&((GG_State *)L)->J->cur' > + ) > + > + @classmethod > + def setUpClass(cls): > + cls.lua_script = ( > + 'jit.opt.start("hotloop=1")\n' > + 'local function trace(a)\n' > + ' local x = {}\n' > + ' return x\n' > + 'end\n' > + 'trace(1)\n' > + 'trace(1)\n' It is better to use 1.1 to test the issue for all architectures (i.e. for arm64 with DUALNUM mode enabled by default). > + 'print()\n' > + ).format(cls.lua_expr) > + cls.pattern = r'num FPMATH .* ref: ' + RX_IRN + r' lit: ' + cls.op > + super(TestLJIRFPMathOpBase, cls).setUpClass() > -- > 2.43.0 > [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2026-September/030791.html -- Best regards, Sergey Kaplun