From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2F1D26ECDB; Mon, 21 Sep 2026 14:14:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2F1D26ECDB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1789989247; bh=mzFm/1HeW3JSZJF3BYquOYTqTn0u/Ogmy2vSNZnL7PQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=LCXWsEGF4E3xP6JLeSWAB0pcJyQr4qgPHhoUyEV4/PjyKM2WbvlIwQBPZSv0pu8nS Kq0PWPS7iWyhHDMFAAWAmpt9dteRLQfeXu2K319icWJjZTTetZz4BAwR7YYMIYLUvT DR+9M5cLHgRbv6z/qBMI5r/F3jI9q60iKgkeZvd0= Received: from send175.i.mail.ru (send175.i.mail.ru [95.163.59.14]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E46226ECDB for ; Mon, 21 Sep 2026 14:14:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E46226ECDB Received: by exim-smtp-686bf5c8c8-jr9vw with esmtpa (envelope-from ) id 1x8byG-000000008Ty-21Qk; Mon, 21 Sep 2026 14:14:05 +0300 Date: Mon, 21 Sep 2026 14:13:44 +0300 To: Mikhail Elhimov Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-618D5548: 77732962CC4235F9C7A4B249DE6549FD2E919F9D085EFDB12C03B6CCC64C525945E5BAFAB0F3A017 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD964331FA9A592EAE996DA3CF3FF5523ECAF9B4A78D53EA388182A05F5380850408E77DF782E04FD893DE06ABAFEAF67051F6BDFA75592144EA9CB8C9D91E73BC33DE74FFC206C9863 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78C6616F30072131EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FE9EFE935CD7C6AE8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2D882E0D4E3DD9DE72E070BE324C7D3C450A49180F8F75319F6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249957A4DEDD2346B42CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0ECC8AC47CD0EDEFF8941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C35E849BEFB94E8FD135872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5F5E0B844386051C65002B1117B3ED696BCD8CA00A0FA6B0292B673A2F5DDD7E7823CB91A9FED034534781492E4B8EEADF5E532225D4D775BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADB58128AB1E6D661A716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659DF0DFF014DAEC18ED410B0190124036B2C3EE81A8ACF01F213D5B494737C68C76ECE71998C82DCB6B8341EE9D5BE9A0A2FCE32D90A5B72A1A185C694A95BC8B750BF2440C36C03F8C7CEAA0681F5848F4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXOcIETfglQORZ0zpDET4Zrk3igikrdHlWOvfPjl/wHOSm5/lFOSIJYM= X-Mailru-Sender: 689FA8AB762F73937C9FA53A4753B3130E675BD27507CD0C208D9C9625F382AA0E544645138B37BBE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2 2/2] test: add debug extension tests for FPMATHOP X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Mikhail! Thanks for the patch! Please consider my comments below. On 15.09.26, Mikhail Elhimov wrote: > These tests extends set of tests that check mapping of FPMATHOP code Typo: s/extends/extend/ Typo: s/set/the set/ Typo: s/mapping/the mapping/ > into a human-readable form while dumping FPMATH IR with the debug > extension. > --- > .../debug-extension-tests.py | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py > index 32701fd5..9989032b 100644 > --- a/test/tarantool-debugger-tests/debug-extension-tests.py > +++ b/test/tarantool-debugger-tests/debug-extension-tests.py > @@ -711,6 +711,25 @@ class TestLJIRFPMathOpBase(TestCaseBase): > super(TestLJIRFPMathOpBase, cls).setUpClass() > > > +@unittest.skipIf(machine in ('arm64', 'aarch64'), > + "not used as there is no corresponding hardware instruction") Instead of skipping the case, it is better to adjust the LJIRFPMathOpBase. The issue with missing IR is due to DUALNUM mode, which coerces the 1 to int, so there is no need to floor or ceil it. If we use 1.1 instead for all FPMMath tests, it fixes the issue. > +class TestLJIRFPMathFloor(TestLJIRFPMathOpBase): > + lua_expr = 'math.floor(a)' > + op = 'floor' > + > + > +@unittest.skipIf(machine in ('arm64', 'aarch64'), > + "not used as there is no corresponding hardware instruction") > +class TestLJIRFPMathCeil(TestLJIRFPMathOpBase): > + lua_expr = 'math.ceil(a)' > + op = 'ceil' > + > + > +class TestLJIRFPMathSqrt(TestLJIRFPMathOpBase): > + lua_expr = 'math.sqrt(a)' > + op = 'sqrt' > + > + > class TestLJIRFPMathLog(TestLJIRFPMathOpBase): > lua_expr = 'math.log(a)' > op = 'log' > -- > 2.43.0 > -- Best regards, Sergey Kaplun