From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 810BE6ECCD; Wed, 19 Aug 2026 10:31:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 810BE6ECCD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1787124689; bh=7Kt6mGUEXfRkoek5ZaTkVxLvt7dqZn85kWj107nwslc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=mlm4WUgkrW0UrcbAy6VXPk0Z9MyNrdHZYXtwnFngZCtoZ6O+ep4Rbroj3Drc6WVxn mFK281BI6+Hq8VhJSVyzaeEVETRo9kr7i1BV5ULZmN/sQAHfAGf37Tc3WrE+/J639H ZjodwTIXxBxsvR8kPzLXqvn8YcYg+6PQ0YDwhVvM= Received: from send197.i.mail.ru (send197.i.mail.ru [95.163.59.36]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 19EB66ECCD for ; Wed, 19 Aug 2026 10:31:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 19EB66ECCD Received: by exim-smtp-67896c5f6-hdksg with esmtpa (envelope-from ) id 1wwali-00000000C5q-3pYE; Wed, 19 Aug 2026 10:31:27 +0300 Date: Wed, 19 Aug 2026 10:30:57 +0300 To: Evgeniy Temirgaleev Message-ID: References: <9d4e2c67dcc3640a917a649cfcd2f19253ddd2f1.1786019520.git.e.temirgaleev@tarantool.org> <1787085325.17934196@f480.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1787085325.17934196@f480.i.mail.ru> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9CA2E9CC3AD529C5089192A8664D2143AEAD469BB6E9DC3301313CFAB8367EF908E2BE116634AD74DB9F1C388FFB48DCF0578E6996F38341327FE003A1A96C63158EF167204F88730B04C393452CF6677 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE723628CE20AC63995EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F88016AB904663428638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2627D084396CEC7172E070BE324C7D3C4F28276A5F49BCF3CF6B57BC7E64490618DEB871D839B73339E8FC8737B5C224936DA1BED736F9328CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C078FCF50C7EAF9C588941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD269176DF2183F8FC7C01AB2475877E8919AD8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3AD74539164518AE5BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7888FFA144A8AE6D0731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5E441D0DBE589C8D95002B1117B3ED6963ADD8E247A6EA22BE772F934B9BCD1853610D81D389A125CDE35189EBF2DEA28FEA14CD2CD220BB99C5DF10A05D560A9880EC71AF561E0AAD9143641EC25BB3900740197D33C5528 X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659FACE747F55A146D5037E0626FE627A142F294F58A8A63BFC46CC659C3294A0B6F226BEE74C505418B8341EE9D5BE9A0A864DDE0685D1001863F1495FB878FF32ACBAFCD7EB8137DB6536EB022892E5344C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVd9Ysz+d4RqWXdOBKYBR4qY= X-Mailru-Sender: 583F1D7ACE8F49BD1E22B6041E04C8AA69D556327FABCC8D125AE33D5AC58CD496C9A2770DE0F9B7F5912C6DE707868FF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v3 2/3] ci: enabled sanitizer tests for macOS X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Evgeniy! Thanks for the answers! LGTM, with minor suggestion below. On 18.08.26, Evgeniy Temirgaleev wrote: > Hi, Sergey! Thanks for review! > > > > > From: Sergey Kaplun > > b/.github/actions/setup-sanitizers-linux/action.yml > > > similarity index 76% > > > rename from .github/actions/setup-sanitizers/action.yml > > > rename to .github/actions/setup-sanitizers-linux/action.yml > > > index 8642d553..18f5a75d 100644 > > > --- a/.github/actions/setup-sanitizers/action.yml > > > +++ b/.github/actions/setup-sanitizers-linux/action.yml > > > @@ -20,13 +20,17 @@ runs: > > > - name: Install build and test dependencies > > > run: | > > > apt -y update > > > + echo Available compilers: > > > + export CC_FAMILY=`echo ${CC_NAME} | sed 's/-.*$//'` > > > + apt list | grep -Pe "^${CC_FAMILY}-[0-9]+/" > > > + # Try to install > > > apt -y install ${CC_NAME} libstdc++-10-dev cmake ninja-build make perl > > > shell: bash > > > env: > > > CC_NAME: ${{ inputs.cc_name }} > > > - - name: Set specific C compiler as a default toolchain > > > + - name: Set specific C compiler as a default toolchain for cmake > > > run: | > > > - echo CC=${CC_NAME} | tee -a $GITHUB_ENV > > > + echo CMAKE_C_COMPILER=${CC_NAME} | tee -a $GITHUB_ENV > > > shell: bash > > > env: > > > CC_NAME: ${{ inputs.cc_name }} > > > > These changes look like debugging of the workflow. Are they necessary? > > > > I think it’s a useful information: Which compiler we can select just now with the current runner? For example, it used to answer your question below. > I added it advisedly, as it done for macOS action. Got it. Please add the comment and the note about it in the commit message to avoid confusion. > > > > > > > > diff --git a/.github/actions/setup-sanitizers-macos/README.md > > b/.github/actions/setup-sanitizers-macos/README.md > > > new file mode 100644 > > > index 00000000..9ac5eb38 > > > --- /dev/null > > > +++ b/.github/actions/setup-sanitizers-macos/README.md > > > > > > > > > diff --git a/.github/actions/setup-sanitizers-macos/action.yml > > b/.github/actions/setup-sanitizers-macos/action.yml > > > new file mode 100644 > > > index 00000000..9836ea03 > > > --- /dev/null > > > +++ b/.github/actions/setup-sanitizers-macos/action.yml > > > @@ -0,0 +1,73 @@ > > > > > > > > > + - name: Set CMAKE_BUILD_PARALLEL_LEVEL > > > + shell: bash > > > + run: | > > > + # Set CMAKE_BUILD_PARALLEL_LEVEL environment variable to > > > + # limit the number of parallel jobs for build/test step. > > > + NPROC=$(sysctl -n hw.logicalcpu 2>/dev/null) > > > + echo CMAKE_BUILD_PARALLEL_LEVEL=$(($NPROC + 1)) | tee -a $GITHUB_ENV > > > + - name: Set MACOSX_DEPLOYMENT_TARGERT > > > + shell: bash > > > + run: | > > > + # Set required MACOSX_DEPLOYMENT_TARGERT environment > > > + # variable for Makefile.original build. > > > + # See https://github.com/LuaJIT/LuaJIT/issues/484, > > > + # https://github.com/LuaJIT/LuaJIT/issues/653. > > > + echo MACOSX_DEPLOYMENT_TARGET=$(sw_vers -productVersion) | tee -a > > $GITHUB_ENV > > > + - name: Install build and test dependencies > > > + shell: bash > > > + run: | > > > + # Install brew using the command from Homebrew repository > > > + # instructions: https://github.com/Homebrew/install. > > > + # XXX: 'echo' command below is required since brew > > > + # installation script obliges the one to enter a newline > > > + # for confirming the installation via Ruby script. > > > + brew update || > > > + echo | /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install > > )" > > > + # Try to install the packages either upgrade it to avoid > > > + # of fails if the package already exists with the previous > > > + # version. > > > + brew install --force ${CC_FORMULA} cmake make ninja perl || > > > + brew upgrade ${CC_FORMULA} cmake make ninja perl > > > > Can we reuse setup-macos action instead these 3 steps? > > > > Yes, we can do it on top of the «ci: unused gcc removed from macOS setup» patch. > So, we need to merge it first. Do we? Don't understand why it is required. The gcc instalation and upgrade looks harmless, IINM. >  And then I shall update this patch. > Thanks for the notice. > > > > > > > > > > > > diff --git a/.github/workflows/sanitizers-testing.yml > > b/.github/workflows/sanitizers-testing.yml > > > index 4bf7d023..fe550b81 100644 > > > --- a/.github/workflows/sanitizers-testing.yml > > > +++ b/.github/workflows/sanitizers-testing.yml > > > > > > > > > > > + exclude: > > > > > > > > > + - OS: Linux > > > + CC: gcc-15 > > > + - OS: Linux > > > + CC: clang-21 > > > > May we bump gcc and clang instead for Linux as well (I suppose its > > about time :)) ? > > > > I suppose it helps to avoid too many excludes. Also, there is no need > > for testing these specific compilers instead of modern ones in > > sanitizers build. > > > > If there are any issues when upgrading compilers for sanitizer builds > > (infrastructure or tests failures) -- feel free to ignore. > > > > > > > > I tried to use the top versions available for macOS and for Linux. We can’t use the same versions with our current setup. > > With the macOS runner we have: > Available formulas: ... gcc gcc@10 gcc@11 gcc@12 gcc@13 gcc@14 gcc@15 gcc@9 … > Available formulas: ... llvm llvm@14 llvm@15 llvm@16 llvm@17 llvm@18 llvm@19 llvm@20 llvm@21 ... > > With the Linux runner we have: > > gcc-10/focal-updates,now 10.5.0-1ubuntu1~20.04 amd64 [installed] > gcc-7/focal 7.5.0-6ubuntu2 amd64 > gcc-8/focal 8.4.0-3ubuntu2 amd64 > gcc-9/focal-updates,now 9.4.0-1ubuntu1~20.04.2 amd64 [installed,automatic] > > clang-10/focal,now 1:10.0.0-4ubuntu1 amd64 [installed,automatic] > clang-11/focal-updates,now 1:11.0.0-2~ubuntu20.04.1 amd64 [installed] > clang-12/focal-updates 1:12.0.0-3ubuntu1~20.04.5 amd64 > clang-18/focal-updates 1:18.1.8-11~20.04.2 amd64 > clang-7/focal 1:7.0.1-12 amd64 > clang-8/focal 1:8.0.1-9 amd64 > clang-9/focal 1:9.0.1-12 amd64 > > The clang18 have broken dependencies with the current version of setup-sanitizers-linux. So I leave the current version in the context of ‘fix sanitizers for macOS patch’. Ignore then. Thanks for the explanation! > > > > > > > > > > -- > > > 2.49.0 > > > > > > > -- > > Best regards, > > Sergey Kaplun > > > > Best regards, > Evgeniy Temirgaleev -- Best regards, Sergey Kaplun