From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7B2BB6E231; Fri, 24 Jul 2026 14:03:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7B2BB6E231 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1784891007; bh=pmxbtPxUDqxe8A33O2oHR/XdZUHrrGH9FvG1g86ZUpw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=eiAcuJ3hpQVvCQTVmqARo43Ev0keV38QN5lUsvqr0NDD8U49roSLJZ3IH5fSITPnP x1xfsbK10jqK9R4sy02RWYvq8LCa/+ki8w98vKwmwnBgpbs9hSDus/53KCKlUV9SXl uq1ZByEsK5Hh+CTenm4FZjXgEKOokw0UpBkbgTZI= Received: from send80.i.mail.ru (send80.i.mail.ru [89.221.237.175]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4E1E66E231 for ; Fri, 24 Jul 2026 14:03:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4E1E66E231 Received: by exim-smtp-6c76488b9f-2c262 with esmtpa (envelope-from ) id 1wnDgb-00000000OcN-21Sv; Fri, 24 Jul 2026 14:03:25 +0300 Date: Fri, 24 Jul 2026 14:03:11 +0300 To: Sergey Bronnikov Message-ID: References: <103733d5267298d59381cca0401fee35100ac63b.1784642965.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD93ED3C6BF6FFA701F2A3CBCFBD5D1DC05D05B05CDA37BE5EB182A05F53808504035C9F00F33A58D9E3DE06ABAFEAF6705359917BAEDFFC35BD23F41F3E1D90402697DF1A24495553A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B264C8851FD8E810EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566DDF253B6BCADDB792D2746B9EEA0CAFC77879C12FFFA0A33A555CAC5DF6A88B0389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A3E989B1926288338941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B636DA1BED736F9328CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7F669735A3130CE6243847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A586F34D6236A4D33B5002B1117B3ED69624D4233139C3E276CA7E60A991436CA2823CB91A9FED034534781492E4B8EEAD887A4342A344B6EDBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D65996425F129CECA4DD46C71A4387AA7BD886FAE56D031DDFEEE749B213C412C28E82325DD85AF5E3C2B8341EE9D5BE9A0A468229CC9675D9A69FB960EA3A8C35F4DC72C9DB91EBB3596536EB022892E5344C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVWmxowtcrDwUUpEj6ogvw8A= X-DA7885C5: 8B1C8850C971F6A6F255D290C0D534F94EED95657C54FCC4B9140218202961234EFC4930DBB5C6555B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE2040B799E0568BE2015F2216166BFD6EA6E5270F0FC19E3B8E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] ARM: Make hard-float tobit conversions match JIT backend behavior. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment and force-pushed the branch. On 24.07.26, Sergey Bronnikov wrote: > Hello, > > thanks for the patch! LGTM with a minor comment > > Sergey > > On 7/21/26 17:53, Sergey Kaplun wrote: > > From: Mike Pall > > > > Reported by Peter Cawley. > > > > (cherry picked from commit 32a683d226a3b57adbfeabff17d1ae0f7676545d) > > > > On the arm architecture, the `tobit()` function incorrectly truncates > s/arm/ARM/ Fixed, thanks. > > instead of rounding to the nearest integer. This leads to inconsistency > > between various VMs (comparing to x86/x64, for example) and between the > > arm VM and JIT. > > > > This patch uses an addition of 2^52 + 2^51 constant to the given > > argument to convert it to the nearest integer value. After reading the > > lowest 32 bits of the register, we get the expected result. > > > > The test is the same as for the previous commit. > > > > Sergey Kaplun: > > * added the description for the problem > > > > Part of tarantool/tarantool#12880 > > --- -- Best regards, Sergey Kaplun