From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D23656E21D; Fri, 24 Jul 2026 14:00:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D23656E21D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1784890810; bh=CeQDh6yu8zzcTLehU4y8RO3HZLIzz8S73poDnnDzZgY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=AZU8MYC4oB0UEhAKizuv7nhaonMJpIcFASkXZk+mtKDmzv3sncD76TpYf1NuNk5DI AWTgzaN8k2jH9Hlbhv7VVjIR9bKEStriPSiNS7Gbqu5eRC5S/RGlIeIsv6EF8zpVTj X9HHMyVYh+OmqyiQ6bGltHZSBKvEDAT8+abVvrqo= Received: from send219.i.mail.ru (send219.i.mail.ru [95.163.59.58]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AD3326E21D for ; Fri, 24 Jul 2026 14:00:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AD3326E21D Received: by exim-smtp-6c76488b9f-29dz6 with esmtpa (envelope-from ) id 1wnDdQ-000000000kn-2tfK; Fri, 24 Jul 2026 14:00:09 +0300 Date: Fri, 24 Jul 2026 13:59:54 +0300 To: Sergey Bronnikov Message-ID: References: <0a098bc2-ddb1-4fca-afdf-2a91cc80f7b9@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a098bc2-ddb1-4fca-afdf-2a91cc80f7b9@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD93ED3C6BF6FFA701FBF353A30C2EA510A8006DDB73367F39B182A05F538085040232558A494E8A48B3DE06ABAFEAF670546B1650D15DBA44FF4D87ACBDB865BE261CD1C36FF7CC69F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE727FD6E7FC3A8F857EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566DDF253B6BCADDB79CF473261ACBCE9E9D8A1FFCBD0A7639962B5AAB700862DE7389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A29E2F051442AF778941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6D52CD31C43BF465FCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE788761406820A3098731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5F325E855C37394515002B1117B3ED69696A5EE043D67BA4CAD0703CEB2EF9A27823CB91A9FED034534781492E4B8EEADF7ED4D6813B5CA04BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6592D4E4CA0E6352620353B82F2CD753912300A588B7B82D1CF4C2892F0CB2149F57EFEA6EE47F51523B8341EE9D5BE9A0AC31B4A66219B3E183900E2A1BEDEE96B64CF418DAAE02E5F6536EB022892E5344C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVWmxowtcrDwUZqxDSPhWx8Q= X-DA7885C5: 05E46AE17976DEEDF255D290C0D534F9497CF67B42EBC956B94E71C4386588D96FC177C1C702CAEB5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE2173A4644F2393FD0D36B9BE6547C58BB7E8D11BE290F4051E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] ARM64: Make tobit conversions match JIT backend behavior. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment and force-pushed the branch. On 24.07.26, Sergey Bronnikov wrote: > Hello, > > thanks for the patch! LGTM with a minor comment. > > Sergey > > On 7/21/26 17:53, Sergey Kaplun wrote: > > From: Mike Pall > > > > Thanks to Peter Cawley. > > > > (cherry picked from commit cdc2db3aeac442e139c3b1fda715fdfa78da8791) > > > > On the aarch64 architecture, the `tobit()` function incorrectly > > truncates instead of rounding to the nearest integer. This leads to > > inconsistency between various VMs (comparing to x86/x64, for example) > > and between the arm64 VM and JIT. > > > > This patch uses an addition of 2^52 + 2^51 constant to the given > > argument to convert it to the nearest integer value. After reading the > > lowest 32 bits of the register, we get the expected result. > > > > Sergey Kaplun: > > * added the description and the test for the problem > > > > Part of tarantool/tarantool#12880 > > --- > > src/vm_arm64.dasc | 20 ++++--------- > > .../lj-1253-tobit-conversion.test.lua | 28 +++++++++++++++++++ > > 2 files changed, 34 insertions(+), 14 deletions(-) > > create mode 100644 test/tarantool-tests/lj-1253-tobit-conversion.test.lua > > > > diff --git a/test/tarantool-tests/lj-1253-tobit-conversion.test.lua b/test/tarantool-tests/lj-1253-tobit-conversion.test.lua > > new file mode 100644 > > index 00000000..31cf97ca > > --- /dev/null > > +++ b/test/tarantool-tests/lj-1253-tobit-conversion.test.lua > > @@ -0,0 +1,28 @@ > > +local tap = require('tap') > > + > > +-- Test file to demonstrate LuaJIT's incorrect bit.tobit > > We usually add parentheses to the name of the function. Here and below. > > Feel free to ignore. Fixed, thanks: =================================================================== diff --git a/test/tarantool-tests/lj-1253-tobit-conversion.test.lua b/test/tarantool-tests/lj-1253-tobit-conversion.test.lua index 31cf97ca..2fd16cc4 100644 --- a/test/tarantool-tests/lj-1253-tobit-conversion.test.lua +++ b/test/tarantool-tests/lj-1253-tobit-conversion.test.lua @@ -1,6 +1,6 @@ local tap = require('tap') --- Test file to demonstrate LuaJIT's incorrect bit.tobit +-- Test file to demonstrate LuaJIT's incorrect `bit.tobit()` -- behaviour for arm64. -- See also: https://github.com/LuaJIT/LuaJIT/issues/1253. =================================================================== -- Best regards, Sergey Kaplun