From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C313D6F152; Wed, 1 Jul 2026 11:26:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C313D6F152 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1782894385; bh=Me11dWJoYIyTUCmZ/95YaZIlWDflG7fIhcp93SEcaKs=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=BmnwmZkfi1Zjl2iK99ltok1AsQSUFQBQA89VP0GQrzMWrwIwYrfMVs76Nw9QbIC7G /UWxQfbYYLDVaL2wWvD9iY8VhcB/wiPfQVydUrIo+5wykEH3HDRo9/TXZWbS0ZXL/v CSvSujrTRDMZdh7wWNqm+yeZUzhe3UC5dXVLLR00= Received: from send36.i.mail.ru (send36.i.mail.ru [89.221.237.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1DEAD6F152 for ; Wed, 1 Jul 2026 11:26:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1DEAD6F152 Received: by exim-smtp-78b8b8c574-m6h4j with esmtpa (envelope-from ) id 1weqH1-00000000Kp1-1B3s; Wed, 01 Jul 2026 11:26:23 +0300 Date: Wed, 1 Jul 2026 11:25:44 +0300 To: Sergey Bronnikov , tarantool-patches@dev.tarantool.org Message-ID: References: <20260625202903.3157425-1-skaplun@tarantool.org> <20260625202903.3157425-3-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9C332F781D648AA6A13043D6158A22237671177B309E9BFC7182A05F538085040BE1F20421816A2C13DE06ABAFEAF6705D3CF51A1C8E22C10BE5E86B87CCA1D5D56AF9A33750679FD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE757AEC41D7AA04458EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB553375667C07923B88CEC0EDA9AF7F6D945EC7CBE264BC94ACD75C96B86F9CDE49D00E05389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A29E2F051442AF778941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B601F8F2FECC0250C8CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249EDF998CB16CCEE6976E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8B7FE970921847EE7F3AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735D2D576BCF940C736C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5E43C75082053E95F5002B1117B3ED696923559E8F98902E7B91D2EB2DEE3878C823CB91A9FED034534781492E4B8EEAD69BF13FED57427F1BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE191716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659859053784340F2940E3616656692D18CF6E2713D19401B3D05E370D7FD5E24E587693A146D4AE997B8341EE9D5BE9A0AEF4E29018DE08D786D42656BA249E84C422B7AB3732F6F508CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVRSZSJkMhZtML1gvKMxqf7E= X-Mailru-Sender: 520A125C2F17F0B17094CDC02B85F11B82A5CC9B81DD85843DE06ABAFEAF6705D3CF51A1C8E22C10B7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/3] dbg: introduce lj-ctype command, extend cdata dump X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, On 30.06.26, Sergey Kaplun via Tarantool-patches wrote: > Hi, Sergey, > > Thanks for the review! > See my answers below. > > On 30.06.26, Sergey Bronnikov wrote: > > Hi, Sergey, > > > > thanks for the patch! LGTM with minor comments. > > > > Sergey > > > > On 6/25/26 23:29, Sergey Kaplun wrote: > > > > > > > > > > > + > > > + > > > +def ctype_repr(cts, id): > > > + ctype = ctype_get(cts, id) > > > + ctypestr = '' > > > + qual = 0 > > > + ptrto = 0 > > > + while True: > > > > probably it should be somehow limited, with broken memory/coredump > > > > the loop may be an infinite > > The infinite loop here means the infinite ctypes chain, so it means > infinite memory. I suppose this is not a possible case. > And maybe that ctype_child() returns the same class. > I don't want to add an artificial limit for it. After some considerations I've removed the unreachable code (since the loop has no break statement): =================================================================== diff --git a/src/luajit_dbg.py b/src/luajit_dbg.py index b1a7182b..80057a4e 100644 --- a/src/luajit_dbg.py +++ b/src/luajit_dbg.py @@ -2585,7 +2585,6 @@ def ctype_repr(cts, id): ctypestr = '(' + ctypestr + ')' ctypestr += '()' ctype = ctype_child(cts, ctype) - return 'NYI' def dump_ctype(ct): =================================================================== > -- > Best regards, > Sergey Kaplun -- Best regards, Sergey Kaplun