From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7043A6F3EA; Tue, 30 Jun 2026 18:04:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7043A6F3EA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1782831873; bh=qgiRQjNV+DAxA9wgBK89fy2ELQ4f++mZ2AYImL5VGBE=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=HnL2qTWzmdMgn9nwgFok72HsWw+DWCrazRKiY7SozamB0M4P3hHDjB7Pi5s9ynKmL 0ot7qIVP8lp3QcgkB9rfMKNWk9CKd1E6xte8HBxgurOrfc/xMDiEFHTt2iYRWf8vKX od044jdRasNaiNbIwlWnCaSdkvt7MSWnJuZD37A4= Received: from send150.i.mail.ru (send150.i.mail.ru [89.221.237.245]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B74A56F3EA for ; Tue, 30 Jun 2026 18:04:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B74A56F3EA Received: by exim-smtp-78b8b8c574-zgjmv with esmtpa (envelope-from ) id 1wea0l-000000007GL-3Goe; Tue, 30 Jun 2026 18:04:32 +0300 Date: Tue, 30 Jun 2026 18:03:52 +0300 To: Sergey Bronnikov Message-ID: References: <20260625202903.3157425-1-skaplun@tarantool.org> <20260625202903.3157425-3-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9F802F6E87846D5F6A38A879D392E11EF9B4E72684B24B13500894C459B0CD1B9A859D62EBB4E608591417EB218679B82C09006CF33492EFBA878A37EE71A7ECA1D371A049BD054D4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7705F446BE41E38A1EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB553375667C07923B88CEC0EDCDA6626258DC701D6A30331DF5D965D64B8797CB79CFA1B2389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A29E2F051442AF778941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B65FF0BFC5AEE34BE6CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE74ABCC139FF3F849B731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A547B0405133C32FB95002B1117B3ED69657758B73423003EF14DB8790748E3E77823CB91A9FED034534781492E4B8EEAD2B25D9E4C92BC8ACBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659E2FCF1D9A31D5771C202517DCC3E8EF2B1BE2E377FC1122B0071EF9D709FCDA2546063B960799943B8341EE9D5BE9A0A40DAC1DF22DBF19DC5B33FFBEB88F2A3CF2584C61E73F8E06536EB022892E5344C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVRSZSJkMhZtMrYpW+zOS8uo= X-DA7885C5: F45C1C457978FF1DF255D290C0D534F98B7936ED6FE1E4A22AC9EC365CA285419D8E1368F8203AF95B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE2CCC6BF40B429B56486BE29053B56602813A69BA12BB81B08E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/3] dbg: introduce lj-ctype command, extend cdata dump X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey, Thanks for the review! See my answers below. On 30.06.26, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! LGTM with minor comments. > > Sergey > > On 6/25/26 23:29, Sergey Kaplun wrote: > > > > > > + > > + > > +def ctype_repr(cts, id): > > + ctype = ctype_get(cts, id) > > + ctypestr = '' > > + qual = 0 > > + ptrto = 0 > > + while True: > > probably it should be somehow limited, with broken memory/coredump > > the loop may be an infinite The infinite loop here means the infinite ctypes chain, so it means infinite memory. I suppose this is not a possible case. And maybe that ctype_child() returns the same class. I don't want to add an artificial limit for it. > > > > test_cls.test = lambda self: self.check() > > -- Best regards, Sergey Kaplun