From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] Make check in os.time() consistent.
Date: Tue, 30 Jun 2026 13:08:41 +0300 [thread overview]
Message-ID: <akOVqcq6EeJ-BBpy@root> (raw)
In-Reply-To: <31cfd9c3c72af4708b03b0ea98ca8a4e913b4599.1782588899.git.e.temirgaleev@tarantool.org>
Hi, Evgeniy!
Thanks for the patch!
LGTM, with a few nits regarding the commit message.
On 29.06.26, Evgeniy Temirgaleev wrote:
> From: Mike Pall <mike>
>
> Thanks to Temir Galeev. #1470
Please strip the issue number here. See the rationale in the response to
the previous patch.
>
> (cherry picked from commit 295d45fb26de56498782c94594f31b97aef744ef)
>
> This patch prevents os.time() to return nil, when machine time is -1
Typo: s/to return nil/from returning nil/
> and some error occurs before os.time() call. In fact, this is
Typo: s/os.time() call/the os.time() call/
> a theoretical case, so no tests were added.
>
> Temir Galeev:
> * added the description for the patch
>
> Part of tarantool/tarantool#12480
> ---
<snipped>
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2026-06-30 10:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 17:16 [Tarantool-patches] [PATCH luajit 0/2] Fix os.time() to use errno to detect errors Evgeniy Temirgaleev via Tarantool-patches
2026-06-29 17:21 ` [Tarantool-patches] [PATCH luajit 1/2] Fix corner case of os.time() Evgeniy Temirgaleev via Tarantool-patches
2026-06-30 10:05 ` Sergey Kaplun via Tarantool-patches
2026-06-30 13:53 ` Evgeniy Temirgaleev via Tarantool-patches
2026-06-30 14:18 ` Sergey Bronnikov via Tarantool-patches
2026-06-29 17:21 ` [Tarantool-patches] [PATCH luajit 2/2] Make check in os.time() consistent Evgeniy Temirgaleev via Tarantool-patches
2026-06-30 10:08 ` Sergey Kaplun via Tarantool-patches [this message]
2026-06-30 13:57 ` Evgeniy Temirgaleev via Tarantool-patches
2026-06-30 14:20 ` Sergey Bronnikov via Tarantool-patches
2026-06-30 14:55 ` [Tarantool-patches] [PATCH luajit 0/2] Fix os.time() to use errno to detect errors Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akOVqcq6EeJ-BBpy@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=e.temirgaleev@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 2/2] Make check in os.time() consistent.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox