From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E182D6ECD0; Sun, 28 Jun 2026 18:20:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E182D6ECD0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1782660024; bh=ubRI8zbt/JxYAN/bduStu9ISQCEP/MDIegcMqLoP9uo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=kTCvSpLwjvaBMo2ovw+hyY/Drzu+xNCoraT6XmQfKYN/xCQGm2Tvqxq8BZ+RgtkJv 1QV35fuC0N86XULdpzdTjZXW9ahKn8M8yiDBBcduVyCFEmRwFfgQB5Mb57GgKxxtzw BZxtEMIuET2Syl/59kjbdgZ5GXW5CZ4MfxjD5FCw= Received: from send82.i.mail.ru (send82.i.mail.ru [89.221.237.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 55C4A6ECD0 for ; Sun, 28 Jun 2026 18:20:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 55C4A6ECD0 Received: by exim-smtp-78b8b8c574-8s9pl with esmtpa (envelope-from ) id 1wdrIz-000000008CZ-0fnJ; Sun, 28 Jun 2026 18:20:21 +0300 Date: Sun, 28 Jun 2026 18:19:42 +0300 To: Evgeniy Temirgaleev Message-ID: References: <20260625202903.3157425-1-skaplun@tarantool.org> <20260625202903.3157425-4-skaplun@tarantool.org> <1782610278.163228035@f762.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1782610278.163228035@f762.i.mail.ru> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD918D6BB028DF8CB61B1CEC85D1BD5B1A63B41DC0B9949CD63182A05F5380850403A9AC5A7A24759E83DE06ABAFEAF67054E76F7442695563BF296A22520662C48E1A8BE7F7F452477 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F2393C4755A27B53EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F88016AB904663428638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B27DFB6B0695D8F9882E070BE324C7D3C4107AED3D6E7C9A69F6B57BC7E64490618DEB871D839B73339E8FC8737B5C22495FF0BFC5AEE34BE6CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0DCF4F0DC832992758941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3C74813BC7F81EC8435872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A50499545D742C00445002B1117B3ED6961408D0275E841BA072305013E4AE841E823CB91A9FED034534781492E4B8EEADF5E532225D4D775BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE191716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659D649C0EBFDF90699C362DC32933A6F4678CDF90AA5497F6C06E9F8235B9E14F0C2116F4D29796561B8341EE9D5BE9A0A71D0B206743BE6CC05D8439B09F6DFF00A26AADFB0B4AD596536EB022892E5344C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVRSZSJkMhZtMcDIbm34rtNg= X-DA7885C5: 657432DA72CECB5AF255D290C0D534F9653A080071C04379DF8A4AE3DB0FD149888299FC9CA26F0F5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE27D6193A93AC93638DFCFCBF85DAB5C3F610CB8524D3940AAE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] test: add verbose mode for debug extension tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Evgeniy! Thanks for the review! Fixed your comments and force-pushed the branch. On 28.06.26, Evgeniy Temirgaleev wrote: > Hi, Sergey! > > Thanks for the patch! > > LGTM after fixing the comments. > > -- > Best regards, > Evgeniy Temirgaleev > > > > > От кого: Sergey Kaplun > > Кому: Sergey Bronnikov , Evgeniy Temirgaleev > > > > Копия: tarantool-patches@dev.tarantool.org, Sergey Kaplun > > > > Дата: Четверг, 25 июня 2026, 23:29 +03:00 > > If the environment variable `DUBUGGER_TEST_VERBOSE` is set, each test Updated the commit message: | test: add verbose mode for debug extension tests | | If the environment variable `DEBUGGER_TEST_VERBOSE` is set, each test | prints the generated command and its output and doesn't delete the files | generated for it. > > prints the generated command and its output and doesn't delete the files > > generated for it. > > --- > > test/tarantool-debugger-tests/debug-extension-tests.py | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py > > b/test/tarantool-debugger-tests/debug-extension-tests.py > > index fc5d2c7b..adb83e1e 100644 > > --- a/test/tarantool-debugger-tests/debug-extension-tests.py > > +++ b/test/tarantool-debugger-tests/debug-extension-tests.py > > @@ -43,6 +43,8 @@ else: > > # Don't run any initialization scripts. > > RUN_CMD_FILE = ['--batch', '--nx', '--quiet', '--command'] > > > > +TEST_VERBOSE = os.getenv('DUBUGGER_TEST_VERBOSE', default=False) > > > > Typo: /DU/DE/ Fixed, thanks! =================================================================== diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py index adb83e1e..9bf375d5 100644 --- a/test/tarantool-debugger-tests/debug-extension-tests.py +++ b/test/tarantool-debugger-tests/debug-extension-tests.py @@ -43,7 +43,7 @@ else: # Don't run any initialization scripts. RUN_CMD_FILE = ['--batch', '--nx', '--quiet', '--command'] -TEST_VERBOSE = os.getenv('DUBUGGER_TEST_VERBOSE', default=False) +TEST_VERBOSE = os.getenv('DEBUGGER_TEST_VERBOSE', default=False) RX_ADDR = r'0x[a-f0-9]+' RX_HASH = RX_ADDR # The same pattern for hexademic values. =================================================================== > > > > > + > > RX_ADDR = r'0x[a-f0-9]+' > > RX_HASH = RX_ADDR # The same pattern for hexademic values. > > RX_BCN = r'00\d\d' > > @@ -52,7 +54,7 @@ RX_IRREF = r'0x\d\d\d\d' > > > > > > def persist(data): > > - tmp = tempfile.NamedTemporaryFile(mode='w') > > + tmp = tempfile.NamedTemporaryFile(mode='w', delete=not TEST_VERBOSE) > > tmp.write(data) > > tmp.flush() > > return tmp > > @@ -149,7 +151,12 @@ class TestCaseBase(unittest.TestCase): > > LUAJIT_BINARY, > > script_file.name, > > ] > > + if TEST_VERBOSE: > > + print('# Test name: {}'.format(cls.__name__)) > > + print('# Test command: {}'.format(' '.join(process_cmd))) > > cls.output = execute_process(process_cmd) > > + if TEST_VERBOSE: > > + print('# Command output: {}'.format(cls.output)) > > > > Please, append a new line before command (multiline) output. Added: =================================================================== diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py index 9bf375d5..8e069fe0 100644 --- a/test/tarantool-debugger-tests/debug-extension-tests.py +++ b/test/tarantool-debugger-tests/debug-extension-tests.py @@ -156,7 +156,7 @@ class TestCaseBase(unittest.TestCase): print('# Test command: {}'.format(' '.join(process_cmd))) cls.output = execute_process(process_cmd) if TEST_VERBOSE: - print('# Command output: {}'.format(cls.output)) + print('# Command output:\n{}'.format(cls.output)) cmd_file.close() script_file.close() =================================================================== > > > > > cmd_file.close() > > script_file.close() > > > > -- > > 2.54.0 > > -- Best regards, Sergey Kaplun