From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A77016ECCC; Tue, 9 Jun 2026 21:00:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A77016ECCC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1781028046; bh=brVCUKPjGgL4LnWgd7kfi7yHoJeJjLsdeHZdBtZh2og=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=yGnTujvjXCXHqACfUXquJ2bh42oLKujlZgFdokjqQwy3I8eApAKzEQvAmAimt53bS yhaElZvabc2M5SNGdZOuBZTNsnp9rsL0TLUcb+s55njjB0gEzFQP69N2QiOTQc+byu eA4YfMQQkhc0jTm9iLfKoMGnMdBbOqgx/tek4mLU= Received: from send83.i.mail.ru (send83.i.mail.ru [89.221.237.178]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C14996ECCC for ; Tue, 9 Jun 2026 21:00:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C14996ECCC Received: by exim-smtp-5bf699dc9d-zk252 with esmtpa (envelope-from ) id 1wX0km-00000000GUD-30sJ; Tue, 09 Jun 2026 21:00:45 +0300 Date: Tue, 9 Jun 2026 21:00:10 +0300 To: Sergey Bronnikov Message-ID: References: <20260608102318.4068317-1-skaplun@tarantool.org> <4b4838ea-4ada-4bf5-8e20-8083133139df@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4b4838ea-4ada-4bf5-8e20-8083133139df@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9E926CE86FFF978D751657253326F751F151139DFC37F30C5182A05F538085040264E425DC1EB276B3DE06ABAFEAF6705E9DDA4A9D191329885832B5DE258D85871C70EC916F3F42B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7811C3E343B302E2EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371D5B197C6EC5B4BE8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B294694102A67A2CA22E070BE324C7D3C4F2F4BDFB3BCFABF7F6B57BC7E64490618DEB871D839B73339E8FC8737B5C224936DA1BED736F9328CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C091DAD9F922AA71188941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C369456C5265B6C55C35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5ED4A95E42E4A65D85002B1117B3ED6964F678139C5E0476572305013E4AE841E823CB91A9FED034534781492E4B8EEAD0942DC5495D0595EBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE191716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659D513EA14A23200C1AF2CF0B7C83F699016591755C8DF27AC1AEB96FD940FD067F0D4552FA17D40A9B8341EE9D5BE9A0AA58C107A053DD868451301AAFDFA9F57A2BF1C2249C4B1046536EB022892E5344C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVfwaKBAd4IJXiJU2SbkCBMA= X-DA7885C5: 59BB260BB4E89DEFF255D290C0D534F904B67942AAE7E9B393617C267FB2458C449983CDDCE279195B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE2E2700F09BEBA7B6BDBF5AFD75E834209178029D4208F89ECE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: fix libfficcall compilation for old GCC X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the review! Fixed your comment and force-pushed the branch. On 09.06.26, Sergey Bronnikov wrote: > Hello, Sergey, > > Thanks for the patch! LGTM with a minor comment. > > Sergey > > On 6/8/26 13:23, Sergey Kaplun wrote: > > On CentOS 7 GCC has no std=c99 by default. This leads to compilation > > warnings and errors for ‘for’ loop initial declarations. This patch > > fixes that by declaring the variable out of the loop body. > > --- > > > > Branch:https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-tests-old-gcc > > CI failure:https://github.com/tarantool/luajit/actions/runs/27124968515/job/80063067169#step:6:10593 > > > > test/tarantool-tests/ffi-ccall/libfficcall.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/test/tarantool-tests/ffi-ccall/libfficcall.c b/test/tarantool-tests/ffi-ccall/libfficcall.c > > index 2145b556..129bc75d 100644 > > --- a/test/tarantool-tests/ffi-ccall/libfficcall.c > > +++ b/test/tarantool-tests/ffi-ccall/libfficcall.c > > @@ -307,7 +307,8 @@ int test_2_large_agg_a16(int x, large_agg_a16 s1, large_agg_a16 s2) > > const int *v1 = s1.v; > > const int *v2 = s2.v; > > int sum = x; > > - for (int i = 0; i < lengthof(s1.v); i++) { > > + int i = 0; > > + for (; i < lengthof(s1.v); i++) { > > isn't better declaring outside the loop and define in a loop? > > int i; > for (i = 0; i < lengthof(s1.v); i++) { > > It looks more familiar this way. Feel free to ignore. Fixed: =================================================================== diff --git a/test/tarantool-tests/ffi-ccall/libfficcall.c b/test/tarantool-tests/ffi-ccall/libfficcall.c index 129bc75d..85d76436 100644 --- a/test/tarantool-tests/ffi-ccall/libfficcall.c +++ b/test/tarantool-tests/ffi-ccall/libfficcall.c @@ -307,8 +307,8 @@ int test_2_large_agg_a16(int x, large_agg_a16 s1, large_agg_a16 s2) const int *v1 = s1.v; const int *v2 = s2.v; int sum = x; - int i = 0; - for (; i < lengthof(s1.v); i++) { + int i; + for (i = 0; i < lengthof(s1.v); i++) { sum += v1[i] + v2[i]; } return sum; =================================================================== > > > sum += v1[i] + v2[i]; > > } > > return sum; -- Best regards, Sergey Kaplun