From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id F2FA46F152; Fri, 5 Jun 2026 19:02:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F2FA46F152 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1780675348; bh=ccS5MQm2tpij3zmqG5Gv44N4hJ0pWJ/5f6N5MQ0kgMg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=VhX36PPggfcix1U5pggqDGlPxSAh0km30KMpLiwemBrk/90JD+8x2BJiz/B/rJJoz 1cAomNXnLxukTeINSpSIXRO0aruQUYQQQ04TbEemt0yk81AkwYdO2JjDL5b36vJHH9 r7AbyxAbJwPuoBh9UDeQ6DL/YuOUEzp+6/TE8DKo= Received: from send240.i.mail.ru (send240.i.mail.ru [95.163.59.79]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 56AFA6F152 for ; Fri, 5 Jun 2026 19:02:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 56AFA6F152 Received: by exim-smtp-85dd497b6-x2q7x with esmtpa (envelope-from ) id 1wVX05-000000001zt-0Kbt; Fri, 05 Jun 2026 19:02:25 +0300 Date: Fri, 5 Jun 2026 19:01:50 +0300 To: Sergey Bronnikov Message-ID: References: <20260604093052.2221827-1-skaplun@tarantool.org> <20260604093052.2221827-3-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9FAD06046D747065B921E6FDF7B76E156BAB5350688E7AB84182A05F5380850409518D07B81394E8F3DE06ABAFEAF67050052FF6175C6C54F338E2C7946E3C338FC108E89ABB85EB9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE745229D52CF30560CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB5533756660A56BB7F6F20B60D30A51CFD083170928F0A6285BF717AF8D3917747C8251F9389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A3E989B1926288338941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B652D31B9D28593E51CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7D151390FFDBF6399731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A58398EF43228F22CF5002B1117B3ED696471A1A2DBDC8E66A19AC5B239BAD4335823CB91A9FED034534781492E4B8EEAD887A4342A344B6EDBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6590148446508776F88C1A1DC4B0F0EEC92D9ACE7517D40089AC792B106D18FD64E19DA4517E7D10FACB8341EE9D5BE9A0A4C8DA66F241B5293FD9A21C1D6052859CEBD23A5C2B525236536EB022892E5344C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVRI2994ruhLU8Rn8viTeHr0= X-DA7885C5: 214EDC9ABBA4788AF255D290C0D534F95E53DD746D915B82231FA1F6DE696481A72C988DE75FE58F5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE2535D18D89ADE96086035C0182742BC2EE11030EBC507907BE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/4] dbg: fix DUALNUM detection for LLDB X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Added the separate commit as you suggested. Branch is force-pushed. On 05.06.26, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! LGTM with a minor comment below. > > Sergey > > On 6/4/26 12:30, Sergey Kaplun wrote: > > The `lj-arch` command on LLDB reports 'LJ_DUALNUM: True' for the > > single-number build since the `module.FindSymbol()` returns an invalid > > `SBSymbol` object [1], which is not `None`. This leads to invalid > > DUALNUM mode detection. > > > > This patch fixes this by checking that the returned symbol is valid. > > > > [1]:https://lldb.llvm.org/python_api/lldb.SBModule.html#lldb.SBModule.FindSymbol > > --- > > src/luajit_dbg.py | 3 ++- > > .../debug-extension-tests.py | 15 +++++++++++++-- > > 2 files changed, 15 insertions(+), 3 deletions(-) > > > > diff --git a/src/luajit_dbg.py b/src/luajit_dbg.py > > index 410f0191..300d65e9 100644 > > --- a/src/luajit_dbg.py > > +++ b/src/luajit_dbg.py > > I believe DUALNUM should be added to the help for `lj-arch`. Now it > describes only LJ_64, LJ_GC64: I've added the separate commit for it. I'll send the patch in the reply to the main thread. =================================================================== dbg: update help for the lj-arch command This patch adds the description of the LJ_DUALNUM dumped flag to the lj-arch command's help. diff --git a/src/luajit_dbg.py b/src/luajit_dbg.py index 60308179..3a3ca9b8 100644 --- a/src/luajit_dbg.py +++ b/src/luajit_dbg.py @@ -1461,7 +1461,8 @@ lj-arch The command requires no args and dumps values of LJ_64 and LJ_GC64 compile-time flags. These values define the sizes of host and GC -pointers, respectively. +pointers, respectively. Also, it dumps the value for the LJ_DUALNUM +compile-time flag to inspect if LuaJIT is built in dual-number mode. ''' def execute(self, arg): =================================================================== -- Best regards, Sergey Kaplun