From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 86A536EFFA; Fri, 5 Jun 2026 18:47:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 86A536EFFA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1780674472; bh=BE+G7joc/4wwgIcpTWICrTQcgp8+6Wernh+TuXQAVl4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=v1bgnSF7d0SBq3r0BCmoIyDwCZWOqysdSxywc7KRoIfa9l02XkwnR7xWB6k2Qvv23 lMI1J9Q8w81sPJ0fnqEPfmrVZy8GW9td9vHDxSrZCCDgI+peMozSBzkrayT1/bvCFb VS+ImhIBwigkuLrXx27hp1SfSB4evVb4duwyAbgY= Received: from send196.i.mail.ru (send196.i.mail.ru [95.163.59.35]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 88D136EFFA for ; Fri, 5 Jun 2026 18:47:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 88D136EFFA Received: by exim-smtp-85dd497b6-xd96g with esmtpa (envelope-from ) id 1wVWly-00000000IEi-2Ilg; Fri, 05 Jun 2026 18:47:50 +0300 Date: Fri, 5 Jun 2026 18:47:15 +0300 To: Sergey Bronnikov Message-ID: References: <20260605124909.2709341-1-skaplun@tarantool.org> <580f113a-a176-4b57-a81a-4bcf105f6876@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <580f113a-a176-4b57-a81a-4bcf105f6876@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9FAD06046D747065BBF816D40BB268C394B27FCF4C446E11A182A05F538085040350B6F4423886F4B3DE06ABAFEAF6705DB378D4D7E1C3F2E9B1AD5D121A9929FA3FFAFA2033DE9A6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72E2D36A15E1833D8EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB5533756660A56BB7F6F20B60920E25AC666E2598DA069835B0735D45197E5547DF9859BE389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE732FCE54C4D9A645443847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A50A3801BF948CC5285002B1117B3ED69635B049D714943282466072E6821086B3823CB91A9FED034534781492E4B8EEADFCE5E68AF59B345DBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659DEBE1105DD527F37C08E9601B27E5128DC9C86192E8718A478784EA74EA22D386B909E00CD186774B8341EE9D5BE9A0A51D733981ACC16D8FB17E9D2AD9E5FA3C7E0DCF17BFE82906536EB022892E5344C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVRI2994ruhLUR/wBCgeV/cg= X-DA7885C5: 748136B64E0C4026F255D290C0D534F90FDB67F471670C77D3B6A47261191306E7BC4FF80F2747FC5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE20A515CA60020244049D6CEF9948134091D39499B2E49E41EE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/1] x86/x64: Change ipairs_aux to match JIT backend behavior. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment and force-pushed the branch. On 05.06.26, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! LGTM with a minor comment(s). > > Sergey > > On 6/5/26 15:49, Sergey Kaplun wrote: > > From: Mike Pall > > > > Thanks to Sergey Kaplun. > > > > (cherry picked from commit 64b1f10835acc18bf8923adf248dce4894867882) > > > > In the single-number VM, `ipairs_aux()` first adds the 1 to the given > > number and only after casts it to an integer. This leads to results > > different from Vanilla Lua 5.1 and inconsistent with JIT engine > > s/Vanilla/PUC Rio/ > > feel free to ignore Rephrasing as you suggested. The new commit message is the following: | x86/x64: Change ipairs_aux to match JIT backend behavior. | | Thanks to Sergey Kaplun. | | (cherry picked from commit 64b1f10835acc18bf8923adf248dce4894867882) | | In the single-number VM, `ipairs_aux()` first adds the 1 to the given | number and only after casts it to an integer. This leads to results | different from PUC Rio Lua 5.1 and inconsistent with JIT engine | recording. | | This patch fixes it by casting the value to an integer before addition. | | Sergey Kaplun: | * added the description and the test for the problem | | Part of tarantool/tarantool#12480 > > > recording. > > > > This patch fixes it by casting the value to an integer before addition. > > > > Sergey Kaplun: > > * added the description and the test for the problem > > > > Part of tarantool/tarantool#12480 > > --- > > > > Branch:https://github.com/tarantool/luajit/tree/skaplun/lj-1463-ipairs-aux-consistency > > Related issues: > > *https://github.com/LuaJIT/LuaJIT/issues/1463 > > *https://github.com/tarantool/tarantool/issues/12480 > > -- Best regards, Sergey Kaplun