From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 616416F15A; Fri, 5 Jun 2026 19:11:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 616416F15A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1780675870; bh=/P3A+ZJ5+MxngoPcWN9/iAw9InxAsBKri3GepYGJ+RU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=jWvBSsfAjWXFeHl35bRFV6TisnNEUe477tLXWbo/V41zzpX3Xurg7X1J42xa6CoMq ElU22RB7yG8z3MNRMaQ9NIkwJXSLtpgRPXrR397CaaDghi3JwvjthhcSFuQL7AckoX hmJBgNt2u2VsoFrlAz4A+4qwG5WiVLX8jwPqkuCk= Received: from send83.i.mail.ru (send83.i.mail.ru [89.221.237.178]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DA4726F15A for ; Fri, 5 Jun 2026 19:11:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DA4726F15A Received: by exim-smtp-85dd497b6-fmjc9 with esmtpa (envelope-from ) id 1wVX8V-000000004SF-4A77; Fri, 05 Jun 2026 19:11:08 +0300 Date: Fri, 5 Jun 2026 19:10:33 +0300 To: Sergey Bronnikov Message-ID: References: <20260604093052.2221827-1-skaplun@tarantool.org> <20260604093052.2221827-5-skaplun@tarantool.org> <74ca0f6d-1db0-4e62-a4c0-e19986d31c34@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <74ca0f6d-1db0-4e62-a4c0-e19986d31c34@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9FAD06046D747065BEB96030766291D485387FB17E9EB4AB0182A05F538085040B40390F9266B3B573DE06ABAFEAF6705B5E882687ABBC87B338E2C7946E3C338D8331305C3D564B6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72E4E5201E1C2E308EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FE9EFE935CD7C6AE8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2518A12EF8D4CBB212E070BE324C7D3C43574711958C465E9F6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249D082881546D93491CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C369456C5265B6C55C35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A51FE238F44366268D5002B1117B3ED696030AB8FB3A0FC7DFC66B2B37046EC955823CB91A9FED034534781492E4B8EEADEEA082C9A12FE455BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659DAA47852020859CC3BC30163F0582103CD969F0483111866471820C4ED3BA92A4908BA2898BB81A1B8341EE9D5BE9A0A85B497AA520C7BCC9981F45CE16A8B7179847FB8FCAD550B6536EB022892E5344C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVRI2994ruhLUA3mEi2RiYhI= X-DA7885C5: 6994F2A1B5713E8CF255D290C0D534F929B127C76EEF627CE6784793C01F79CF0CA005ECEB946ED35B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE24A53EE801897FA31879B4D507418146BB76019FA55C4753CE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 4/4] dbg: introduce lj-bc, lj-func and lj-proto dumpers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! See my answer below. On 05.06.26, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! LGTM with a minor comment. > > Sergey > > On 6/4/26 12:30, Sergey Kaplun wrote: > > > > > > + > > + > > +def bcmode_cd(op): > > + return int((lj_bc_mode()[op] >> 7) & 15) > > + > > + > > +# Unfortunately, there is no place in the VM except the generated > > +# Lua table, where the bytecode names are stored. So duplicate > > +# them here. > > +BYTECODES = [ > > + # Comparison ops. ORDER OPR. > "ORDER OPR" - what does it mean? Here and below. Same as in bc.h: order of operators. See lj_parse.c for details. > > + 'ISLT', > > + 'ISGE', > > + 'ISLE', > > > -- Best regards, Sergey Kaplun