From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9AE676EC40; Wed, 27 May 2026 15:55:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9AE676EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1779886542; bh=0FDqOfzKIK+emSO09khPjkHtFNmNFm1zPRKHdLI5FME=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ya4E+eHS3Ck5vCLHGy0TsIOBcwN8/DccW8TWAGx9hFVpzcHN2MwUrbfUfryLh5+3x L4vnmrxOdGHsIJ78rf+lkxNAyv5QLSeqKluusITx7ayJMPoUnYHMN5tw1sa085JfAB hE2IyeXaxA4hrcDluBklbGvpyoPu0Bk26OX+rw6Q= Received: from send36.i.mail.ru (send36.i.mail.ru [89.221.237.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 534996EC40 for ; Wed, 27 May 2026 15:55:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 534996EC40 Received: by exim-smtp-5b85998476-4nd8m with esmtpa (envelope-from ) id 1wSDnQ-0000000069q-25vL; Wed, 27 May 2026 15:55:40 +0300 Date: Wed, 27 May 2026 15:55:05 +0300 To: Sergey Bronnikov Message-ID: References: <20260519123913.178775-1-skaplun@tarantool.org> <20260519123913.178775-6-skaplun@tarantool.org> <2f29ca87-ac11-4459-8717-b62f077afdfa@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2f29ca87-ac11-4459-8717-b62f077afdfa@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD98DC58EE55F2C5C37F9BF2A20B8ECB71E83C6BA91EF89B50C00894C459B0CD1B9F35C99FF69E503FA2EB5D77EF37489D18F6B7145BAC75B881AD63227CCE4B52D4DF7BC4678047644 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72F22E6DC541F75D9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB553375660B0E8CC26A25383E4B84C66C9174DE74EB4F729EC812259CBF8324F9A6C925B9389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0ECC8AC47CD0EDEFF8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6F459A8243F1D1D44CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22499635D254FADD292C76E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8BFF30D8ED0A2C5AD03AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E7351D6A3D1828C12CDEC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5E9EEF72D9C27BD9B5002B1117B3ED69611CD366139F52C51A9DAB4B68AE4D22F823CB91A9FED034534781492E4B8EEAD887A4342A344B6EDBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADB58128AB1E6D661A8E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659F7E3645839B55D1C3C6AB2EF942A6BFF7D40E25AF9AE50BE6E875B306FBE40A40CFE1110FF2A5520B8341EE9D5BE9A0AC3F50DEA0AD3A3D073FBA2A41D116BCD34F0D4904C4FE01BC7CEAA0681F5848F4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVax5M0mESuWmrGCcFOl7aLA= X-Mailru-Sender: 520A125C2F17F0B17094CDC02B85F11B7BD4869D8DE99F483DE06ABAFEAF67058ECD99915FA6F569B7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 5/6] dbg: generalize extension X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment and force-pushed the branch. On 27.05.26, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! LGTM with a minor comment. > > Sergey > > On 5/19/26 15:39, Sergey Kaplun wrote: > > This patch joins the LLDB and GDB LuaJIT debugging extensions > > into one, so now the extension logic can be debugger-agnostic. > > > > To do that, an adapter class is introduced, and all of the > > debugger-specific behavior is encapsulated there and in its child > > debugger classes with the specific implementations of required methods. > > The extension auto-detects the debugger it was loaded into and selects > > the correct low-level logic implementation. > > > > The F821 ignore is removed from <.flake8rc> since there is no more need > > for it. > > --- > > .flake8rc | 5 - > > src/luajit-gdb.py | 884 ------------ > > src/luajit_dbg.py | 1281 +++++++++++++++++ > > src/luajit_lldb.py | 1015 ------------- > > .../debug-extension-tests.py | 4 +- > > 5 files changed, 1283 insertions(+), 1906 deletions(-) > > delete mode 100644 src/luajit-gdb.py > > create mode 100644 src/luajit_dbg.py > > "autopep8 -i" generates the following patch: > > --- a/src/luajit_dbg.py > +++ b/src/luajit_dbg.py > @@ -651,7 +651,7 @@ def frame_ftsz(framelink): > >  def frame_pc(framelink): >      return dbg.cast('BCIns *', frame_ftsz(framelink)) if LJ_FR2 \ > -                    else mref('BCIns *', framelink['fr']['tp']['pcr']) > +        else mref('BCIns *', framelink['fr']['tp']['pcr']) > > >  def frame_prevl(framelink): > > Feel free to ignore, but I propose following PEP8 style from the beginning. This is weird, since flake8 checks PEP8 compliance as well, and it didn't warn about it. Fixed, thanks! =================================================================== diff --git a/src/luajit_dbg.py b/src/luajit_dbg.py index 164f0955..d9196f06 100644 --- a/src/luajit_dbg.py +++ b/src/luajit_dbg.py @@ -651,7 +651,7 @@ def frame_ftsz(framelink): def frame_pc(framelink): return dbg.cast('BCIns *', frame_ftsz(framelink)) if LJ_FR2 \ - else mref('BCIns *', framelink['fr']['tp']['pcr']) + else mref('BCIns *', framelink['fr']['tp']['pcr']) def frame_prevl(framelink): =================================================================== > > delete mode 100644 src/luajit_lldb.py > > [1]: https://peps.python.org/pep-0008/#indentation -- Best regards, Sergey Kaplun