From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DC92A6ECCC; Wed, 27 May 2026 13:53:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DC92A6ECCC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1779879182; bh=rNEgfUiU5u2wuev55wE7/nXoIfBMor1nCasHVugu3ao=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=MyZXltIsLs/ruoqIPGoXpZNz2hBTpUw6PuUmSoM9EpburL6L/jcQDHg3X0S8Vt3r7 tzuOnGUdCQZc5VSUNesvTKtT+XcdB1CL3wlzkgXO2IDw3hAFv5nNLFzbpl+zRXq+qi Ke8xNZJI03so8QjuTofTaKGKQVChSEj0IPD5duVQ= Received: from send106.i.mail.ru (send106.i.mail.ru [89.221.237.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1CDC06ECCC for ; Wed, 27 May 2026 13:53:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1CDC06ECCC Received: by exim-smtp-5b85998476-kbmmh with esmtpa (envelope-from ) id 1wSBsh-0000000090y-3aLI; Wed, 27 May 2026 13:53:00 +0300 Date: Wed, 27 May 2026 13:52:25 +0300 To: Sergey Bronnikov Message-ID: References: <20260519123913.178775-1-skaplun@tarantool.org> <20260519123913.178775-2-skaplun@tarantool.org> <3703735e-192b-4e3f-8842-2cff7a61e725@tarantool.org> <2cb77f7b-40f1-4e97-8f8f-31a7dfedc167@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2cb77f7b-40f1-4e97-8f8f-31a7dfedc167@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD98DC58EE55F2C5C37F2EAA28FCF576926E1762A7534D1987100894C459B0CD1B9BBA08C89178044045D1BE6A8D71B10A588EF186695397C32F9CAFAC521C6B5E92890F9C47E136152 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7195F30236A8D43B4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB553375660B0E8CC26A25383E9E6475279EBC243B15E9A8BCCA5C2FA90B73D99803DE5191389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B64854413538E1713FCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22496126586F7E381E2E76E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8BA7E986E6EB348C303AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735156CCFE7AF13BCA4B5C8C57E37DE458BEDA766A37F9254B7 X-B7AD71C0: BCAA75B3C340DBBEEF3A853C90EA8D50F01536074D6990B7EE9D5CB6078CC77C0CE3B379971168AB135824B3FEAB4495 X-C1DE0DAB: 0D63561A33F958A58C756FA6DCB5E57D5002B1117B3ED696881058AEF8E2BA80A13BD6A4B0E00B96823CB91A9FED034534781492E4B8EEAD5E90D3DD2A5B7EAFBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADB58128AB1E6D661A716CD42B3DD1D34C2AFAD3E4DDF5968D25B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6595D725507B9032B71715F9E8B70080899158C7A06DD77BA67932F45F93C8127858DE4D86BDAC1CBA1B8341EE9D5BE9A0ABB1D147F97529925CC072ED1A434D265987740F4535294AEC7CEAA0681F5848F4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVax5M0mESuWmdFG+HNFI9xo= X-Mailru-Sender: 520A125C2F17F0B17094CDC02B85F11B3FB5C293DF12BEFB3DE06ABAFEAF6705A6CB303AE872EA39B7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 1/6] test: introduce tests for debugging extensions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Fixed your comment and updated the branch. On 27.05.26, Sergey Bronnikov wrote: > Hi, Sergey, > > LGTM with a comment below. > > Sergey > > On 5/25/26 12:14, Sergey Kaplun wrote: > > > > >>> diff --git a/test/tarantool-debugger-tests/CMakeLists.txt b/test/tarantool-debugger-tests/CMakeLists.txt > >>> new file mode 100644 > >>> index 00000000..7fd0debc > >>> --- /dev/null > >>> +++ b/test/tarantool-debugger-tests/CMakeLists.txt > >>> @@ -0,0 +1,93 @@ > >>> +set(TEST_SUITE_NAME "tarantool-debugger-tests") > >>> + > >>> +# XXX: The call produces both test and target > >>> +# as a side effect. > >>> +add_test_suite_target(tarantool-debugger-tests > >>> + LABELS ${TEST_SUITE_NAME} > >>> + DEPENDS ${LUAJIT_TEST_BINARY} > >>> +) > >>> + > >>> +# Debug info is required for testing of extensions. > >>> +if(NOT (CMAKE_BUILD_TYPE MATCHES Debug)) > >>> + message(WARNING > >>> + "Not a DEBUG build, tarantool-debugger-tests is dummy" > >>> + ) > >> it is not dummy, it doesn't exist at all: > >> > >> cmake -S . -B build -DCMAKE_BUILD_TYPE=Release > >> > >> cd build > >> > >> make tarantool-debugger-tests > >> make[3]: *** No rule to make target 'src/luajit', needed by > >> 'test/tarantool-debugger-tests/CMakeFiles/tarantool-debugger-tests-deps'. > >> Stop. > > Replaced elsewhere with "omitted". =================================================================== > > diff --git a/test/tarantool-debugger-tests/CMakeLists.txt > > b/test/tarantool-debugger-tests/CMakeLists.txt index > > 7fd0debc..a6684e72 100644 --- > > a/test/tarantool-debugger-tests/CMakeLists.txt +++ > > b/test/tarantool-debugger-tests/CMakeLists.txt @@ -10,7 +10,7 @@ > > add_test_suite_target(tarantool-debugger-tests # Debug info is > > required for testing of extensions. if(NOT (CMAKE_BUILD_TYPE MATCHES > > Debug)) message(WARNING - "Not a DEBUG build, tarantool-debugger-tests is dummy" > > + "Not a DEBUG build, tarantool-debugger-tests is omitted" > > ) > > return() > > endif() > > @@ -22,7 +22,7 @@ endif() > > if(CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND DEFINED ENV{CI}) > > message(WARNING > > "Interactive debugging is unavailable for macOS CI builds," > > - " tarantool-debugger-tests is dummy" > > + " tarantool-debugger-tests is omitted" > > ) > > return() > > endif() > > @@ -31,13 +31,17 @@ if(CMAKE_VERSION VERSION_LESS "3.12") > > #TODO:Can remove this after upgrading to CMake >= 3.12. > > find_package(PythonInterp) > > if(NOT PYTHONINTERP_FOUND) > > - message(WARNING "`python` is not found, tarantool-debugger-tests is dummy") > > + message(WARNING > > + "`python` is not found, tarantool-debugger-tests is omitted" > > + ) > > return() > > endif() > > else() > > find_package(Python COMPONENTS Interpreter) > > if(NOT PYTHON_FOUND) > > - message(WARNING "`python` is not found, tarantool-debugger-tests is dummy") > > + message(WARNING > > + "`python` is not found, tarantool-debugger-tests is omitted" > > + ) > > return() > > endif() > > set(PYTHON_EXECUTABLE "${Python_EXECUTABLE}") > > =================================================================== > > Let's create a target after checking requirements: > > diff --git a/test/tarantool-debugger-tests/CMakeLists.txt > b/test/tarantool-debugger-tests/CMakeLists.txt > index 39414db3..ab90b803 100644 > --- a/test/tarantool-debugger-tests/CMakeLists.txt > +++ b/test/tarantool-debugger-tests/CMakeLists.txt > @@ -1,12 +1,5 @@ >  set(TEST_SUITE_NAME "tarantool-debugger-tests") > > -# XXX: The call produces both test and target > -# as a side effect. > -add_test_suite_target(tarantool-debugger-tests > -  LABELS ${TEST_SUITE_NAME} > -  DEPENDS ${LUAJIT_TEST_BINARY} > -) > - >  # Debug info is required for testing of extensions. >  if(NOT (CMAKE_BUILD_TYPE MATCHES Debug)) >    message(WARNING > @@ -47,6 +40,13 @@ else() >    set(PYTHON_EXECUTABLE "${Python_EXECUTABLE}") >  endif() > > +# XXX: The call produces both test and target > +# as a side effect. > +add_test_suite_target(tarantool-debugger-tests > +  LABELS ${TEST_SUITE_NAME} > +  DEPENDS ${LUAJIT_TEST_BINARY} > +) > + >  set(DEBUGGER_TEST_ENV >    "LUAJIT_TEST_BINARY=${LUAJIT_TEST_BINARY}" >    # Suppresses __pycache__ generation. Fixed, as you suggested: =================================================================== diff --git a/test/tarantool-debugger-tests/CMakeLists.txt b/test/tarantool-debugger-tests/CMakeLists.txt index 39414db3..ab90b803 100644 --- a/test/tarantool-debugger-tests/CMakeLists.txt +++ b/test/tarantool-debugger-tests/CMakeLists.txt @@ -1,12 +1,5 @@ set(TEST_SUITE_NAME "tarantool-debugger-tests") -# XXX: The call produces both test and target -# as a side effect. -add_test_suite_target(tarantool-debugger-tests - LABELS ${TEST_SUITE_NAME} - DEPENDS ${LUAJIT_TEST_BINARY} -) - # Debug info is required for testing of extensions. if(NOT (CMAKE_BUILD_TYPE MATCHES Debug)) message(WARNING @@ -47,6 +40,13 @@ else() set(PYTHON_EXECUTABLE "${Python_EXECUTABLE}") endif() +# XXX: The call produces both test and target +# as a side effect. +add_test_suite_target(tarantool-debugger-tests + LABELS ${TEST_SUITE_NAME} + DEPENDS ${LUAJIT_TEST_BINARY} +) + set(DEBUGGER_TEST_ENV "LUAJIT_TEST_BINARY=${LUAJIT_TEST_BINARY}" # Suppresses __pycache__ generation. =================================================================== -- Best regards, Sergey Kaplun