From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 614EE6ECDE; Tue, 26 May 2026 17:42:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 614EE6ECDE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1779806534; bh=Cbi8Zb79BazZJTyHdCFOMS+cYKBH030c/ebiPsQBjzc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=uVHSTpM2FVJHC4xsXFij0HBDTbdnZ+byfsl88hueEsL5iSnnPZvs4Be6pyn1F8lTr OEgNT9wQHA37KYv4OmSObp3l0PesDbFw4vmiS1oFipUcqDl4l9PF8FIprJX7M5/ECK C+7e7Wcwd1xA0iiEx76F+WKeRWv2K2ImRxYSrWq4= Received: from send220.i.mail.ru (send220.i.mail.ru [95.163.59.59]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6758B6ECDE for ; Tue, 26 May 2026 17:42:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6758B6ECDE Received: by exim-smtp-5b85998476-twp2b with esmtpa (envelope-from ) id 1wRsyy-00000000KTJ-209B; Tue, 26 May 2026 17:42:12 +0300 Date: Tue, 26 May 2026 17:41:15 +0300 To: Evgeniy Temirgaleev Message-ID: References: <20260519123913.178775-1-skaplun@tarantool.org> <20260519123913.178775-2-skaplun@tarantool.org> <1779803427.60260456@f511.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1779803427.60260456@f511.i.mail.ru> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD98DC58EE55F2C5C3727C4554E5DD35F3CD4977B58BF78567F00894C459B0CD1B9B3B89BE20DDB216F15C513EAE8123D4D986047B61932CE8208ABB2A2229364B8505DB70707ED1B7C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D6964C9E324ABA58EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F88016AB904663428638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B240E6F23AA8CF82032E070BE324C7D3C4EA353037DF28A837F6B57BC7E64490618DEB871D839B73339E8FC8737B5C22498424CA1AAF98A6958941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249ABBCFCC36A29397A76E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8B8EC8227C8A9E94443AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735B344165809136645C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5F246DDEF39E653115002B1117B3ED696199A9FE7447BFB4C406406D89DD9EB8A823CB91A9FED034534781492E4B8EEAD0942DC5495D0595EBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADB58128AB1E6D661A716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6592D3D024AC8ECB80A0DCF353187656582ACDE707C7DCDD17DA998F10708BA9AA4D50214E4490A3E52B8341EE9D5BE9A0A1FE850DC0F228894435CA2C0A390C06C4042C739296D2DC0C7CEAA0681F5848F4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVax5M0mESuWm52QYrsFGsrE= X-Mailru-Sender: 583F1D7ACE8F49BD27F014888F2894959BB5404EB2708C460B9BF4F79351F757A7CC6B41E54C3C7ACAEE553EC0B82163F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 1/6] test: introduce tests for debugging extensions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Evgeniy! Thanks for the review! Fixed your comment and force-pushed the branch. On 26.05.26, Evgeniy Temirgaleev wrote: > Hi, Sergey! > > Thanks for the patch. Please, consider my suggestion: the debugger-aware «constants» are defined in one block per debugger. > > diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py > index 30a2c478..f4414f4d 100644 > --- a/test/tarantool-debugger-tests/debug-extension-tests.py > +++ b/test/tarantool-debugger-tests/debug-extension-tests.py > @@ -19,9 +19,6 @@ LLDB = 'lldb' in DEBUGGER > EXTENSION = EXTENSION_PATH + '/luajit_dbg.py' > TIMEOUT = 10 > > -# Don't run any initialization scripts. > -RUN_CMD_FILE = [] > - > if LLDB: > RUN_CMD_FILE = [ > '--batch', > @@ -30,15 +27,15 @@ if LLDB: > '--source-quietly', > '--source' > ] > +    INFERIOR_ARGS = '--' > +    PROCESS_RUN = 'process launch' > +    LOAD_EXTENSION = 'command script import {ext}'.format(ext=EXTENSION) > else: > # GDB. > RUN_CMD_FILE = ['--batch', '--nx', '--quiet', '--command'] > - > -INFERIOR_ARGS = '--' if LLDB else '--args' > -PROCESS_RUN = 'process launch' if LLDB else 'r' > -LOAD_EXTENSION = ( > -    'command script import {ext}' if LLDB else 'source {ext}' > -).format(ext=EXTENSION) > +    INFERIOR_ARGS = '--args' > +    PROCESS_RUN = 'r' > +    LOAD_EXTENSION = 'source {ext}'.format(ext=EXTENSION) Fixed. See the iterative patch below: =================================================================== diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py index 30a2c478..f337f0e9 100644 --- a/test/tarantool-debugger-tests/debug-extension-tests.py +++ b/test/tarantool-debugger-tests/debug-extension-tests.py @@ -19,10 +19,11 @@ LLDB = 'lldb' in DEBUGGER EXTENSION = EXTENSION_PATH + '/luajit_dbg.py' TIMEOUT = 10 -# Don't run any initialization scripts. -RUN_CMD_FILE = [] - if LLDB: + INFERIOR_ARGS = '--' + LOAD_EXTENSION = 'command script import ' + EXTENSION + PROCESS_RUN = 'process launch' + # Don't run any initialization scripts. RUN_CMD_FILE = [ '--batch', '--no-lldbinit', @@ -32,15 +33,12 @@ if LLDB: ] else: # GDB. + INFERIOR_ARGS = '--args' + LOAD_EXTENSION = 'source ' + EXTENSION + PROCESS_RUN = 'run' + # Don't run any initialization scripts. RUN_CMD_FILE = ['--batch', '--nx', '--quiet', '--command'] -INFERIOR_ARGS = '--' if LLDB else '--args' -PROCESS_RUN = 'process launch' if LLDB else 'r' -LOAD_EXTENSION = ( - 'command script import {ext}' if LLDB else 'source {ext}' -).format(ext=EXTENSION) - - RX_ADDR = r'0x[a-f0-9]+' RX_HASH = RX_ADDR # The same pattern for hexademic values. RX_FRAME = r'\[(S|\s)(B|\s)(T|\s)(M|\s)\]' =================================================================== > > -- > Best regards, > Evgeniy Temirgaleev > > > -- Best regards, Sergey Kaplun