From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 50C4D1700D8D; Tue, 28 Apr 2026 15:30:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 50C4D1700D8D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1777379423; bh=3YimZOEAi2AcFNqIT4NsDWTpYtJzTq+pXEa8OG2o7Ro=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=zVVo4NSYinII+ib10vYEzoVR9YcDPfKyC/eLFeUpuHE7kYgNEJj4NrQ4jLwDnt5QX wJmg8v7ORTyT4lIpu1gbAskPqgtg+a66U29SAFgN4ySZVdFtz19Q7NxhYmuQy+c4K0 BN0Vmr51qCgLNF2uvFnL9LickL70sFGiQsg6+UiI= Received: from send194.i.mail.ru (send194.i.mail.ru [95.163.59.33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E3B521700D8D for ; Tue, 28 Apr 2026 15:30:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E3B521700D8D Received: by exim-smtp-579cdc88d9-zsc6z with esmtpa (envelope-from ) id 1wHha0-00000000WlE-33mW; Tue, 28 Apr 2026 15:30:21 +0300 Date: Tue, 28 Apr 2026 15:29:18 +0300 To: Sergey Bronnikov Message-ID: References: <20260423170806.9647-1-skaplun@tarantool.org> <398afbb0-66c6-4935-878f-ed01356fe740@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <398afbb0-66c6-4935-878f-ed01356fe740@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9DA546775E7411B7C07A03F9D84DEF93856E2E14D298482C900894C459B0CD1B9BF78B6C2976631734205217CC62F620236164FB7BB13468F5D4BCFA94AB466B8B92CE970A8DCB349 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DB84ED444C624799EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F88016AB904663428638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2565D31C2F3EA4FAD2E070BE324C7D3C4C725FE24C0BF0D12F6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249D082881546D93491CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD269176DF2183F8FC7C057AD32ED991201537B076A6E789B0E97A8DF7F3B2552694AD5FFEEA1DED7F25D49FD398EE364050FB1593CA6EC85F86DBFC1D8BB4B114D1EB3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BDB6CDAEC4BC593EA75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5A87508A5412F0F165002B1117B3ED696941E9736A2925F761A1B8FE1FED62FE8823CB91A9FED034534781492E4B8EEAD09122B91796FF21FBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659D28659D8F12A98B6B39EB7A1E93390B39431969C19D7533AFEA419664D700EA17051A78CBB84228FB8341EE9D5BE9A0A7A4023E91A649C6F322A0EF586789F1A0CF130CA1257E9C86536EB022892E5344C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVW+UUD87bVUoY0UsCUiP0L4= X-Mailru-Sender: 583F1D7ACE8F49BDD951BA70C165859E02A57D40DB2298C7F6A6F50B1491C03589D4896C42EC6369F0FF1E59F279F262F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] ci: conditionally install lua-cjson for perf job X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Please consider my answers below. On 28.04.26, Sergey Bronnikov wrote: > Hi, Sergey! > > A few things worry me: we still don't know the root cause of the problem. It should be investigated and fixed in the scope of the 12600 [1]. For LuaJIT's CI, this workaround works just fine. > > The proposed patch merely reduces the frequency of module installations. Yes, it installs the module only once. > > And if an installation is required, the installation will still break. Not always, it usually passes successfully and fails only on the fourth run. So, 1 successful installation is enough to prevent flakiness, which is OK for our needs in LuaJIT. It is better to have some statistics instead of having none, isn't it? > > See comments inline. > > Sergey > > On 4/23/26 20:08, Sergey Kaplun wrote: > > We have encountered the flakiness of the network on our CI runners. It > > happens only on lua-cjson installation and only in some particular job > > run. > > > > This patch helps to deal with it by installing this package only if it > s/helps to deal with it/helps to reduce a number of installations/ Don't get the comment about the number of installations. Maybe rephrase it like the following? | This patch workarounds it by installing the package only if ... > > is not installed in the system. Also, it installs it only for Lua 5.1, > > which is compatible with LuaJIT. > > --- > > > > Branch:https://github.com/tarantool/luajit/tree/skaplun/ci-perf-install-conditionally-lua-cjson > > > > .github/actions/setup-performance/action.yml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/.github/actions/setup-performance/action.yml b/.github/actions/setup-performance/action.yml > > index 4e0e1929..3c2a8230 100644 > > --- a/.github/actions/setup-performance/action.yml > > +++ b/.github/actions/setup-performance/action.yml > > @@ -11,7 +11,9 @@ runs: > > apt install -y curl luarocks util-linux > > shell: bash > > - name: Install Lua modules > > - run: luarocks install lua-cjson > > + run: > > > + luarocks --lua-version=5.1 show lua-cjson || > > + luarocks --lua-version=5.1 install lua-cjson > Why do we need specifying Lua version now? Previously, it worked without > setting exact version. I've preferred to describe it specifically since the most modern distros provide Lua 5.3+ by default. Should I add the comment in the commit message? > > shell: bash > > - name: Run script to setup Linux environment > > run: sh ./perf/helpers/setup_env.sh [1]: https://github.com/tarantool/tarantool/issues/12600 -- Best regards, Sergey Kaplun