From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 122986EC55; Wed, 16 Jun 2021 11:31:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 122986EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1623832298; bh=aRx9v0GfVpZw6O3VPII4QeeEhzuM8Q1Js3ID4YY1Yek=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=TMKubRi8FF30zl20KR+mFqWAhxtNk5t01F1Y90/A27QrtS+aP1E6+XYPPn7kfVBeO aXjHauVeOYGQKWhMvwxYRB/XmuOjzGSa7WbnKnGib7YBzvzYBiDfFWYtggvATWx/G6 Wvdi+7eaHmQHh+8mKg7ChUToFyyiuM+wQ34iPflE= Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C172D6EC55 for ; Wed, 16 Jun 2021 11:31:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C172D6EC55 Received: by smtp56.i.mail.ru with esmtpa (envelope-from ) id 1ltQxU-00056U-0C; Wed, 16 Jun 2021 11:31:36 +0300 To: Cyrill Gorcunov , tml Cc: Vladislav Shpilevoy References: <20210615135630.63465-1-gorcunov@gmail.com> <20210615135630.63465-2-gorcunov@gmail.com> Message-ID: Date: Wed, 16 Jun 2021 11:31:35 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D5B0DA836B685C54F4BC37E91F2690B85F43D7652182C513182A05F5380850409807AE936DD2981B76DE97EBE839A035A7EBF5E50ED0379AE0E6C1ADB5B0B433 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE792C68BF9CD4C0E9EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063729381D024F10DD158638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8443E557E62B2CFCD1D97F0664EE6A66F117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCC908CD1B87A134A2A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10F28451B159A507268D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE7B96B19DC40933219935A1E27F592749D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE389DDFE3E282F3DD16136E347CC761E07C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BC468E7E89D8C5D6EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831D1FC64566666C2B555037634962608ED X-C1DE0DAB: 0D63561A33F958A5604719536CA2A336C757682764E480464BD52D6CB43283BAD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3473688ED311681BF0B7B4B7002E9F7BC30C02BF407962EC08ED21B22A1658E0EA40C39572014037751D7E09C32AA3244CCFF771E018F0857271AE57432BD55DB195A9E0DC41E9A4CFFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojzTTns/+yd+Y/OOrfthT5Uw== X-Mailru-Sender: 583F1D7ACE8F49BD9DF7A8DAE6E2B08AC163C6488B2663B67EB93CB695ABB6E28D41AC28E4E323C4424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v9 1/1] applier: filter incoming synchro packets via transaction initiator X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 15.06.2021 21:08, Cyrill Gorcunov пишет: > On Tue, Jun 15, 2021 at 08:02:59PM +0300, Cyrill Gorcunov wrote: >> On Tue, Jun 15, 2021 at 05:26:06PM +0300, Serge Petrenko wrote: >>>> +box.space.sync:select{} >>>> + | --- >>>> + | - - [1] >>>> + | ... >>> You need to wait for the space creation, just like >>> you do below. Otherwise the test'll be flaky. >>> Also, please see a comment regarding wait_lsn vs wait_cond >>> below. >> As being discussed due to quorum=2 and sync space we don't need >> to wait. >> >>>> +test_run:wait_cond(function() return \ >>>> + box.space.sync ~= nil and \ >>>> + box.space.sync:get{1} ~= nil and \ >>>> + box.space.sync:get{1}[1] == 1 end, 100) >>>> + | --- >>>> + | - true >>>> + | ... >>> I suggest you use wait_lsn('replica2', 'master') here >>> instead of this bulky wait_cond. >>> First of all, it takes a single line, instead of 4 lines. >>> >>> Secondly, you forgot to test `box.space.sync.index.pk ~= nil`, meaning >>> the test will still fail occasionally, when index creation doesn't replicate >>> in time. >> You mean something like below? >> --- > I force pushed an update. Thanks for the fixes! I assume the new branch is gorcunov/gh-6035-applier-filter-9 LGTM. -- Serge Petrenko