From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id ADB906EC40; Thu, 23 Sep 2021 01:46:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ADB906EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1632350765; bh=15Fcbyc7LKw1D2C4BFBcnleJFZpmPi3wb6mx0+9IQoQ=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=iQvtBIoqPg3LW3jJZP1fPX0HhUyWhbXIYXBYIIL5+ihuyryvuJTzRto162pJs5r7n 1UybOJfvgTAqAJdgfw01mB/hVtEreFsODo2r3MHn39b+oYN0V8md+TCO2aR+ckLOoj MW7XWmrSjpRyNxv31BRoLWR060bOdv9gwFb67AlA= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C4F536EC40 for ; Thu, 23 Sep 2021 01:46:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C4F536EC40 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1mTB06-0007tv-TC; Thu, 23 Sep 2021 01:46:03 +0300 To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <8ecde75f62af960261dafcbca41f8aba9b7e3e9e.1632217203.git.imeevma@gmail.com> Message-ID: Date: Thu, 23 Sep 2021 00:46:01 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <8ecde75f62af960261dafcbca41f8aba9b7e3e9e.1632217203.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91AE02D33A9C88A2FAC52BB37A480E789638BB4D06A25224200894C459B0CD1B90BCF5EEA380E68ADA764A2F7F474F3A2DC443D2BA0B873E59799EF890AE2FCA9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C2204D4F9A221771EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375E5376F82D9E62E48638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D815D8B45138EC76CC896ABAF74E021E72117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18F04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B613439FA09F3DCB32089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B505146249CD04DF8AE96C75086AA6BE65DF X-C1DE0DAB: 0D63561A33F958A5EDB34C093A6474EB0B0E30843B7FD43141ACA9D1EB1D51FAD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA759D2A03B9C34326B3410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349320586B19AD2C724E4E8E0044DE8859C0D41E59749E62B9BFBF39CA20A0F83179957994F51077741D7E09C32AA3244CBEB6FA768B77365B4DA2FD9BE33A4B9195A9E0DC41E9A4CF729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojYVPXnTWjYf4VFAo7Q8IjTQ== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D84830B366330A798AFBAA13166BE05563841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 03/15] sql: remove AggStep0 and OP_BuiltinFunction0 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the fixes! > diff --git a/src/box/sql/select.c b/src/box/sql/select.c > index 92e40aef6..459325a88 100644 > --- a/src/box/sql/select.c > +++ b/src/box/sql/select.c > @@ -6744,3 +6749,21 @@ sql_expr_extract_select(struct Parse *parser, struct Select *select) > parser->parsed_ast.expr = > sqlExprDup(parser->db, expr_list->a->pExpr, 0); > } > + > +struct sql_context * > +sql_context_new(struct Vdbe *vdbe, struct func *func, uint32_t argc) > +{ Could you please introduce sql_context_delete() and use it where appropriate? I am sorry I didn't notice it first time. > + uint32_t size = sizeof(struct sql_context); > + if (argc > 1) > + size += (argc - 1) * sizeof(struct Mem *); > + struct sql_context *ctx = sqlDbMallocRawNN(sql_get(), size); > + if (ctx == NULL) > + return NULL; > + ctx->pOut = NULL; > + ctx->func = func; > + ctx->is_aborted = false; > + ctx->skipFlag = 0; > + ctx->pVdbe = vdbe; > + ctx->iOp = 0; > + return ctx; > +}