From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.mail.ru (smtp1.mail.ru [94.100.179.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C282F445320 for ; Sun, 5 Jul 2020 20:03:33 +0300 (MSK) References: <1593757997-4145-1-git-send-email-alyapunov@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Sun, 5 Jul 2020 19:03:31 +0200 MIME-Version: 1.0 In-Reply-To: <1593757997-4145-1-git-send-email-alyapunov@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 00/15] Transaction engine for memtx engine List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aleksandr Lyapunov , tarantool-patches@dev.tarantool.org Hi! Could you please provide branch and issue links, and put the reviewers in CC/TO? Like described here https://github.com/tarantool/tarantool/wiki/Code-review-procedure. I assume the branch is this: https://github.com/tarantool/tarantool/tree/alyapunov/gh-4897-memtx-tx-engine-v6 And the issue is this: https://github.com/tarantool/tarantool/issues/4897 The CI looks very broken: https://gitlab.com/tarantool/tarantool/-/pipelines/162943109 I can't build the branch either. Besides, I see a dirty commit 'fixme' on the branch. What is it? > Work is still in progress but the patchset is ready for discussions. Would be nice to have some document with general overview of what is done. Usually this is an RFC. Or at least in the cover letter or in the commit messages and comments. This feature is definitely not an easy patch to understand from sources only in a short time.