From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1DB6C6EC58; Sun, 1 Aug 2021 18:03:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1DB6C6EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627830230; bh=BVpDnVZoO+hhmbDbXx7By/DgzRxrxYK1tAX4e4KKoas=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=PoA0lKKOuqG7UVfdamiFygZUD9yf3mwGihAt5oBqI4fxpX7lD4WYLO15AF+Cmk5iy WHROuCuH4vvRyyf6dB8S8t1e0xoPnBzdmQ5S6n89UCq5/We8pK0g5ClKTcTgBrXG6r d8J1gdpLsJqguVlyv2YhoX2093VD9QFs7PHIP85I= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DCB0B6EC58 for ; Sun, 1 Aug 2021 18:03:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DCB0B6EC58 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1mAD0G-0001g8-3b; Sun, 01 Aug 2021 18:03:48 +0300 To: Sergey Ostanevich References: Message-ID: Date: Sun, 1 Aug 2021 17:03:47 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C33D83595CA30D6DC5179D1C9A908C47E5182A05F538085040C81005132E649B5F55A5C6851A103B5D98AF504847663CF2B1631A3D1C1AAEA7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B2CE06D3E4B8AFEBEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E8F1A1743CF948808638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8BBE230560164C0976D764B8C7A345064117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3733B5EC72352B9FA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F6FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B613439FA09F3DCB32089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5E4CCD0D2D6479E4220A4B9B960224C017755838F8A2A6D09D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA751B940EDA0DFB0535410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3474B2583E51315984414764ABB7B7B6758E596712DFCF01D5465E92242E8DC926E525F4401BE22F8A1D7E09C32AA3244C4AD89A0EE0B2C8574BFED26335DD33FE5A1673A01BA68E40FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMCfuYI4Pref/4qWlrrjnHQ== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DABEF3242F7C3272FF5221EA0F578F8B03841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 2/5] info: use luaL_pushuuidstr() for box.info uuids X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the review! >> diff --git a/test/app-tap/gh-5632-6050-gc-buf-reuse.test.lua b/test/app-tap/gh-5632-6050-6259-gc-buf-reuse.test.lua >> similarity index 79% >> rename from test/app-tap/gh-5632-6050-gc-buf-reuse.test.lua >> rename to test/app-tap/gh-5632-6050-6259-gc-buf-reuse.test.lua >> index bf7590a14..f806ba6b7 100755 >> --- a/ >> +++ b/test/app-tap/gh-5632-6050-6259-gc-buf-reuse.test.lua >> @@ -190,11 +190,47 @@ local function test_json(test) >> test:ok(is_success, 'json in gc') >> end >> >> -local test = tap.test('gh-5632-6050-gc-buf-reuse') >> -test:plan(4) >> +local function test_info_uuid(test) >> + test:plan(1) >> + >> + local gc_count = 100 >> + local iter_count = 1000 >> + local is_success = true >> + >> + local function uuid_to_str() >> + local uu = uuid.new() >> + local str1 = box.info.uuid >> + local str2 = box.info.cluster.uuid >> + local str3 = box.info.uuid >> + local str4 = box.info.cluster.uuid >> + if str1 ~= str3 or str2 ~= str4 then >> + is_success = false >> + assert(false) > > Why did you keep the assert? I believe there should be just a non-ok in test? Dropped on the branch.