From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 44DAE6EC5F; Thu, 15 Apr 2021 01:48:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 44DAE6EC5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618440517; bh=0usxLMbo9RY0AB2kFrXLhkt2YhYPsDn+sq5n+EyzZ4I=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=uafYvi2xZfwm2smyIqQtA11zjv7mAUUkkZnyZ2LmtneBDUs8RUwgWuyzblDelAbF9 gYAamFD2kbcbHImRKctBE+f4E0TmMkI44e0ZicPWOv7rGTmJl351gLZXybnxEZGc6M To96ki4ct3IVLxgmX5SqezAkZGnGJrGJL/d2NFJc= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0983E6EC5F for ; Thu, 15 Apr 2021 01:48:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0983E6EC5F Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lWoJH-0006F9-54; Thu, 15 Apr 2021 01:48:35 +0300 To: Mergen Imeev References: <6724ff5d04df88fc611d4f921e6bb0b541cd5863.1617984948.git.imeevma@gmail.com> <3e0e446f-25b9-c904-6f2f-e263913dbe17@tarantool.org> <20210413160916.GA154326@tarantool.org> Message-ID: Date: Thu, 15 Apr 2021 00:48:34 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210413160916.GA154326@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480257C85EA0BB7A95D5E28B957962BB550182A05F5380850407958D280ECFD7F946F90A417EEC9B5A775791ACB721BE16C0A9E0F128DF4E37D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76ABD3380F320B62CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637389D8DDD54F43F7A8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B24FF0480F6821F55A6851F50209F2ABD9618001F51B5FD3F9D2E47CDBA5A96583C09775C1D3CA48CFA333A05395E4745B117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE7C88295285D2BDD949FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA73A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E7358CCB3ED2A1DE2304C4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831A8A58D8B8EB5941DEC17C485AA92ACC2 X-C1DE0DAB: 0D63561A33F958A5A040488A179C9DC1AA954E20B909153EB6EFDCFAE89E07AAD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C53592357E805773220BEAA80E836072A59862B3D6CECE40BFAA5A85A3D9041DB62287442DB7A9861D7E09C32AA3244CCD13D92D3D776F030D6BD65F559270D57101BF96129E4011FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrcJA+pXcDunx9jYItGIrfQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822379A4CA5365435D16377052DC60D73B53841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v5 12/52] sql: introduce mem_is_*() functions() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for working on this! > diff --git a/src/box/sql/mem.h b/src/box/sql/mem.h > index 82b3084fb..041d8a414 100644 > --- a/src/box/sql/mem.h > +++ b/src/box/sql/mem.h > @@ -87,21 +87,6 @@ struct Mem { > */ > #define MEMCELLSIZE offsetof(Mem,zMalloc) > > -/** > - * Return a string that represent content of MEM. String is either allocated > - * using static_alloc() of just a static variable. > - */ > -const char * > -mem_str(const struct Mem *mem); > - > -/** Initialize MEM and set NULL. */ > -void > -mem_create(struct Mem *mem); > - > -/** Free all allocated memory in MEM and set MEM to NULL. */ > -void > -mem_destroy(struct Mem *mem); Why did you move them? They were just introduced in the previous commits.