From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9A4A4C631C5; Thu, 29 Aug 2024 12:45:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9A4A4C631C5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724924701; bh=cHXo7H/t9CoS/1CK5Qzs+sktLhJxjHTTQ7WwU8fp3z8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=XKkWlHf+b5CEmqFsptJ4gIS2+PyKtnR6QwpZwyMh027n1HH3EEne2EvaxH+uFGLov QlHK8IFf6RpiBXKoGvj2ZJeJm6DD5sSU2bvVW6RMPXXAflLJMNJQDuGp8v7V+Skr2M Uqfxf23QoP4S8ac0g1qC2flSiY+MHCrtQ11KJrmA= Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [95.163.41.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6F037C631C4 for ; Thu, 29 Aug 2024 12:45:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6F037C631C4 Received: by smtp29.i.mail.ru with esmtpa (envelope-from ) id 1sjbi7-0000000BByr-1Rxf; Thu, 29 Aug 2024 12:44:59 +0300 Content-Type: multipart/alternative; boundary="------------9Z1hRe0ke40GT6HURAxETEkK" Message-ID: Date: Thu, 29 Aug 2024 12:44:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: <3ed1e158692a9773e3122cfdb134107cd0415354.1724228998.git.skaplun@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD996C3684A4DDEC70E24920834B9C91E1C3B26DC488A99EBF9182A05F5380850404F88F7721F3D1BE933594132A326AF8B8A0A96B42828C46F4E2C8F2F5C7C6D3B7EDAE2B993BF3920 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75AD53DF1D86BACA3EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637993F4D087AF024C68638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B14943F9F0E60DAD35155CBD31D40BA664F4D5DE89CAF3FDCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637D0FEED2715E18529389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F790063742938F816945AD6ED81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE7A9700665CE5BC0A2EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C37725542EFDE5E0D335872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A57B752F7403B88C8E5002B1117B3ED696EF906765797761113D2BBC1EF78EDEBE823CB91A9FED034534781492E4B8EEADAE4FDBF11360AC9BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34C2BE7381A0AD3DF17FB9106C5BB4B0C0C288880611D6F7D2A05030672D70BEB0B45F55889236A84F1D7E09C32AA3244CC071F76CFE9E0D407B0DC8E7D22A103A16DF6A827BFBE7BEEA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj+zzg9FbUfZ8VFg4oKbZm+w== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F258845888932F202590DEBF601A8E04A89F3FFC32D8BA1F83D4569C3256341C7F6B3367645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 21/45] test: enable LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------9Z1hRe0ke40GT6HURAxETEkK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for the fixes! LGTM On 26.08.2024 09:50, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Fixed your comments and force-pushed the branch. > > On 23.08.24, Sergey Bronnikov wrote: >> Sergey, >> >> >> On 21.08.2024 11:58, Sergey Kaplun wrote: >>> This patch moves the aforementioned test from the to the >>> directory, includes it in , and names subtests. >>> >>> Part of tarantool/tarantool#9398 >>> --- >> thanks for the patch! LGTM with a minor comment > > >>> diff --git a/test/LuaJIT-tests/trace/jit_flush.lua b/test/LuaJIT-tests/trace/jit_flush.lua >>> new file mode 100644 >>> index 00000000..a995921e >>> --- /dev/null >>> +++ b/test/LuaJIT-tests/trace/jit_flush.lua > > >>> + >>> + >> please remove excess newline > Fixed, thanks! > See the iterative patch below. > > =================================================================== > diff --git a/test/LuaJIT-tests/trace/jit_flush.lua b/test/LuaJIT-tests/trace/jit_flush.lua > index a995921e..4cdf2c39 100644 > --- a/test/LuaJIT-tests/trace/jit_flush.lua > +++ b/test/LuaJIT-tests/trace/jit_flush.lua > @@ -52,7 +52,6 @@ do --- Flush in the loop. > jit.flush() > end > > - > do --- Flushes of not existed traces. > jit.flush() > > =================================================================== > >>> +do --- Flushes of not existed traces. >>> + jit.flush() >>> + >>> + jit.flush(1) -- ignored >>> + jit.flush(2) -- ignored >>> + for _ = 1, 1e7 do end -- causes trace #1 >>> + >>> + jit.flush(2) -- ignored >>> + jit.flush(1) -- ok >>> + jit.flush(1) -- crashes >>> +end --------------9Z1hRe0ke40GT6HURAxETEkK Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for the fixes! LGTM

On 26.08.2024 09:50, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!
Fixed your comments and force-pushed the branch.

On 23.08.24, Sergey Bronnikov wrote:

Sergey,


On 21.08.2024 11:58, Sergey Kaplun wrote:

This patch moves the aforementioned test from the <misc> to the <trace/>
directory, includes it in <index>, and names subtests.

Part of tarantool/tarantool#9398
---

thanks for the patch! LGTM with a minor comment

<snipped>


diff --git a/test/LuaJIT-tests/trace/jit_flush.lua b/test/LuaJIT-tests/trace/jit_flush.lua
new file mode 100644
index 00000000..a995921e
--- /dev/null
+++ b/test/LuaJIT-tests/trace/jit_flush.lua

<snipped>


+
+

please remove excess newline

Fixed, thanks!
See the iterative patch below.

===================================================================
diff --git a/test/LuaJIT-tests/trace/jit_flush.lua b/test/LuaJIT-tests/trace/jit_flush.lua
index a995921e..4cdf2c39 100644
--- a/test/LuaJIT-tests/trace/jit_flush.lua
+++ b/test/LuaJIT-tests/trace/jit_flush.lua
@@ -52,7 +52,6 @@ do --- Flush in the loop.
   jit.flush()
 end
 
-
 do --- Flushes of not existed traces.
   jit.flush()
 
===================================================================


+do --- Flushes of not existed traces.
+  jit.flush()
+
+  jit.flush(1) -- ignored
+  jit.flush(2) -- ignored
+  for _ = 1, 1e7 do end -- causes trace #1
+
+  jit.flush(2) -- ignored
+  jit.flush(1) -- ok
+  jit.flush(1) -- crashes
+end


    

  
  


--------------9Z1hRe0ke40GT6HURAxETEkK--