Hi, Sergey,
thanks for the fixes! LGTM
Hi, Sergey! Thanks for the review! Fixed your comments and force-pushed the branch. On 23.08.24, Sergey Bronnikov wrote:Sergey, On 21.08.2024 11:58, Sergey Kaplun wrote:This patch moves the aforementioned test from the <misc> to the <trace/> directory, includes it in <index>, and names subtests. Part of tarantool/tarantool#9398 ---thanks for the patch! LGTM with a minor comment<snipped>diff --git a/test/LuaJIT-tests/trace/jit_flush.lua b/test/LuaJIT-tests/trace/jit_flush.lua new file mode 100644 index 00000000..a995921e --- /dev/null +++ b/test/LuaJIT-tests/trace/jit_flush.lua<snipped>+ +please remove excess newlineFixed, thanks! See the iterative patch below. =================================================================== diff --git a/test/LuaJIT-tests/trace/jit_flush.lua b/test/LuaJIT-tests/trace/jit_flush.lua index a995921e..4cdf2c39 100644 --- a/test/LuaJIT-tests/trace/jit_flush.lua +++ b/test/LuaJIT-tests/trace/jit_flush.lua @@ -52,7 +52,6 @@ do --- Flush in the loop. jit.flush() end - do --- Flushes of not existed traces. jit.flush() ===================================================================+do --- Flushes of not existed traces. + jit.flush() + + jit.flush(1) -- ignored + jit.flush(2) -- ignored + for _ = 1, 1e7 do end -- causes trace #1 + + jit.flush(2) -- ignored + jit.flush(1) -- ok + jit.flush(1) -- crashes +end