From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 412AC26C34 for ; Fri, 22 Feb 2019 12:51:41 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EGgAzbtETlcH for ; Fri, 22 Feb 2019 12:51:41 -0500 (EST) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9598526C2B for ; Fri, 22 Feb 2019 12:51:40 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH v1 1/4] box: introduce new helpers in column_mask.h References: <2c60dc5e-f5cb-001e-b81f-a7e04967e1dd@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Fri, 22 Feb 2019 20:51:37 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Kirill Shcherbatov , tarantool-patches@freelists.org Hi! Thanks for the fixes! Once you introduced the new helpers, please, use them. I found raw column mask usage in sql_space_column_is_in_pk(). Also, the first two hunks from the next commit does not belong to the bug, so please, move them here (I speak about alter.cc changes).