From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 550D315DEA80; Mon, 17 Nov 2025 16:27:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 550D315DEA80 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1763386062; bh=dr5PNrc2jZVX3xmrKxg7XidIOoRpoe1oWUtwVWxJ+d8=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=F1TWWPisFCMOulxmKOO741/Hh9wqmZ8yIYGfvrb2r0lA0P5ThlpjapBiZi5uDksyW GKOUCSarXs0JuS34MWkAVx3ZU7133ZXR2BZtA4dyx2i+QYvrv8tfKw0wTk3xZf7qQQ lmM2MddXxNG11bmcUeJaOzNxfKkUcSzHif1YE0v4= Received: from send81.i.mail.ru (send81.i.mail.ru [89.221.237.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8BD8B15DEA80 for ; Mon, 17 Nov 2025 16:25:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8BD8B15DEA80 Received: by exim-smtp-77df68b9cf-k4thg with esmtpa (envelope-from ) id 1vKzF0-00000000Aek-3GGt; Mon, 17 Nov 2025 16:25:59 +0300 Content-Type: multipart/alternative; boundary="------------JtKSJU0ZgFJHWSJQbfjQq5ZZ" Message-ID: Date: Mon, 17 Nov 2025 16:25:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <9f6eb7724aad3e7090f26e25980f214151dd7192.1761301736.git.skaplun@tarantool.org> In-Reply-To: <9f6eb7724aad3e7090f26e25980f214151dd7192.1761301736.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD99F284BE5F96F126D312E55A5CBDF34CE7C08F0781D9C0775182A05F5380850404C228DA9ACA6FE2779479C33BD7087B13DE06ABAFEAF67051889B89217B03D713C1CBB97E487F8EE559A614689EEA07F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A4C4638C9DDF45FCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566D0BE23D09F2BEA508FF8BE6FDBD36092408A415DC94CB97D333E8171F3918759389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C224958C1606C78F2434E76E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8B6A4E49BB0F3BA1413AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E7356436AE5DD6441DC7C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5CB95098C86B724DD5002B1117B3ED696A07DCEA04106832819AC5B239BAD4335823CB91A9FED034534781492E4B8EEAD003C2D46C52F18F2BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF3B9F89E450CAE43C8583803D1B5846ABA919DCF83765500693674BF77D3325A06D10329F4AAC8FAEDD12B02666E49356C039F9D8D30A726DE17169D636A2256981505D60F510ED9B111DC66A97D0BFE2913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVfFX+FmbwDW1bZr5EK7TlbE= X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B59C690F8BF7357E8303DE06ABAFEAF67051889B89217B03D71B7CBEF92542CD7C8795FA72BAB74744FC77752E0C033A69EA16A481184E8BB1C9B38E6EA4F046BE03A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 20/41] perf: adjust nsieve in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------JtKSJU0ZgFJHWSJQbfjQq5ZZ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for the patch! See my comments. Sergey On 10/24/25 13:50, Sergey Kaplun wrote: > This patch adjusts the aforementioned test to use the benchmark > framework introduced before. The default arguments are adjusted > according to the file. The arguments to the script still > can be provided in the command line run. > --- > perf/LuaJIT-benches/nsieve.lua | 35 +++++++++++++++++++++++++++++----- > 1 file changed, 30 insertions(+), 5 deletions(-) > > diff --git a/perf/LuaJIT-benches/nsieve.lua b/perf/LuaJIT-benches/nsieve.lua > index 6de0524f..2d1b66c8 100644 > --- a/perf/LuaJIT-benches/nsieve.lua > +++ b/perf/LuaJIT-benches/nsieve.lua > @@ -1,3 +1,4 @@ > +local bench = require("bench").new(arg) > > local function nsieve(p, m) > for i=2,m do p[i] = true end > @@ -11,11 +12,35 @@ local function nsieve(p, m) > return count > end > > -local N = tonumber(arg and arg[1]) or 1 > +local DEFAULT_N = 12 Why 12? > +local N = tonumber(arg and arg[1]) or DEFAULT_N > if N < 2 then N = 2 end > local primes = {} > > -for i=0,2 do > - local m = (2^(N-i))*10000 > - io.write(string.format("Primes up to %8d %8d\n", m, nsieve(primes, m))) > -end > +local benchmark > +benchmark = { > + name = "nsieve", > + payload = function() > + local res = {} > + local items = 0 > + for i=0,2 do add more whitespaces, here and below > + local m = (2^(N-i))*10000 > + items = items + m > + res[i] = nsieve(primes, m) > + end > + benchmark.items = items > + > + return res > + end, > + checker = function(res) > + if N == DEFAULT_N then > + assert(res[0] == 2488465) > + assert(res[1] == 1299069) > + assert(res[2] == 679461) > + end > + return true > + end, > +} > + > +bench:add(benchmark) > +bench:run_and_report() --------------JtKSJU0ZgFJHWSJQbfjQq5ZZ Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for the patch! See my comments.

Sergey

On 10/24/25 13:50, Sergey Kaplun wrote:
This patch adjusts the aforementioned test to use the benchmark
framework introduced before. The default arguments are adjusted
according to the <PARAM_x86.txt> file. The arguments to the script still
can be provided in the command line run.
---
 perf/LuaJIT-benches/nsieve.lua | 35 +++++++++++++++++++++++++++++-----
 1 file changed, 30 insertions(+), 5 deletions(-)

diff --git a/perf/LuaJIT-benches/nsieve.lua b/perf/LuaJIT-benches/nsieve.lua
index 6de0524f..2d1b66c8 100644
--- a/perf/LuaJIT-benches/nsieve.lua
+++ b/perf/LuaJIT-benches/nsieve.lua
@@ -1,3 +1,4 @@
+local bench = require("bench").new(arg)
 
 local function nsieve(p, m)
   for i=2,m do p[i] = true end
@@ -11,11 +12,35 @@ local function nsieve(p, m)
   return count
 end
 
-local N = tonumber(arg and arg[1]) or 1
+local DEFAULT_N = 12
Why 12? 
+local N = tonumber(arg and arg[1]) or DEFAULT_N
 if N < 2 then N = 2 end
 local primes = {}
 
-for i=0,2 do
-  local m = (2^(N-i))*10000
-  io.write(string.format("Primes up to %8d %8d\n", m, nsieve(primes, m)))
-end
+local benchmark
+benchmark = {
+  name = "nsieve",
+  payload = function()
+    local res = {}
+    local items = 0
+    for i=0,2 do
add more whitespaces, here and below 
+      local m = (2^(N-i))*10000
+      items = items + m
+      res[i] = nsieve(primes, m)
+    end
+    benchmark.items = items
+
+    return res
+  end,
+  checker = function(res)
+    if N == DEFAULT_N then
+      assert(res[0] == 2488465)
+      assert(res[1] == 1299069)
+      assert(res[2] == 679461)
+    end
+    return true
+  end,
+}
+
+bench:add(benchmark)
+bench:run_and_report()
--------------JtKSJU0ZgFJHWSJQbfjQq5ZZ--