From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 023EF9D9B55; Wed, 7 Feb 2024 09:53:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 023EF9D9B55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707288807; bh=TEMpmgLgfd9QmA8KIW8pl6aGYbQXi9kpF1ip66V0Bs8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=aImVhY/GBM4cZYgOfAFy23a0Nw/QttR8eXoEjcf379WpqAkeK6j+VPhG+vFjDYIOA 1F4KQUCYfo4WwPuzpMFVESd7sB1SdvtZI+cs5ovER9vK3h4CcpuFqFjVBmEYDNodMZ ZFQd45sDxy1KCMiczhMWKI6BCGo+S0peukm/YULA= Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [95.163.41.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1869856CD16 for ; Wed, 7 Feb 2024 09:53:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1869856CD16 Received: by smtp46.i.mail.ru with esmtpa (envelope-from ) id 1rXboD-0000000FPRz-1w5f; Wed, 07 Feb 2024 09:53:25 +0300 Message-ID: Date: Wed, 7 Feb 2024 09:53:25 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: <45b12cbc615209e0017799101de44ff538f22b64.1706520765.git.skaplun@tarantool.org> <2c92df33-3e56-41ec-abc4-2656a49fa0db@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD94C460F083DF69F51578153A4FD570891E17A4654ABD35A84182A05F538085040EEEDA72B128422CB411046492FDDF80630A05222BE0B671C6D471AED9581EF333EE2A1A432EA2933 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E106B30A4B2F6E65EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006373D58C44ED3182E498638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8BF28085904812BABE8F8E8FBD7FF5C63345A2BF841B88AF5CC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8EDCF5861DED71B2F389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F7900637D26F802DBF5E8046D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE760F066B5F943C53AEC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5278DA827A17800CE7A03E8F3C2D3812562EB15956EA79C166176DF2183F8FC7C04E672349037D5FA5725E5C173C3A84C30E7A8B1B1FD51AB935872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5626EE2ED5F685C0F5002B1117B3ED6965729518B5501BD5D3D2BBC1EF78EDEBE823CB91A9FED034534781492E4B8EEAD329DC2EF12373DEABDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFDD2C62DC7A6D9649AE382633041C1A4AA51FC523BEFA26DA612F69F9DB3A84138D4FFD5EE5365399807D692F32DC7032416331F6ECA8242B88BD6EB9BCBCAA669913FC2119B145A95F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh/iSjD2txnMvgXEVa6F6yA== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F258845890831EF5F7E1A30DF33F69C7E48EA1FB69AEA3AD8CE266436747B68F6006C5D3645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 14/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey thanks for the fix! LGTM On 2/6/24 16:33, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Fixed your comment below. > > On 05.02.24, Sergey Bronnikov wrote: >> Hi, Sergey >> >> thanks for the patch. LGTM with a minor comment >> >> On 1/29/24 13:45, Sergey Kaplun wrote: > > >>> +do --- ligud to pointer >> typo: ligud -> lightud > Fixed as the following (since the test name should be verbose): > > =================================================================== > diff --git a/test/LuaJIT-tests/lib/ffi/ffi_jit_conv.lua b/test/LuaJIT-tests/lib/ffi/ffi_jit_conv.lua > index 0e64fe75..9edf67de 100644 > --- a/test/LuaJIT-tests/lib/ffi/ffi_jit_conv.lua > +++ b/test/LuaJIT-tests/lib/ffi/ffi_jit_conv.lua > @@ -259,7 +259,7 @@ do --- int16_t array arithmetic > assert(a[99] == 100) > end > > -do --- ligud to pointer > +do --- lightuserdata to pointer > local ud = ctest.lightud(12345678) > local s = ffi.new("struct { void *p; }") > for i=1,100 do > =================================================================== > >> >