From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8AD851A1EEBB; Mon, 16 Mar 2026 10:36:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8AD851A1EEBB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1773646602; bh=kTcDsVxr21yojD+kvi+IHpwQggxBjrke+rxZ6X+j2JA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=FWWyVH4vKM8KaEnZ98P8ueI6pvFCxGFzk5goYARdlF9FOG9OrimUOYYPiyoelMXw4 VkLxtf+vgBKP8OGK2mA/IT8PxCJsNyWvTxzGewDIahPrl9M6HeeuuBQzJ5pWKfpJa4 ho7DTKPi709HYP7p90U63+BBlUslwgANZtWvpFHc= Received: from send129.i.mail.ru (send129.i.mail.ru [89.221.237.224]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1D9FF1A1EEB8 for ; Mon, 16 Mar 2026 10:36:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1D9FF1A1EEB8 Received: by exim-smtp-64cdfc6c8d-jn7bq with esmtpa (envelope-from ) id 1w22VD-00000000Kk2-3z0K; Mon, 16 Mar 2026 10:36:40 +0300 Date: Mon, 16 Mar 2026 10:37:38 +0300 To: Sergey Bronnikov , tarantool-patches@dev.tarantool.org Message-ID: References: <334e8dd174e6f4c9a03b3a5827c36d5353a85238.1773330679.git.skaplun@tarantool.org> <4454d7e1-43a6-4151-b39f-26fec9a7f04d@tarantool.org> <256a4bfa-edea-4971-b5c3-3b94a102c6d9@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91ABAE9865AC7DC884CC270DE33D3AA4DEF70278E8A0DC23E182A05F53808504066FB63821C6EA7603DE06ABAFEAF6705D29487982D20A1F1485E517A90A01C51DB5804FDCCB62C7C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE727FD6E7FC3A8F857EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566BCD8AD057D84402C32F59EE128263C18F0C9C4FAB9B7A1828C8A80D67F856EBF389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B636DA1BED736F9328CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22493271950E746CB25C76E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8BEE6865575290A7923AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735F3CCD8A865B74A75C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5420B173A62E3A8315002B1117B3ED696520735A967309947AD0703CEB2EF9A27823CB91A9FED034534781492E4B8EEADDFC043C56F70D752BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6593575C9BDA97120FA17F3F6A2D1C6318A9C83E613ADF20B74F31A295C573B1BCCEA66615BA29762C7B8341EE9D5BE9A0AAF9AD2153ED04E41288790C6285C1B4E7FD0ED6A930B3F3A8CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVdbVVJCphTR/nGSdkLNGWgI= X-Mailru-Sender: 520A125C2F17F0B17094CDC02B85F11B5714D40ADD76BB9C3DE06ABAFEAF6705D29487982D20A1F1B7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] Prevent recording of loops with -0 step or NaN values. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Updated the comment as we discussed offline. Branch is force-pushed. On 13.03.26, Sergey Kaplun via Tarantool-patches wrote: > Hi, Sergey! > See my answer below. > > On 13.03.26, Sergey Bronnikov wrote: > > Hi, Sergey, > > > > thanks for the fixes! > > > > Sergey > > > > On 3/13/26 13:07, Sergey Kaplun wrote: > > > > > > > > > > >>> +local function test_trace_recorded(test_payload) > > >>> + jit.flush() > > >>> + -- Reset hotcounters. > > >> nit: comment can be omitted > > > I prefer not to. There may be the question: why we don't declare this > > > parameters once? The reason is that the hotcounters may cause collisions > > > and lead to the false-positive tests failures. Should I make the comment > > > more verbose? > > > > We reset hotcounters in tests about 470 times (grep -R -B 1 "hotloop=1" > > test | wc -l) and only > > > > 15 times we add a comment like "Reset hotcounters.". You add a comment > > here but missed it in the patch > > > > "MIPS64: Avoid unaligned load in lj_vm_exit_interp.". Why we should > > leave comment here and > > > > omit it the aforementioned patch? I'll not insist removing it, just > > interesting, it is not an issue for blocking merge. > > The main idea is to prevent the hotcount collisions between any other > functions that may possibly get hot. Unaligned load isn't a problem then > since we have no check for JIT semantics (no calls to `jit.util.traceinfo()`). > The same approach is vital for all checks that assume the specific trace > recording (or abortion). Hence, this comment is added in the first > place to attract the attention of the reader to these "standard lines", > which are not standard at all (since it is not done in the main chunk only > once). > > Than the question is: should I make the comment more verbose and > specific? Made the comment more verbose: =================================================================== diff --git a/test/tarantool-tests/lj-1432-minus-zero-step.test.lua b/test/tarantool-tests/lj-1432-minus-zero-step.test.lua index 112153dc..e3b97dde 100644 --- a/test/tarantool-tests/lj-1432-minus-zero-step.test.lua +++ b/test/tarantool-tests/lj-1432-minus-zero-step.test.lua @@ -42,7 +42,7 @@ end local function test_trace_recorded(test_payload) jit.flush() - -- Reset hotcounters. + -- XXX: Reset hotcounters to avoid false-positive collisions. jit.opt.start('hotloop=1', 'hotexit=1') test_payload() return traceinfo(1) diff --git a/test/tarantool-tests/lj-1433-nan-for-loop-control-var.test.lua b/test/tarantool-tests/lj-1433-nan-for-loop-control-var.test.lua index b9e5ad92..f7566d6a 100644 --- a/test/tarantool-tests/lj-1433-nan-for-loop-control-var.test.lua +++ b/test/tarantool-tests/lj-1433-nan-for-loop-control-var.test.lua @@ -62,7 +62,7 @@ end local function test_trace_recorded(test_payload) jit.flush() - -- Reset hotcounters. + -- XXX: Reset hotcounters to avoid false-positive collisions. jit.opt.start('hotloop=1', 'hotexit=1') test_payload() return traceinfo(1) =================================================================== > > > > > > > > > > -- > Best regards, > Sergey Kaplun -- Best regards, Sergey Kaplun