From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D9AC716AEDF8; Fri, 13 Mar 2026 17:41:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D9AC716AEDF8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1773412866; bh=RlkZYcB/0Ma5S3xhr3EnN9PQ+nNrEHwnaV+1Z827uyM=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=dMgB+FHTbfOEgZs8VlDdWaBG0YRyTqOZ5Y1GW0BMgNjhWo6ODB7sH5yoqkdPNCQ+X PA+6rEM3fS8vo5SApQBu0JqyoXTjuO/Ua5U5FZUqpkZwqFbGp5vzFlu1Knpp5XBeHQ 58zpawdkYMU4C8f14gYHD+kKADFLTE9t6CAaw2kY= Received: from send196.i.mail.ru (send196.i.mail.ru [95.163.59.35]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E58DB16AEDFB for ; Fri, 13 Mar 2026 17:41:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E58DB16AEDFB Received: by exim-smtp-64cdfc6c8d-zwjhg with esmtpa (envelope-from ) id 1w13hH-00000000MAI-3TAW; Fri, 13 Mar 2026 17:41:04 +0300 Date: Fri, 13 Mar 2026 17:41:59 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <334e8dd174e6f4c9a03b3a5827c36d5353a85238.1773330679.git.skaplun@tarantool.org> <4454d7e1-43a6-4151-b39f-26fec9a7f04d@tarantool.org> <256a4bfa-edea-4971-b5c3-3b94a102c6d9@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <256a4bfa-edea-4971-b5c3-3b94a102c6d9@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91ABAE9865AC7DC88FC8E858B59FB0AE6229594E9989AC72B182A05F538085040A4DC775239568C5D3DE06ABAFEAF67059900315E46DC1BB23CFA0A272F8203FB906DE0852CB23DE4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75263010198C72082EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB553375661EAFBE79684C2D41B417E6FD476FF7FF7859AB185F370DDB7E7A8380F3C3E588389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B652D31B9D28593E51CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22493271950E746CB25C76E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8BEE6865575290A7923AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735D2D576BCF940C736C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5129737E6727BD4C85002B1117B3ED696263A4F76A43CD9F71A1B8FE1FED62FE8823CB91A9FED034534781492E4B8EEADB05233B9BC4759D3 X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6599A5F9B7E5E4DF98AAE175CCC282256F4C0D74F494CDD59BAF480C9F34C21AA949BE7CCFE6194B9EEB8341EE9D5BE9A0AD8369AB616D1034CA118A3970FAA233D6317ACE1925D44258CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVdbVVJCphTR/ms/7AZJSHhc= X-Mailru-Sender: 583F1D7ACE8F49BDD951BA70C165859E6D28B4D5A887D549F7A6B01B8567BB202431E4594BEAE94DFCC05D241E210761F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] Prevent recording of loops with -0 step or NaN values. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! See my answer below. On 13.03.26, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the fixes! > > Sergey > > On 3/13/26 13:07, Sergey Kaplun wrote: > > > > > >>> +local function test_trace_recorded(test_payload) > >>> + jit.flush() > >>> + -- Reset hotcounters. > >> nit: comment can be omitted > > I prefer not to. There may be the question: why we don't declare this > > parameters once? The reason is that the hotcounters may cause collisions > > and lead to the false-positive tests failures. Should I make the comment > > more verbose? > > We reset hotcounters in tests about 470 times (grep -R -B 1 "hotloop=1" > test | wc -l) and only > > 15 times we add a comment like "Reset hotcounters.". You add a comment > here but missed it in the patch > > "MIPS64: Avoid unaligned load in lj_vm_exit_interp.". Why we should > leave comment here and > > omit it the aforementioned patch? I'll not insist removing it, just > interesting, it is not an issue for blocking merge. The main idea is to prevent the hotcount collisions between any other functions that may possibly get hot. Unaligned load isn't a problem then since we have no check for JIT semantics (no calls to `jit.util.traceinfo()`). The same approach is vital for all checks that assume the specific trace recording (or abortion). Hence, this comment is added in the first place to attract the attention of the reader to these "standard lines", which are not standard at all (since it is not done in the main chunk only once). Than the question is: should I make the comment more verbose and specific? > > > > -- Best regards, Sergey Kaplun