From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E73E06ECE3; Wed, 15 Jun 2022 17:31:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E73E06ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1655303473; bh=mglzfyb4DYkkm8YEaGj/C1UnML1nAzxnmaKtivO/jag=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=xaqAIPCGX04Y7hGdYjnJU5v2ChmQgM8IAakHuLVmemaMWled3lDH2GZ17TcoLRd82 X16EdE0Hl2p/x1ywxIM52KeP8QAk8V1TivFRrOIfzx/rDSMWSl8TZxI/I6GeufmN9K 7mDsplVISonHY1XYCc3e9QQkl9gR1xUA6+xuFLdQ= Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4F7466ECE3 for ; Wed, 15 Jun 2022 17:31:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4F7466ECE3 Received: by smtp50.i.mail.ru with esmtpa (envelope-from ) id 1o1U35-0002eK-Mo; Wed, 15 Jun 2022 17:31:12 +0300 Message-ID: Date: Wed, 15 Jun 2022 17:31:11 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD97D44297578DBEB86CC0506E018D2C7F54E241DB180169FE4182A05F5380850405798AAB1B70E6F444BB0945E8E1BE170CEF0E5CF77160643C2B210C116A76254 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7CC84CC3AD347B910EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006373C9FC9F3BACECB908638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C543B75E8F96BA23FB8544D8A905D48C117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18F04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE140C956E756FBB7AC766E17BBE5724E9D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE30CABCCA60F52D7EB302FCEF25BFAB345C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637870CFFD37CCFDD3AEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E14218C6CDE5D1141D2B1C84931AE52FD96C7A7533F3451B42890A0C60779D081BC1F9AD91A466A1DEF99B296C473AB1E14218B936CB490224F2464EEA7BD89490CAC0EDDA962BC3F61961 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34829444FF2D8CB89B2B86932156A38AD8F4B3658443A6BD45225E87422E8E819304C893859F2607991D7E09C32AA3244C1167238A195259DD246BFE1DC126DB6FC3B3ADDA61883BB5729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojCCvLuneITNoYGfbhsT/prw== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F25884588C60D20AAD76C5C7ECED324257B91B9B9A2BE6A8D2757B01282EC151BADDC1D3523A6D01B4765B2DFB59E2DDD9FE06B14FA522850F29BC30B0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [v2][PATCH 4/5] build/ninja: create file lists outside of cmake commands X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, thanks for review! On 15.06.2022 12:19, Sergey Kaplun via Tarantool-patches wrote: > Hi, Sergey! > > Thanks for the patch! > > LGTM, except a few nits regarding the commit message. > > On 02.06.22, Sergey Bronnikov via Tarantool-patches wrote: >> Patch adds a last change required for building LuaJIT with Ninja - using > Typo: s/Patch/The patch/ Fixed, thanks. > >> glob inside CMake commands (add_custom_command and >> set_source_files_properties) breaks buildng with Ninja. > Typo: s/buildng/building/ Fixed, thanks! >> By default CMake generates files suitable for building a project with >> Make. However, it allows to generate files for Ninja too. Ninja [1] may >> build project a bit faster than Make, see comparison in [2]. > Typo: s/comparison/the comparison/ Fixed, thanks! >> How-to build with Ninja: >> >> $ cmake -G Ninja -B build -S . >> $ cmake --build build --parallel > Side note: Unfortunately `make test` command (or what should I use for > tests, when build with ninja?) Use 'ninja' instead: sergeyb@pony:~/sources/MRG/tarantool/third_party/luajit$ cmake -G Ninja -B . -S . -- The C compiler identification is GNU 9.4.0 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: /usr/bin/cc - skipped -- Detecting C compile features -- Detecting C compile features - done -- [SetVersion] Reading version from VCS: v2.1.0-beta3-193-gd8c86e28 -- The ASM compiler identification is GNU -- Found assembler: /usr/bin/cc -- Configuring done -- Generating done -- Build files have been written to: /home/sergeyb/sources/MRG/tarantool/third_party/luajit sergeyb@pony:~/sources/MRG/tarantool/third_party/luajit$ ninja -f build.ninja [165/165] Linking C static library src/libluajit.a sergeyb@pony:~/sources/MRG/tarantool/third_party/luajit$ ninja -f build.ninja test >>> closing state <<< sergeyb@pony:~/sources/MRG/tarantool/third_party/luajit$ echo $? 0 sergeyb@pony:~/sources/MRG/tarantool/third_party/luajit$ or even do everything (confgure and build) using CMake: sergeyb@pony:~/sources/MRG/tarantool/third_party/luajit$ cmake -G Ninja -B . -S . -- The C compiler identification is GNU 9.4.0 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: /usr/bin/cc - skipped -- Detecting C compile features -- Detecting C compile features - done -- [SetVersion] Reading version from VCS: v2.1.0-beta3-193-gd8c86e28 -- The ASM compiler identification is GNU -- Found assembler: /usr/bin/cc -- Configuring done -- Generating done -- Build files have been written to: /home/sergeyb/sources/MRG/tarantool/third_party/luajit sergeyb@pony:~/sources/MRG/tarantool/third_party/luajit$ cmake --build . --parallel [165/165] Linking C static library src/libluajit.a sergeyb@pony:~/sources/MRG/tarantool/third_party/luajit$ > fails with the following error: > > | Checking /home/burii/reviews/luajit/ninja/build/src/jit/vmdef.lua 3 warnings > | > | /home/burii/reviews/luajit/ninja/build/src/jit/vmdef.lua:5:121: (W631) line is too long (595 > 120) > | /home/burii/reviews/luajit/ninja/build/src/jit/vmdef.lua:7:121: (W631) line is too long (613 > 120) > | /home/burii/reviews/luajit/ninja/build/src/jit/vmdef.lua:11:121: (W631) line is too long (273 > 120) > > But this is the problem of OOS build (default for ninja), not this > patch, IINM. Hmm, it works fine for me (see output above). But yes, luacheck has a problems with running OOS. See description of the problem in [1]. The problem was workarounded in Tarantool source repository, see commit: commit af448464d15f60b87f1c9ef41a7816911c889459 Author: Alexander Turenko Date:   Wed Nov 11 10:09:25 2020 +0300     tools: fix luacheck invocation in different cases     Now `make luacheck` gracefully handles different cases[^1]: in-source     and out-of-source build (within the source tree or outside), current     working directory as a real path or with symlink components.     As result of looking into those problems I filed the issue [1] against     luacheck. It seems, there are problems around absolute paths with     symlinks components.     [^1]: We have the similar problems with LuaJIT's luacheck rule. They           will be fixed in a separate patch.     [1]: https://github.com/mpeterv/luacheck/issues/208     Reviewed-by: Sergey Bronnikov     Reviewed-by: Igor Munkin 1. https://github.com/mpeterv/luacheck/issues/208 > >> 1. https://ninja-build.org/ >> 2. https://mesonbuild.com/Simple-comparison.html >> --- >> src/host/CMakeLists.txt | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/src/host/CMakeLists.txt b/src/host/CMakeLists.txt >> index e01db87d..1ce3e224 100644 >> --- a/src/host/CMakeLists.txt >> +++ b/src/host/CMakeLists.txt > > >> -- >> 2.25.1 >>